On 04/28/2015 01:49 PM, Andreas Grünbacher wrote:
Hmm well, you are probably right that gl_FUNC_ACL does get called before
gl_FILE_HAS_ACL. But the order should be deterministic in any case, no?
Yes, so the code in acl.m4 can be simplified accordingly (it's not
buggy, just overly complex).
Avoid [-Wunknown-attributes] warnings like:
warning: unknown attribute '__alloc_size__' ignored
* lib/xalloc.h: Don't use the __alloc_size__ attribute
with clang, as support has been fully removed as of clang 3.5:
https://github.com/llvm-mirror/clang/commit/c047507a
* lib/eealloc.h: Likewise.
* l
2015-04-28 22:28 GMT+02:00 Paul Eggert :
>> Function gl_FILE_HAS_ACL depends on gl_FUNC_ACL to be called
>> afterwards, and gl_FUNC_ACL does get called through the gnulib module
>> dependencies. Now why is LIB_HAS_ACL being set in both functions?
>>
> I worried that gl_FILE_HAS_ACL might be invoked
On 04/28/2015 04:45 AM, Andreas Grünbacher wrote:
I would rather have gnulib define XATTR_NAME_POSIX_ACL_ACCESS and
XATTR_NAME_POSIX_ACL_DEFAULT when the kernel headers don't provide
them:
I don't know the Linux kernel that well, but if it sounds good to you
Function gl_FILE_HAS_ACL depen
2015-04-28 13:48 GMT+02:00 Andreas Grünbacher :
> Any progress with the qset_acl and qcopy_acl rewrite on non-Linux platforms?
(I've just pushed minor fixes to my github repositories for that.)
Thanks,
Andreas
2015-04-21 5:40 GMT+02:00 Pádraig Brady :
> I dislike this change actually.
> Or more accurately, the gnulib change that changed the file_has_acl()
> interface, requiring this change.
>
> Previously in gnulib we mapped ENOTSUP to return 0 using:
> http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f
2015-04-26 20:06 GMT+02:00 Tom G. Christensen :
> On 26/04/15 18:22, Paul Eggert wrote:
>>
>> Thanks for reporting that. I installed the attached patch, which should
>> fix it.
>
>
> Confirmed, thanks.
I would rather have gnulib define XATTR_NAME_POSIX_ACL_ACCESS and
XATTR_NAME_POSIX_ACL_DEFAULT
