Re: [PATCH] posixtm: avoid compiler warning in a better way

2014-12-09 Thread Thien-Thi Nguyen
() Paul Eggert () Tue, 9 Dec 2014 18:12:51 -0800 + dot = strchr (s, '.'); Can we use ‘memchr (s, '.', s_len)’ here? -- Thien-Thi Nguyen GPG key: 4C807502 (if you're human and you know it) read my lisp: (responsep (questions 'technical) (not (

[PATCH] diffseq: avoid compiler warning when !USE_HEURISTIC

2014-12-09 Thread Daiki Ueno
Hello, I got a minor warning when compiling gettext, which uses the 'diffseq' module without USE_HEURISTIC set. diffseq.h: In function 'diag': diffseq.h:189:12: warning: variable 'big_snake' set but not used [-Wunused-but-set-variable] bool big_snake = false; ^ Here i

[PATCH] posixtm: avoid compiler warning in a better way

2014-12-09 Thread Paul Eggert
* lib/posixtm.c (IF_LINT): Remove. (year, posix_time_parse): Return true (not 0) if successful. All callers changed. (posix_time_parse): Simplify to pacify GCC without need for IF_LINT. --- ChangeLog | 8 ++ lib/posixtm.c | 80 ---