Re: [PATCH] vasnprintf: fix potential use after free

On 12/05/2014 06:23 PM, Pádraig Brady wrote: > * lib/vasnprintf.c (VASNPRINTF): Fix free-memory read, > flagged by clang-analyzer 3.4.2. > --- > ChangeLog| 6 ++ > lib/vasnprintf.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > +++ b/lib/vasnprintf.c > @@ -5184,13 +518

Re: [PATCH 0/5] obstacks again

On Fri, Dec 05, 2014 at 09:02:46PM +, Gary V. Vaughan wrote: > If there's a way to at least diagnose negative arguments rather than silently > change behavior, that would save other projects some migration headaches... We could diagnose one of the m4 uses of obstack_blank at compile time, but

[PATCH] apply _GL_ATTRIBUTE_PURE to some inline functions

clang 3.4.2 flagged these inline functions as pure * lib/savewd.h (savewd_errno): Set _GL_ATTRIBUTE_PURE. * lib/sig-handler.h (get_handler): Likewise. * lib/stat-time.h (get_stat_{a,c,m,birth}time{,_ns}): Likewise. * lib/timespec.h (timespec_cmp, timespec_sign): Likewize. --- lib/savewd.h |

[PATCH] vasnprintf: fix potential use after free

* lib/vasnprintf.c (VASNPRINTF): Fix free-memory read, flagged by clang-analyzer 3.4.2. --- ChangeLog| 6 ++ lib/vasnprintf.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 1c4a7ab..41207ea 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,

Re: [PATCH 0/5] obstacks again

On Dec 5, 2014, at 7:13 PM, Eric Blake wrote: > On 10/29/2014 09:35 PM, Paul Eggert wrote: >> Alan Modra wrote: >> >>> One thing though, I didn't put the ChangeLog diffs in the patch as I >>> usually add them when committing. >> >> Oh, I missed that. I added them now. For Gnulib it's better to

Re: recent changes to obstacks cause many out of memory failures in M4 master testsuite

Hi Eric, > On Dec 5, 2014, at 7:11 PM, Eric Blake wrote: > > On 12/05/2014 12:03 PM, Gary V. Vaughan wrote: > >> Bisecting my way to the the first gnulib changeset that causes these >> failures, I landed at: >> >> bb2ab7e 2014-10-29 14:02 Alan Modra obstack: 64-bit obstack support, part >

Re: [PATCH 0/5] obstacks again

On 10/29/2014 09:35 PM, Paul Eggert wrote: > Alan Modra wrote: > >> One thing though, I didn't put the ChangeLog diffs in the patch as I >> usually add them when committing. > > Oh, I missed that. I added them now. For Gnulib it's better to put > them into the patch. > >> It is no longer possi

Re: recent changes to obstacks cause many out of memory failures in M4 master testsuite

On 12/05/2014 12:03 PM, Gary V. Vaughan wrote: > Bisecting my way to the the first gnulib changeset that causes these > failures, I landed at: > > bb2ab7e 2014-10-29 14:02 Alan Modra obstack: 64-bit obstack support, part > 2 > > Which is not surprising as GNU M4 uses GNU obstack extensivel

recent changes to obstacks cause many out of memory failures in M4 master testsuite

Hi, To pick up bug fixes in maint.mk required for 'make public-submodule-commit' and dependers to work on Mac OS X 10.10, I just tried to update GNU M4's master branch to gnulib master HEAD, but that causes a raft of test failures where m4 bails out with a 'memory exhausted' error before comple

Re: ARGP: Documentation of

Robert Hairgrove roberthairgrove.com> writes: > If argp_parse calls exit() and terminates the program, will the destructors > of my C++ objects be called? Silly question ... now I realize that they won't be called unless I take appropriate precautions, such as keeping a global vector of unique_pt

Re: [PATCH] printf: fix configure check on big endian systems

On Fri, Dec 5, 2014 at 2:37 AM, Bruno Haible wrote: > Pádraig Brady wrote on 2014-11-27: >> + printf: fix configure check on big endian systems >> + * m4/printf.m4 (gl_PRINTF_INFINITE_LONG_DOUBLE): Add missing bracket. > > The same typo occurs in a few other places as well. I'm fixing them

Re: "test-lock" stuck on FreeBSD

On 4 December 2014 at 21:33, Daiki Ueno wrote: > Ed Maste writes: > >> OK, I can reproduce it in a single-vCPU bhyve VM (the default is 2). >> Do you mind checking if it's no longer reproducible in KVM with 2 or >> more vCPUs? > > Thanks, it indeed seems to fix the issue: Thanks for confirming.

Re: ARGP: Documentation of

Robert Hairgrove roberthairgrove.com> writes: > Robert Hairgrove roberthairgrove.com> writes: > > I am writing some little C++ wrapper classes for the argp functions. ... One more question: If argp_parse calls exit() and terminates the program, will the destructors of my C++ objects be called?

[PATCH] filevercmp, posixtm: avoid compiler warnings with -O3

* lib/filevercmp.h (filevercmp): Tag with _GL_ATTRIBUTE_PURE * lib/posixtm.c: (IF_LINT): Define. (posix_time_parse): Use it to void a "may be used uninitialized" warning, seen only with -O3. --- lib/filevercmp.h | 2 +- lib/posixtm.c| 9 + 2 files changed, 10 insertions(+), 1 deletion(

Re: [PATCH] printf: fix configure check on big endian systems

Pádraig Brady wrote on 2014-11-27: > + printf: fix configure check on big endian systems > + * m4/printf.m4 (gl_PRINTF_INFINITE_LONG_DOUBLE): Add missing bracket. The same typo occurs in a few other places as well. I'm fixing them in the same way. 2014-12-05 Bruno Haible Fix

Re: [PATCH 15/21] freopen: workaround freopen() on OS/2 kLIBC

KO Myung-Hun wrote: > I also don't want to break the convention. > > Fixed. Thanks. This looks perfect now. Bruno

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

KO Myung-Hun wrote: > > > Paul Eggert wrote: >> KO Myung-Hun wrote: >>> I want to do later separately. No ? >> >> You could put it in a later patch, I suppose, but I wouldn't want to >> install this patch without also installing the later patch. > > Ok. I'll try later. > Done. Review, please