Paul Eggert writes:
> On 10/23/2014 04:43 AM, Pádraig Brady wrote:
>> Except for the assert() nit, I can't find any issues.
>
> My only nit was adding the "#if 0"; might as well just delete the code
> instead. I only read the code; I didn't test it.
Thanks. Will fix those in the next update.
Eli Zaretskii writes:
>> The attached patch tries to suppress it. Perhaps
>> gnulib/tests/test-iconv.c also needs a fix.
>>
>> I've tested it on MSYS after manually adding 'const' to the iconv
>> declaration in /usr/local/include/iconv.h, and it seems to be detected.
>>
>> Here is a new test p
> I've tested it on MSYS after manually adding 'const' to the iconv
> declaration in /usr/local/include/iconv.h, and it seems to be
> detected.
>
> Here is a new test package:
> http://du-a.org/~ueno/junk/test-iconv-2.tar.gz
Thanks for your quick response; I've updated your patch in the groff
re
On 10/23/2014 04:43 AM, Pádraig Brady wrote:
Except for the assert() nit, I can't find any issues.
My only nit was adding the "#if 0"; might as well just delete the code
instead. I only read the code; I didn't test it.
> From: Daiki Ueno
> Cc: ebl...@redhat.com, w...@gnu.org, bug-gnulib@gnu.org
> Date: Thu, 23 Oct 2014 13:09:11 +0900
>
> > Next, it looks to me that the test program in iconv.m4 is
> > inappropriate for a C++ compiler, because (AFAIK) C++ does not allow
> > type-casting of the kind that the ori
On 10/23/2014 03:07 PM, Ingo Schwarze wrote:
> +if test $? -ge 126; then
> + ($2 --version +fi
Thanks for the quick testing.
I've pushed that now.
thanks,
Pádraig.
Hi Pádraig,
thank you for looking into this quirk.
Your patch looks reasonable and works for me.
For one minor suggestion, see below.
Pádraig Brady wrote on Thu, Oct 23, 2014 at 02:06:13PM +0100:
> On 10/18/2014 05:58 PM, Ingo Schwarze wrote:
>> On OpenBSD, the usual way to install the autotool
On 09/29/2014 03:49 AM, Andrei Borzenkov wrote:
> According to
> http://www.gnu.org/software/libc/manual/html_node/Argp-Flags.html#Argp-Flags,
> when ARGP_NO_ERRS is set, the effect is "Don’t print error messages for
> unknown options to stderr". In reality when ARGP_NO_ERRS is set, all
> help outp
On 10/18/2014 05:58 PM, Ingo Schwarze wrote:
> Hi,
>
> this is maybe not a full-grown bug, more like a quirk, but is is
> sure bound to cause confusion, so i'd like to hear what you think...
>
> I'm the maintainer of the OpenBSD port of groff (GNU troff),
> and Bertrand (see Cc:) is currently mig
On 10/19/2014 11:58 PM, Reuben Thomas wrote:
> It should run something like "git submodule update -- gnulib" rather than
> just "git submodule update".
Good point.
Proposed fix attached.
thanks,
Pádraig.
>From e94cfb19c8d84a09cd2827ec2f75222c6e854781 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C
On 10/23/2014 09:01 AM, Daiki Ueno wrote:
> Hello,
>
> This is an update of the patches I posted on bug-libunistring two weeks ago:
> https://lists.gnu.org/archive/html/bug-libunistring/2014-10/msg1.html
>
> Changes from v1:
> - The line-breaking implementation has been updated for LBP_HL and
On 10/23/2014 09:01 AM, Daiki Ueno wrote:
> * lib/gen-uni-tables.c (output_category, output_bidi_category)
> (output_joining_type, output_ident_category): Check out-of-range
> values added to 3-level tables.
> ---
> lib/gen-uni-tables.c | 13 +
> 1 file changed, 13 insertions(+)
>
> d
* lib/unilbrk/lbrktables.h (LBP_RI): New enumeration value.
(unilbrk_table): Adjust table size.
* lib/unilbrk/lbrktables.c (unilbrk_table): Add a row and column
for LBP_RI.
* lib/uniwbrk.in.h (WBP_RI): New enumeration value.
* lib/uniwbrk/u-wordbreaks.h (FUNC): Support rule WB13c.
Normalize table
* lib/unictype/joininggroup_byname.gperf: Add Rohingya Yeh
joining group name.
* lib/unictype/joininggroup_name.h: Likewise.
* lib/unilbrk/lbrktables.h (LBP_HL): New enumeration value.
(unilbrk_table): Adjust table size.
* lib/unilbrk/lbrktables.c (unilbrk_table): Add a row and column
for LBP_HL.
* lib/gen-uni-tables.c (output_joining_group): Switch to
3-level table to accommodate a joining group defined with higher
code-point value. Since there are only 88 groups defined in
Unicode 7.0.0, use 7-bit packed format for level3 entries.
* lib/unictype/joininggroup_of.c (uc_joining_group): Adju
* lib/gen-uni-tables.c (output_category, output_bidi_category)
(output_joining_type, output_ident_category): Check out-of-range
values added to 3-level tables.
---
lib/gen-uni-tables.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/gen-uni-tables.c b/lib/gen-uni-tables.c
in
The uniname module tries to reduce memory usage by grouping Unicode
codepoints so that each codepoint fit into a 16-bit integer (4-bit tag
plus 12-bit index). However, this transformation cannot represent all
the characters in Unicode 7.0, where > 16 groups are needed.
The attached patch tries to
* modules/uniwbrk/u32-wordbreaks-tests (Files): Add
tests/uniwbrk/test-uc-wordbreaks.c,
tests/uniwbrk/test-uc-wordbreaks.sh, and
tests/uniwbrk/WordBreakTest.txt.
(Makefile.am): Add uniwbrk/test-uc-wordbreaks.sh to $(TESTS), add
test-uc-wordbreaks to $(check_PROGRAMS), and define
test_uc_wordbreaks_
* lib/uniwbrk/u-wordbreaks.h (FUNC): Ignore Extend and Format
characters if the previous character property is one of
WBP_NEWLINE, WBP_CR, and WBP_LF.
---
lib/uniwbrk/u-wordbreaks.h | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/uniwbrk/u-wordbreaks.h b/lib/uniwbr
* tests/uniwbrk/test-uc-wordbreaks.c
(wordbreakproperty_to_string): Support WBP_DQ, WBP_SQ, and WBP_HL.
* lib/uniwbrk.in.h (WBP_DQ, WBP_SQ, WBP_HL): New enumeration values.
* lib/uniwbrk/u-wordbreaks.h (FUNC): Support WB7a, WB7b, and WB7c.
Update WB5, WB6, WB7, WB9, WB11, WB12, WB13a, and WB13b.
*
Hello,
This is an update of the patches I posted on bug-libunistring two weeks ago:
https://lists.gnu.org/archive/html/bug-libunistring/2014-10/msg1.html
Changes from v1:
- The line-breaking implementation has been updated for LBP_HL and LBP_RI
- The changes to gen-uninames.lisp is included
-
* lib/gen-uni-tables.c: Escape newlines in the Emacs file local
variables specification.
(is_outdigit): Comment out the unused function.
---
lib/gen-uni-tables.c | 43 ++-
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/lib/gen-uni-tables.c b
22 matches
Mail list logo
