Re: [PATCH 5/5] obstack usability

On Sat, Jul 26, 2014 at 07:48:21AM -0400, Paul Eggert wrote: > On 07/26/2014 01:57 AM, Alan Modra wrote: > >When using obstack.h/c in other projects it isn't very nice that gnulib > >headers like exitfail.h and gettext.h need to be present. Far worse > >is a dependency on gnulib's version of stdli

Re: [PATCH 5/5] obstack usability

Paul Eggert writes: > On 07/26/2014 07:21 AM, Alan Modra wrote: > >+# elif defined _MSC_VER && 1200 <= _MSC_VER >>> > >>> >Please write that as "_MSC_VER >= 1200". >> Thanks for looking over the patch. This line was taken out of >> gnulib/m4/gnulib-common.m4.. >> >> I'm happy to fix this

Re: [PATCH 5/5] obstack usability

On 07/26/2014 07:21 AM, Alan Modra wrote: > >+# elif defined _MSC_VER && 1200 <= _MSC_VER > >Please write that as "_MSC_VER >= 1200". Thanks for looking over the patch. This line was taken out of gnulib/m4/gnulib-common.m4.. I'm happy to fix this oddity and others like it, I'd rather leave

Re: [PATCH 5/5] obstack usability

On 07/26/2014 01:57 AM, Alan Modra wrote: When using obstack.h/c in other projects it isn't very nice that gnulib headers like exitfail.h and gettext.h need to be present. Far worse is a dependency on gnulib's version of stdlib.h for __attribute_pure__ and _Noreturn. This only works if a projec

Re: [PATCH 5/5] obstack usability

On Sat, Jul 26, 2014 at 09:20:36AM +0200, Andreas Schwab wrote: > Alan Modra writes: > > > +# elif defined _MSC_VER && 1200 <= _MSC_VER > > Please write that as "_MSC_VER >= 1200". Thanks for looking over the patch. This line was taken out of gnulib/m4/gnulib-common.m4.. I'm happy to fix th

Re: [PATCH 5/5] obstack usability

Alan Modra writes: > +# elif defined _MSC_VER && 1200 <= _MSC_VER Please write that as "_MSC_VER >= 1200". Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."