Re: Fix libunistring in MS-Windows locales

2014-07-17 Thread Daiki Ueno
Eli Zaretskii writes: >> I'm not familiar with Windows TLS support, but '__thread' seems to be >> compiler specific. > > Do we care for any Windows compilers except GCC? I was rather worried about particular versions of GCC, which might not support it at all (< 3.3?), or might require extra comp

Re: Fix libunistring in MS-Windows locales

2014-07-17 Thread Paul Eggert
Eli Zaretskii wrote: Do we care for any Windows compilers except GCC? Not as far as I know, for Gnulib. (Though I'm no Windows expert.)

Re: Fix libunistring in MS-Windows locales

2014-07-17 Thread Eli Zaretskii
> From: Daiki Ueno > Cc: egg...@cs.ucla.edu, bug-gnulib@gnu.org > Date: Thu, 17 Jul 2014 12:59:59 +0900 > > Eli Zaretskii writes: > > >> By the way, isn't there a minor race in gl_locale_name_thread, since it > >> depends on a global variable found_lcid? > > > > Yes. (It is not a problem for

Re: [PATCH] parse_long_options: after --help, avoid fallthrough into --version

2014-07-17 Thread Bernhard Voelker
On 07/17/2014 03:00 AM, Jim Meyering wrote: > On Wed, Jul 16, 2014 at 3:43 PM, Bernhard Voelker > wrote: >> case 'h': >>(*usage_func) (EXIT_SUCCESS); >> + exit (EXIT_SUCCESS); > > Does that elicit a dead-code warning, when some static analysis > tool notices the stat