Re: parse-duration.c - TIME_MAX 2038 unpreparedness

2014-06-14 Thread Bruce Korb
On 06/11/14 15:46, Jim Meyering wrote: I wrote the patch, and tested by running this: ./gnulib-tool --create-testdir --dir=/tmp/x --with-tests --test parse-duration Excellent. Please push it, thank you!

Re: parse-duration.c - TIME_MAX 2038 unpreparedness

2014-06-14 Thread Bruce Korb
On 06/10/14 17:49, Jim Meyering wrote: Why impose such a limit? I'd go with TYPE_MAXIMUM (time_t). a) because I do not read BASH headers (or any other headers) for fun. Unless I get bumped somehow, I don't know about such things, and b) like I said, if anybody on the planet really needs a t

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Paul Eggert
Pádraig Brady wrote: Looks good thanks, though it would be worth mentioning in the commit why extensions is used. Thanks, I pushed the attached. From 5d34c7ba14c0b85c1e9130f5ca0514d9e4adeeb2 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 14 Jun 2014 12:33:26 -0700 Subject: [PATCH] pthre

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Pádraig Brady
On 06/14/2014 06:08 PM, Paul Eggert wrote: > I looked into this some more, and found some problems: > > * On Solaris we also need to define _POSIX_PTHREAD_SEMANTICS to prefer POSIX > to pre-POSIX semantics for a few functions; see >

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Paul Eggert
I looked into this some more, and found some problems: * On Solaris we also need to define _POSIX_PTHREAD_SEMANTICS to prefer POSIX to pre-POSIX semantics for a few functions; see . The extensions module does this, so a si

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Jim Meyering
Thanks. That looks fine, but please change "thread safe" to "thread-safe" everywhere.

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Pádraig Brady
On 06/13/2014 11:07 PM, Paul Eggert wrote: > Pádraig Brady wrote: > > >> + case "$host_os" in >> + aix* | freebsd*) CPPFLAGS="$CPPFLAGS -D_THREAD_SAFE" ;; >> + solaris*) CPPFLAGS="$CPPFLAGS -D_REENTRANT" ;; > > Why not use AC_DEFINE([_THREAD_SAFE], 1, ...) instead? That makes fo