[PATCH] mountlist: ensure hasmntopt's opt argument is passed with correct type

2014-06-03 Thread Ben Walton
* Solaris defines hasmntop with a char * instead of const char * second argument. Passing the constant string "ignore" generates a compiler warning. Define MNT_IGNORE correctly in both cases to avoid the warning. Signed-off-by: Ben Walton --- lib/mountlist.c | 8 +++- 1 file changed, 7

Re: autoconf warning in gl_EARLY

2014-06-03 Thread Denis Laroche
Thanks, that worked. I put gl_EARLY at this location on the suggestion of gnulib-tool. 2014-06-02 8:58 GMT-04:00 Eric Blake : > On 06/01/2014 12:16 PM, Denis Laroche wrote: >> I'm not sure if the post should be sent to the autoconf mailing list >> instead. I see the following warnings from gl_EAR

Re: [PATCH][BZ #16907] Sync argp.h __attribute__ with gnulib.

2014-06-03 Thread Aurelien Jarno
On Tue, Jun 03, 2014 at 01:28:00PM +0200, Ondřej Bílka wrote: > On Tue, Jun 03, 2014 at 12:59:11PM +0200, Aurelien Jarno wrote: > > On Fri, May 23, 2014 at 07:34:57PM +0200, Ondřej Bílka wrote: > > > On Fri, May 23, 2014 at 07:53:11AM -0700, Paul Eggert wrote: > > > > Ondřej Bílka wrote: > > > > >C

Re: [PATCH][BZ #16907] Sync argp.h __attribute__ with gnulib.

2014-06-03 Thread Aurelien Jarno
On Fri, May 23, 2014 at 07:34:57PM +0200, Ondřej Bílka wrote: > On Fri, May 23, 2014 at 07:53:11AM -0700, Paul Eggert wrote: > > Ondřej Bílka wrote: > > >CCing gnulib. Could this be backported also there or do you have > > >different solution? > > > > We solved this problem in a different way year

Re: [PATCH][BZ #16907] Sync argp.h __attribute__ with gnulib.

2014-06-03 Thread Ondřej Bílka
On Tue, Jun 03, 2014 at 12:59:11PM +0200, Aurelien Jarno wrote: > On Fri, May 23, 2014 at 07:34:57PM +0200, Ondřej Bílka wrote: > > On Fri, May 23, 2014 at 07:53:11AM -0700, Paul Eggert wrote: > > > Ondřej Bílka wrote: > > > >CCing gnulib. Could this be backported also there or do you have > > > >d

Re: [PATCH] lib/rename.c: rpl_rename - Avoid unused-but-set-variable compiler warning

2014-06-03 Thread Pádraig Brady
On 06/02/2014 08:45 PM, Ben Walton wrote: > The value is set in se > > On Mon, Jun 2, 2014 at 8:31 PM, Pádraig Brady wrote: >> On 06/02/2014 08:13 PM, Ben Walton wrote: >>> * In the non-Win32 variant of rpl_rename, it is possible that >>> dst_exists may be set but not used. Mark it with the