Strict C does not allow converting a function pointer to void *
and vice versa. Pass a pointer to a function pointer instead.
* lib/exclude.c (add_exclude_file):
Pass the address of the function pointer.
(call_addfn): And deference the address here, to match.
---
ChangeLog | 9 +
lib/
On 04/19/2014 01:07 AM, Assaf Gordon wrote:
> But wait... just to verify before pushing this...
>
> On 04/18/2014 07:59 PM, Pádraig Brady wrote:
>> On 04/18/2014 11:06 PM, Assaf Gordon wrote:
>>>
>>> A recent change added a stub "git-log-fix" file to gnulib:
>>> http://git.savannah.gnu.org/gitweb
But wait... just to verify before pushing this...
On 04/18/2014 07:59 PM, Pádraig Brady wrote:
On 04/18/2014 11:06 PM, Assaf Gordon wrote:
A recent change added a stub "git-log-fix" file to gnulib:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=ce457d622d947d8aa3e325d98a2818d097e
On 04/18/2014 11:06 PM, Assaf Gordon wrote:
> Hello,
>
> A recent change added a stub "git-log-fix" file to gnulib:
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=ce457d622d947d8aa3e325d98a2818d097e7fec9
>
> But, it might have an unintended consequences:
> When updating "gnulib" su
Hello,
A recent change added a stub "git-log-fix" file to gnulib:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=ce457d622d947d8aa3e325d98a2818d097e7fec9
But, it might have an unintended consequences:
When updating "gnulib" submodule in a project, it overrides the project's
"git-lo
On 04/18/2014 06:46 PM, Assaf Gordon wrote:
> Hello,
>
> A minor nit-pick for GnuLib's "make syntax-check",
> where "maint.mk" has the following rule:
> ===
> sc_copyright_check:
> <...>
> @require='Copyright @copyright\{\} .*'$$(date +%Y)' Free' \
> in_vc_files=$(texi)
Hello,
A minor nit-pick for GnuLib's "make syntax-check",
where "maint.mk" has the following rule:
===
sc_copyright_check:
<...>
@require='Copyright @copyright\{\} .*'$$(date +%Y)' Free' \
in_vc_files=$(texi) \
halt='out of
On 04/18/2014 10:16 AM, Natanael Copa wrote:
> * lib/physmem.c (physmem_total): Some systems like musl libc does not
> (yet) support _SC_PHYS_PAGES. Use the linux syscall sysinfo as fallback
> if _SC_PHYS_PAGES or _SC_PAGESIZE fails.
>
> Signed-off-by: Natanael Copa
> ---
> Changes since v1:
> -
Nathan Kennedy wrote:
If saving that one test is worth the risk that MALLOC_0_IS_NONNULL will
always be correctly be defined, e.g. that this will never always be true
for all potential users:
+#ifdef _LIBC
+# define MALLOC_0_IS_NONNULL 1
uClibc defines it too:
libc-symbols.h:#define _LIBC1
On 4/18/2014 1:44 AM, Paul Eggert wrote:
the MALLOC_0_IS_NONNULL macro attempting to check for
malloc(0) failure is not needed.
It's not needed for correctness, but it helps performance on GNU
hosts, no? It lets them avoid an unnecessary test "size != 0" at
runtime. The MALLOC_0_IS_NONNULL te
* lib/physmem.c (physmem_total): Some systems like musl libc does not
(yet) support _SC_PHYS_PAGES. Use the linux syscall sysinfo as fallback
if _SC_PHYS_PAGES or _SC_PAGESIZE fails.
Signed-off-by: Natanael Copa
---
Changes since v1:
- prefer use _SC_PHYS_PAGES * _SC_PAGESIZE if available and us
On Thu, 17 Apr 2014 01:26:13 +0100
Pádraig Brady wrote:
> On 04/15/2014 03:49 PM, Pádraig Brady wrote:
> > On 04/15/2014 03:43 PM, Natanael Copa wrote:
> >> * lib/physmem.c (physmem_total): Some systems like musl libc does not
> >> (yet) support _SC_PHYS_PAGES. Use the linux syscall sysinfo first
12 matches
Mail list logo
