Re: [PATCH] test-open: avoid compilation error with -D_FORTIFY_SOURCE=2

2013-12-09 Thread Pádraig Brady
On 12/05/2013 05:25 PM, Paul Eggert wrote: > -static int > +static int __always_inline > test_open (int (*func) (char const *, int, ...), bool print) This fails `make check` in coreutils... $ make V=1 TESTS= check ... test-open.h:34:1: error: '__inline' is not at beginning of declaration [-Werr

Re: [PATCH] use libcrypto routines in gnulib

2013-12-09 Thread Pádraig Brady
On 12/09/2013 12:15 AM, Paul Eggert wrote: > Pádraig Brady wrote: >> * m4/gl-openssl.m4 (gl_CRYPTO_CHECK): Don't empty LIB_CRYPTO > > That would inherit LIB_CRYPTO from the environment, no? > It might be better to move the LIB_CRYPTO= into the > initialization code. I pushed the attached to fix t

netbsd compile failure with at-func.c

2013-12-09 Thread Pádraig Brady
It seems readlink is already a defined to __readlink_alias or something, so when AT_FUNC_F1 is 'readlink', the following expansion will fail # define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS)) i.e. CALL_FUNC (file) should be expanded to: readlink (file , buf, len) but is just expanded