Re: test-dup3.c:108: assertion failed

2012-10-09 Thread Richard W.M. Jones
On Tue, Oct 09, 2012 at 08:18:21AM -0600, Eric Blake wrote: > On 10/09/2012 03:05 AM, Richard W.M. Jones wrote: > > On Tue, Oct 09, 2012 at 09:54:45AM +0100, Richard W.M. Jones wrote: > >> The F_DUPFD_CLOEXEC fix that Al Viro posted fixes 3/4 of the > >> bugs, but I'm still investigating this one:

Re: test-dup3.c:108: assertion failed

2012-10-09 Thread Eric Blake
On 10/09/2012 03:05 AM, Richard W.M. Jones wrote: > On Tue, Oct 09, 2012 at 09:54:45AM +0100, Richard W.M. Jones wrote: >> The F_DUPFD_CLOEXEC fix that Al Viro posted fixes 3/4 of the >> bugs, but I'm still investigating this one: >> >>> test-dup3.c:108: assertion failed >>> # ASSERT (dup3 (fd

Re: test-dup3.c:108: assertion failed (was: Re: test-cloexec.c:97: assertion failed)

2012-10-09 Thread Richard W.M. Jones
I'm testing the following patch. Rich. From 0944e30e12dec6544b3602626b60ff412375c78f Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Tue, 9 Oct 2012 14:42:45 +0100 Subject: [PATCH] dup3: Return an error when oldfd == newfd. The following commit: commit fe17f22d7fd0e344ef6447238f79

Re: test-dup3.c:108: assertion failed (was: Re: test-cloexec.c:97: assertion failed)

2012-10-09 Thread Richard W.M. Jones
On Tue, Oct 09, 2012 at 09:54:45AM +0100, Richard W.M. Jones wrote: > The F_DUPFD_CLOEXEC fix that Al Viro posted fixes 3/4 of the > bugs, but I'm still investigating this one: > > > test-dup3.c:108: assertion failed > > # ASSERT (dup3 (fd, fd, o_flags) == -1); Thanks to Jim for pointing out

test-dup3.c:108: assertion failed (was: Re: test-cloexec.c:97: assertion failed)

2012-10-09 Thread Richard W.M. Jones
The F_DUPFD_CLOEXEC fix that Al Viro posted fixes 3/4 of the bugs, but I'm still investigating this one: > test-dup3.c:108: assertion failed > # ASSERT (dup3 (fd, fd, o_flags) == -1); Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: F

Re: [regression] F_DUPFD_CLOEXEC breakage fix

2012-10-09 Thread Richard W.M. Jones
On Mon, Oct 08, 2012 at 11:21:58PM +0100, Al Viro wrote: > On Mon, Oct 08, 2012 at 10:53:25PM +0100, Richard W.M. Jones wrote: > > On Mon, Oct 08, 2012 at 10:50:30PM +0100, Richard W.M. Jones wrote: > > [.. discussion on gnulib test-cloexec test snipped ..] > > > I'm suspicious this is a kernel bug