[PATCH] net_if: give more details about the bug being fixed

Jasper Lievisse Adriaanse reported that NetBSD 5.2 also has the same bug. Also, when writing configure tests that use (such as for 'struct ifreq'), it is useful to know what pre-requisite headers are needed within that test. * doc/posix-headers/net_if.texi: Add clarification. Signed-off-by: Eri

[PATCH] manywarnings: cater to more gcc infelicities

Some versions of gcc (at least 4.2.1) noisily warn if -Wuninitialized is given without -O; in isolation, configure learns that the warning option is supported, but when later compiling with -Werror, this makes builds fail. If the option will have no effect for the configured choice of $CFLAGS, the

Re: broken OpenBSD [was: [libvirt] [PATCH] Include some extra headers needed for OpenBSD.]

On Tue, Sep 04, 2012 at 11:37:30AM -0600, Eric Blake wrote: > On 09/04/2012 11:23 AM, Jasper Lievisse Adriaanse wrote: > > On Tue, Sep 04, 2012 at 11:08:30AM -0600, Eric Blake wrote: > >> [adding gnulib] > >> > >> Ouch. The POSIX definition of doesn't include any interface > >> that needs to use

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

On 09/06/2012 11:03 AM, Max Horn wrote: > I proposed the exact same patch you proposed back in January. Ah, sorry, I was confused. Again. Ouch. Please let me try to summarize the situation to make sure that I understand it. We're talking about two different patches, either of which you say wi

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

Hi again! On 06.09.2012, at 11:08, Paul Eggert wrote: > Alas, I don't use OS X, or Mac OS X, or whatever it's called > these days, so I can't easily test any fix, and I'd like some > discussion if possible. Sure. > > In January Bruno wrote that my proposed patch >

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

Paul Eggert wrote: > Alas, I don't use OS X, or Mac OS X, or whatever it's called > these days, so I can't easily test any fix, and I'd like some > discussion if possible. > > In January Bruno wrote that my proposed patch > > woul

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

Alas, I don't use OS X, or Mac OS X, or whatever it's called these days, so I can't easily test any fix, and I'd like some discussion if possible. In January Bruno wrote that my proposed patch would break gettext-based i18n of GN

Re: poll() emulation in git

Il 06/09/2012 16:44, Joachim Schmitz ha scritto: >> > Yes, it's an usleep(autocorrect * 10) basically (poll takes >> > milliseconds, not micro). > OK, it is _supposed_ to do this usleep(), but is does not, as poll() returns > early with EFAULT in this case: > /* EFAULT is not necessary to im

Re: another manywarnings failure

Jim Meyering wrote: ... > Yes, it looks like if we're using both of those, we'll have to > add code to reject -Wuninitialized (maybe with a warning?) when > configuring without -O. ... > [here's simple PoC, i.e., it doesn't know about -O0, > but you get the idea ] > > W = -Wuninitialized -Werror >

RE: poll() emulation in git

> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Thursday, September 06, 2012 4:32 PM > To: Joachim Schmitz > Cc: g...@vger.kernel.org; 'Junio C Hamano'; 'Erik Faye-Lund'; > bug-gnulib@gnu.org; rsbec...@nexbridge.com > Subject: Re: poll() emulation in gi

Re: poll() emulation in git

Il 06/09/2012 16:02, Joachim Schmitz ha scritto: > > But is there something that could be done to make git work even without > poll()? > It is used in 5 places: > > $ grep -n poll\( *.c */*.c > credential-cache--daemon.c:175: if (poll(&pfd, 1, 1000 * wakeup) < 0) { > daemon.c:1018: if (

RE: poll() emulation in git

> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 05, 2012 5:26 PM > To: Joachim Schmitz > Cc: 'Junio C Hamano'; g...@vger.kernel.org; 'Erik Faye-Lund'; > bug-gnulib@gnu.org > Subject: Re: poll() emulation in git > > Il 05/09/2012 15

Re: another manywarnings failure

Eric Blake wrote: > On 09/06/2012 06:48 AM, Jim Meyering wrote: >> >> Actually, with GNU make, this is something that we could probably >> adjust at make-time. > > Only if you use Automake-NG, and can assume GNU make. IMHO, this work-around doesn't have to do anything for those using non-GNU make,

Re: another manywarnings failure

On 09/06/2012 06:48 AM, Jim Meyering wrote: > > Actually, with GNU make, this is something that we could probably > adjust at make-time. Only if you use Automake-NG, and can assume GNU make. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: another manywarnings failure

Eric Blake wrote: > On 09/06/2012 12:07 AM, Jim Meyering wrote: >> Eric Blake wrote: >> >>> I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest >>> gnulib, I started to see the following in config.log when running >>> ./configure CFLAGS=-g: >>> > >> When you configure with one

Re: [PATCH] net_if: new module

On 09/06/2012 01:06 AM, Jasper Lievisse Adriaanse wrote: > On Wed, Sep 05, 2012 at 03:59:10PM -0600, Eric Blake wrote: >> OpenBSD's is not self-contained; this should compile: >> >> | #define _POSIX_C_SOURCE 200809L >> | #include >> | struct if_nameindex i; >> >> but fails >> * doc/posix-headers

Re: another manywarnings failure

On 09/06/2012 12:07 AM, Jim Meyering wrote: > Eric Blake wrote: > >> I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest >> gnulib, I started to see the following in config.log when running >> ./configure CFLAGS=-g: >> > When you configure with one set of warning options and l

Re: [PATCH] net_if: new module

On Wed, Sep 05, 2012 at 03:59:10PM -0600, Eric Blake wrote: > OpenBSD's is not self-contained; this should compile: > > | #define _POSIX_C_SOURCE 200809L > | #include > | struct if_nameindex i; > > but fails with: > > In file included from foo.c:2: > /usr/include/net/if.h:112: error: expected