> From: Joachim Schmitz [mailto:j...@schmitz-digital.de]
> Sent: Wednesday, June 27, 2012 9:25 AM
> To: 'Paul Eggert'
> Cc: '10...@debbugs.gnu.org'; 'bug-gnulib@gnu.org'; 'Eric Blake'; 'Jim
> Meyering'
> Subject: RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF
>
> > From: Paul Eggert [mail
Le 19 juil. 2012 à 16:11, Jim Meyering a écrit :
> TL;DR: ACK (with comments documenting find_tool duplication) ;-)
OK, thanks for the review! Installed both, with this one
patched as follows.
diff --git a/ChangeLog b/ChangeLog
index 40ada21..1494ef2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@
On 07/18/2012 07:07 PM, Hu Tao wrote:
> <...>
>
>> +
>> +# define virAtomicIntGet(atomic) \
>> +(__extension__ ({ \
>> +verify (sizeof(*(atomic)) == sizeof(int)); \
>> +
Akim Demaille wrote:
> * build-aux/gnu-web-doc-update (find_tool): Import from bootstrap.
> ($CVS, $CVSU, $GIT, $RSYNC, $XARGS): New.
> ---
> ChangeLog| 6
> build-aux/gnu-web-doc-update | 68
> +++-
> 2 files changed, 61 insertion
Akim Demaille wrote:
> * build-aux/gnu-web-doc-update: Don't pass $ME to die.
> ---
> ChangeLog| 3 +++
> build-aux/gnu-web-doc-update | 6 +++---
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 0913c0d..40ada21 100644
> --- a/C
On Thu, Jul 19, 2012 at 01:04:16PM +0200, Jim Meyering wrote:
> A quick workaround is to use gnulib's --avoid option
> to tell it you don't want the getlogin_r tests:
>
> --avoid=getlogin_r-tests
Thanks. I pushed this workaround upstream:
https://github.com/libguestfs/libguestfs/commit/6e1b
Richard W.M. Jones wrote:
> When building in Koji (the Fedora build system), the test is usually
> skipped:
>
> Skipping test: stdin is not a tty.
> SKIP: test-getlogin_r
>
> except when it doesn't skip and instead it fails:
>
> test-getlogin_r.c:62: assertion failed
> /bin/sh: line 5: 110
Bruno Haible writes:
> Eric Blake wrote:
>> Should we get rid of the
>> sanity checks that use #error when a macro is undefined, in order
>> to reduce the number of exemptions?
>
> I agree, this would be useful for those source files that are always
> taken as an entire module from gnulib. I woul
Hi all,
I didn't have the cvsutils installed, but gnu-web-doc-update ran
happily without telling me anything about it. I used find_tool as is
already defined in bootstrap. Maybe we should have a means to share
shell snippets in these tools. Elsewhere I used autom4te and M4sh to
share my shell r
* build-aux/gnu-web-doc-update (find_tool): Import from bootstrap.
($CVS, $CVSU, $GIT, $RSYNC, $XARGS): New.
---
ChangeLog| 6
build-aux/gnu-web-doc-update | 68 +++-
2 files changed, 61 insertions(+), 13 deletions(-)
diff --git a/
* build-aux/gnu-web-doc-update: Don't pass $ME to die.
---
ChangeLog| 3 +++
build-aux/gnu-web-doc-update | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0913c0d..40ada21 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8
Here is the complete log from a failed build:
http://koji.fedoraproject.org/koji/getfile?taskID=4253206&name=build.log
The only other thing of note is that this is glibc 2.16-2, and it
should of course already have getlogin_r so we shouldn't be using the
gnulib replacement function.
Rich.
--
R
When building in Koji (the Fedora build system), the test is usually
skipped:
Skipping test: stdin is not a tty.
SKIP: test-getlogin_r
except when it doesn't skip and instead it fails:
test-getlogin_r.c:62: assertion failed
/bin/sh: line 5: 11074 Aborted EXEEXT='' srcdir
13 matches
Mail list logo
