On 06/26/2012 09:38 AM, Joachim Schmitz wrote:
> Let me know what you think and where/how you'd do it differently.
The changes mostly look good. The trivial ones we've incorporated
already. I have some comments on the nontrivial ones (please see below).
But before we get into it too much furthe
[adding cygwin]
On 06/26/2012 06:12 PM, Paul Eggert wrote:
> On 06/26/2012 05:01 PM, Eric Blake wrote:
>> Rather than forcing comparison to a single value, would it be better to
>> have a function is_privileged_uid(euid)?
>
> Yes, that sounds better. I don't use Cygwin, though, so
> I'm not qual
On 06/26/2012 05:01 PM, Eric Blake wrote:
> Rather than forcing comparison to a single value, would it be better to
> have a function is_privileged_uid(euid)?
Yes, that sounds better. I don't use Cygwin, though, so
I'm not qualified to write that.
On 06/26/2012 05:49 PM, Paul Eggert wrote:
>/* The super-user can read and write any file, and execute any file
> that anyone can execute. */
> - if (euid == 0 && ((mode & X_OK) == 0
> -|| (stats.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH
> + if (euid == ROOT_UID
>
---
ChangeLog | 20
lib/euidaccess.c |7 +--
lib/pt_chown.c|6 --
lib/root-uid.h| 30 ++
lib/unlinkdir.c |3 ++-
lib/write-any-file.c |3 ++-
m4/mknod.m4
Hi Eric.
On 06/26/2012 06:29 PM, Eric Blake wrote:
> On 06/26/2012 10:15 AM, Stefano Lattarini wrote:
>
>> What about this: since the great majority of the packages out there do
>> not seem to override nor patch the Automake-provided auxiliary scripts,
>> we could just make automake always reinsta
On 06/26/2012 09:12 PM, Eric Blake wrote:
>
> [SNIP]
>
> And not mentioned in my proposed commit message, but I specifically kept
> mdate-sh as one of the mirrored files, even though Stefano originally
> suggested that it might be automake-centric; that particular script is
> small enough to be use
Hi Paul,
> Shouldn't regex be avoiding strcasecmp entirely?
> That is, couldn't there be a weird locale that considers
> the lower-case equivalent of "U" to be "uu", or something
> weird like that?
In such a locale, strcasecmp would not consider "U" and "uu" as
being equivalent; only mbscasecmp w
[adding autoconf]
On 06/26/2012 12:26 PM, Bruno Haible wrote:
> Eric Blake wrote:
>> * build-aux/elisp-comp: Delete.
>
> What about modules/elisp-comp?
That module has only had one edit: it's introduction in 2006:
https://lists.gnu.org/archive/html/bug-gnulib/2006-08/msg00248.html
with a claim
On 06/26/2012 10:15 AM, Stefano Lattarini wrote:
> What about this: since the great majority of the packages out there do
> not seem to override nor patch the Automake-provided auxiliary scripts,
> we could just make automake always reinstall such scripts by default;
> and allow the users to mark
Eric Blake wrote:
> * build-aux/elisp-comp: Delete.
What about modules/elisp-comp?
> * build-aux/ylwrap: Likewise.
OK. Many packages (gettext-runtime/intl, parse-datetime, ...) rely directly
on bison. Only packages which support old yacc need this wrapper script, and
they typically use Automake.
On 06/26/2012 12:04 PM, Bruno Haible wrote:
> Eric Blake wrote:
>>> Any idea for a simple solution to this problem?
>>
>> Aren't there timestamps in the auxiliary scripts for a reason? If a
>> script is updated as part of a new automake release, can't automake
>> insert some sanity checks to see i
Eric Blake wrote:
> > Any idea for a simple solution to this problem?
>
> Aren't there timestamps in the auxiliary scripts for a reason? If a
> script is updated as part of a new automake release, can't automake
> insert some sanity checks to see if the currently-installed scripts have
> too old
Shouldn't regex be avoiding strcasecmp entirely?
That is, couldn't there be a weird locale that considers
the lower-case equivalent of "U" to be "uu", or something
weird like that?
For this particular case c-strcase seems overkill, so how
about the following further patch?
diff --git a/lib/regcom
Paul Eggert wrote:
> > getopt-posix: No longer guarantee that option processing is resettable.
>
> That looks good to me, and thanks.
Thanks for the review. Eric was silent. So I'm applying this change, together
with a note in the NEWS file.
Bruno
DateModules Changes
2012
These three scripts are too closely tied to automake internals to
be independently useful. In fact, automake would rather that
people did not mix the latest version of these scripts with older
versions of automake, as there is no effort being put into
maintaining backwards-compatibility when these
Joachim Schmitz wrote:
> Also 2 small fixes for C99
Thanks for these. Indeed, the 'argp' and 'regex' modules use strcasecmp()
and should therefore depend 'strcase' (already done) and include
(done through patch below).
2012-06-26 Bruno Haible
argp, regex: Ensure strcasecmp gets decl
> From: Paul Eggert [mailto:egg...@cs.ucla.edu]
> Sent: Sunday, January 15, 2012 7:01 AM
> To: Joachim Schmitz
> Cc: 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric Blake'; 'Jim Meyering'
> Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF
>
> On 01/14/2012 08:27 AM, Joachim Schmit
On 06/26/2012 05:23 AM, Stefano Lattarini wrote:
>> Execute this with Automake 1.10.3:
>> $ aclocal
>> $ automake -Wall -a -c
>> configure.ac:2: installing `./install-sh'
>> configure.ac:2: installing `./missing'
>>
>> Then execute this with Automake 1.12:
>> $ aclocal
>> $ automake -Wall
>>
>> No
On 06/26/2012 05:37 PM, Eric Blake wrote:
> [adding bug-m4]
>
> On 06/26/2012 05:23 AM, Stefano Lattarini wrote:
>
I'm almost inclined not to do so, to force the affected
projects' broken setup to be fixed; i.e., if you are using Automake 1.11,
you let it install the correct 'missi
[adding bug-m4]
On 06/26/2012 05:23 AM, Stefano Lattarini wrote:
>>> I'm almost inclined not to do so, to force the affected
>>> projects' broken setup to be fixed; i.e., if you are using Automake 1.11,
>>> you let it install the correct 'missing' program, instead of forcing it
>>> to use the 'mi
Severity: minor
thanks
[Adding bug-automake]
On 06/26/2012 12:32 PM, Bruno Haible wrote:
> Stefano Lattarini wrote:
>> I'm almost inclined not to do so, to force the affected
>> projects' broken setup to be fixed; i.e., if you are using Automake 1.11,
>> you let it install the correct 'missing' p
Stefano Lattarini wrote:
> I'm almost inclined not to do so, to force the affected
> projects' broken setup to be fixed; i.e., if you are using Automake 1.11,
> you let it install the correct 'missing' program, instead of forcing it
> to use the 'missing' from Automake 1.13.
But developers don't h
Hi Eric.
On 06/26/2012 05:46 AM, Eric Blake wrote:
> On 06/20/2012 03:30 PM, Stefano Lattarini wrote:
>> Before this change, the missing script had a twofold role:
>>
>> - it warned the user if some required maintainer tools was missing,
>> or too old;
>>
>> - in such a case, it tried to "
24 matches
Mail list logo
