Re: GCC 4.4 at least for mips has no -Wsuggest-attribute=pure

2012-04-04 Thread Jim Meyering
Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which makes compilation fail in regex.c on > # if (__GNUC__ == 4 && 3 <= __GNUC_MINOR__) || 4 < __GNUC__ > # pragma GCC diagnostic ignored "-Wsuggest-attribute=pure" > # pragma GCC diagnostic ignored "-Wtype-limits" > # endif Thanks for the repo

GCC 4.4 at least for mips has no -Wsuggest-attribute=pure

2012-04-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Which makes compilation fail in regex.c on # if (__GNUC__ == 4 && 3 <= __GNUC_MINOR__) || 4 < __GNUC__ # pragma GCC diagnostic ignored "-Wsuggest-attribute=pure" # pragma GCC diagnostic ignored "-Wtype-limits" # endif -- Regards Vladimir 'φ-coder/phcoder' Serbinenko signature.asc Descri

Re: [PATCH] Use opaque struct rather than char * in regex.h

2012-04-04 Thread Paul Eggert
On 04/03/2012 09:34 PM, Jim Meyering wrote: > The alternative (your patch or similar) would move the definition > of re_dfa_t from its private header to a public one. We needn't expose the typedef, just the struct tag for an incomplete type; this doesn't reveal anything other than the struct tag,