Re: fflush.c unused parameter

2012-03-30 Thread Eric Blake
On 03/30/2012 05:09 PM, Simon Josefsson wrote: > fflush.c:91: error: expected ';', ',' or ')' before '_GL_UNUSED_PARAMETER' > > I suspect something like this is needed? Aargh, sorry for messing that up, and yes, you patch is right. Can you go ahead and push it? > > /Simon > > diff --git a/lib

fflush.c unused parameter

2012-03-30 Thread Simon Josefsson
fflush.c:91: error: expected ';', ',' or ')' before '_GL_UNUSED_PARAMETER' I suspect something like this is needed? /Simon diff --git a/lib/fflush.c b/lib/fflush.c index a43eea7..fa6f389 100644 --- a/lib/fflush.c +++ b/lib/fflush.c @@ -28,6 +28,8 @@ #include "stdio-impl.h" +#include "unused

Re: [PATCH] Add const qualifier for charset_name in init_dfa

2012-03-30 Thread Paul Eggert
On 03/30/2012 03:15 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Any problem with this patch? No other comment, and I didn't see any problem. Thanks for the bug report. I pushed this: >From ed033e34810947e4f23763171f790fae66a5f063 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 30

Re: [PATCH] Add const qualifier for charset_name in init_dfa

2012-03-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.03.2012 03:24, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > In GRUB charset is hardwired to UTF-8 and we return just a pointer to > "UTF-8" in nl_langinfo (CODESET); > I propose adding const qualifier since this function already handles > codeset_name as a pointer to const string. Any probl

Re: build failure on cross build

2012-03-30 Thread Simon Josefsson
Paul Eggert writes: > On 03/29/2012 02:44 AM, Bruno Haible wrote: >> I think gnulib should >> 1) not assume that the function is declared, >> 2) have a deprecated module 'gets' that declares this function only if >> the declaration is missing. > > How about if gnulib drops support for ge

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Akim Demaille
Le 30 mars 2012 à 11:18, Bruno Haible a écrit : > Hi Akim, > >>> This patch appears broken to me: >>> - On one hand it augments CPPFLAGS without ever setting it back. >>> - On the other hand it saves and restores CFLAGS or CXXFLAGS but >>> without temporarily modifying its value. >>> >>> Can

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Bruno Haible
Hi Akim, > > This patch appears broken to me: > > - On one hand it augments CPPFLAGS without ever setting it back. > > - On the other hand it saves and restores CFLAGS or CXXFLAGS but > >without temporarily modifying its value. > > > > Can you please provide a fix? Gnulib macros should in g

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Akim Demaille
Hi Bruno! Le 30 mars 2012 à 03:26, Bruno Haible a écrit : > Akim Demaille wrote: >> Currently the macro does >> not depend on the language to store its result > > This patch appears broken to me: > - On one hand it augments CPPFLAGS without ever setting it back. > - On the other hand it saves