Re: Is gnulib supposed to support Visual Studio builds?

2012-01-03 Thread Bruno Haible
Hi, Daniel Schepler wrote: > I'm trying to use gnulib sources in order to be able to use glob > internally in the Windows build of our product (i.e. I call > std::string pattern = productHome + "/libraries/*/config/*.xml"; > glob(pattern.c_str(), ...); > ) Yes, you should be able to do this w

Is gnulib supposed to support Visual Studio builds?

2012-01-03 Thread Daniel Schepler
I'm trying to use gnulib sources in order to be able to use glob internally in the Windows build of our product (i.e. I call std::string pattern = productHome + "/libraries/*/config/*.xml"; glob(pattern.c_str(), ...); ) This is using the Debian package of gnulib, which is version 20111211+stabl

Re: rationales in commit messages

2012-01-03 Thread Stefano Lattarini
On 01/03/2012 11:09 PM, Bruno Haible wrote: > Stefano Lattarini wrote: >> report in the commit message of your patch the useful and extensive >> arguments, explanations and references you have laid out so excellently in >> your mail. > > Is it better to copy the arguments into a (long) commit mess

Re: rationales in commit messages

2012-01-03 Thread Bruno Haible
Stefano Lattarini wrote: > report in the commit message of your patch the useful and extensive > arguments, explanations and references you have laid out so excellently in > your mail. Is it better to copy the arguments into a (long) commit message, or add a reference to the mail(s) in the lists.g

Re: [PATCH] Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Stefano Lattarini
On 01/03/2012 12:59 AM, Bruno Haible wrote: > > [A GOOD PROPOSAL] > Thanks for this carefully thought-out proposal. My only 2 cents of advice is to report in the commit message of your patch the useful and extensive arguments, explanations and references you have laid out so excellently in your ma

Re: [PATCH] Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 12:59 AM, Bruno Haible wrote: Hi Paul, Attached is a proposed Gnulib patch to fix some occurrences of the "win" terminology problem. It mostly just substitutes "Woe32" for "Win32", except that for "Win32 API" it substitutes "Windows API". It's good to clean up some of these ter

Re: Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Paolo Bonzini
On 01/02/2012 11:57 PM, Paul Eggert wrote: Anyway, impressing people is not the main goal here. The main goal is to come up with a useful name that doesn't praise the Windows API or operating environment. "win32" is not the right choice for that, we must use something better, and there is a propo

Re: [PATCH] Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 12:59 AM, Bruno Haible wrote: 1) It contrasts with the NtDll API.[2] For example, file names passed to NtDll functions can use a different syntax than file names passed to Win32 functions.[3] This distinction matters because programs build with gnulib should als

Re: Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Andy Moreton
On Mon 02 Jan 2012, Bruno Haible wrote: > It's good to clean up some of these terms once in a decade, yes. > > I'm largely responsible of this issue: I started using "Woe32" > instead of "Win32", out of frustration when porting GNU clisp to > this platform, and mimicking the word "MS-DOG" found in

Re: new module 'isatty'

2012-01-03 Thread Bruno Haible
Eli Zaretskii wrote: > > Because that would yield warnings when you compile on mingw with "-Wall". > > I compiled with -Wall (using intptr_t) and didn't have any warnings. > Maybe you are using a newer (= more pedantic) version of GCC. Maybe I misremembered, and it was MSVC which gave the warning

Re: new module 'isatty'

2012-01-03 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-gnulib@gnu.org, roucaries.bast...@gmail.com, ebl...@redhat.com, > bonz...@gnu.org, bug-g...@gnu.org > Date: Tue, 03 Jan 2012 14:03:11 +0100 > > Eli Zaretskii wrote: > > > HANDLE h = (HANDLE) _get_osfhandle (fd); > > > > Why not use intptr_t instead of HANDLE

Re: new module 'isatty'

2012-01-03 Thread Bruno Haible
Eli Zaretskii wrote: > > HANDLE h = (HANDLE) _get_osfhandle (fd); > > Why not use intptr_t instead of HANDLE Because the common way to write code for the Windows API is to use the Windows types, not the ISO C 89 types. > and get rid of the cast, both > here and in IsConsoleHandle above? B

[PATCH] maint.mk: remove temporary transition aid from over 1.5 years ago

2012-01-03 Thread Jim Meyering
Looking through the matches for "FIXME.*2012", this takes care of one of them: >From 943bf5a92b5a7a3e4b3a7178654c5491244ee8aa Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 3 Jan 2012 11:35:43 +0100 Subject: [PATCH] maint.mk: remove temporary transition aid from over 1.5 years ago * top

Re: new module 'isatty'

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 09:36 AM, Eli Zaretskii wrote: From: Bruno Haible Cc: bastien ROUCARIES, Eli Zaretskii, Eric Blake, bonz...@gnu.org, bug-g...@gnu.org Date: Tue, 03 Jan 2012 03:56:56 +0100 I'm adding this new module. Feel free to use it in 'grep'. Thanks #define IsConsoleHandle(h) (((long) (h)

Re: new module 'isatty' (was: Re: MS-Windows build of Grep [2/4])

2012-01-03 Thread Bastien ROUCARIES
On Tue, Jan 3, 2012 at 9:36 AM, Eli Zaretskii wrote: >> From: Bruno Haible >> Cc: bastien ROUCARIES , Eli Zaretskii >> , Eric Blake , bonz...@gnu.org, >> bug-g...@gnu.org >> Date: Tue, 03 Jan 2012 03:56:56 +0100 >> >> I'm adding this new module. Feel free to use it in 'grep'. > > Thanks > >> #d

Re: new module 'isatty' (was: Re: MS-Windows build of Grep [2/4])

2012-01-03 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bastien ROUCARIES , Eli Zaretskii > , Eric Blake , bonz...@gnu.org, > bug-g...@gnu.org > Date: Tue, 03 Jan 2012 03:56:56 +0100 > > I'm adding this new module. Feel free to use it in 'grep'. Thanks > #define IsConsoleHandle(h) (((long) (h) & 3) == 3) Where does this