Re: [PATCH] canonicalize: only stat() when required

2011-12-31 Thread Pádraig Brady
That seemed uncontroversial so I pushed it. cheers, Pádraig.

Re: same-inode.h and OpenVMS

2011-12-31 Thread Paul Eggert
OK, thanks, I installed the gnulib patch. I also installed the following gnulib documentation change to try to get all this stuff written down better. doc: cover st_ino issues once; add OpenVMS etc. * doc/posix-functions/stat.texi (stat): * doc/posix-functions/lstat.texi (lstat): * doc/posix-func

Re: how to do findutils cross-compilation for ARM platform?

2011-12-31 Thread Mike Frysinger
On Wednesday 28 December 2011 09:09:08 Eric Blake wrote: > On 12/25/2011 09:43 PM, chunrong lai wrote: > > I tried to build a ARM version of findutils in my ubuntu 10.10 (x86_64) > > with below commands > > ./configure CC=arm-linux-gnueabi-gcc CFLAGS="-g" \ > --build arm-cross-linux-gnueabi --hos

Re: [PATCH] canonicalize: add support for not resolving symlinks

2011-12-31 Thread Eric Blake
On 12/30/2011 12:19 PM, Paul Eggert wrote: > On 12/30/11 08:36, Eric Blake wrote: > >> unless you can declare struct rpl_stat with the same layout >> as struct stat, you have an API incompatibility that can cause >> compilation errors in various circumstances. > > Ah, sorry, I was assuming that w

[PATCH] canonicalize: only stat() when required

2011-12-31 Thread Pádraig Brady
* lib/canonicalize.c (canonicalize_filename_mode): Avoid calling l?stat() when both CAN_MISSING, and CAN_NOLINKS are set, as then we neither need to resolve symlinks or test component existence. --- ChangeLog |8 lib/canonicalize.c |9 - 2 files changed, 16 insert

Re: same-inode.h and OpenVMS

2011-12-31 Thread Jim Meyering
Paul Eggert wrote: > On OpenVMS st_ino is an array of three ino_t values, so grep's > a.st_ino == b.st_ino compares *pointers*, and yields 0. Ouch. > > For other GNU programs we often don't worry about OpenVMS, > but grep is a special case, as it's actually used on OpenVMS >