Re: [PATCH] init.sh: new module, and add minimal tests of its compare function

2011-12-22 Thread Bruno Haible
Hi Jim, > * modules/init.sh: New file. The module name 'init.sh' is not self-explanatory. How about one of these: test-framework test-frame test-framework-sh The latter name is because it is not impossible that someday we get also a test framework as a C program, like glibc has one. > as a

Patches to README-release

2011-12-22 Thread Reuben Thomas
A series of patches that attempt to improve a few minor formatting problems and also streamline some of the steps. >From a7fef6319b09420f26fc6d2a508322b7c21b7997 Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Mon, 19 Dec 2011 09:40:14 +0100 Subject: [PATCH 1/4] Improvements to README-release

[PATCH] init.sh: new module, and add minimal tests of its compare function

2011-12-22 Thread Jim Meyering
Here's a proposed minimal start at tests for tests/init.sh. To add a test module, I also had to add a primary module, so we now finally have an "init.sh" module, and as a next step, I'll convert all of the Files: tests/init.sh references to module dependencies. >From 7d3d2d00059b7b616596f015b37e33

Re: Patch to .gitignore

2011-12-22 Thread Eric Blake
On 12/22/2011 08:19 AM, Reuben Thomas wrote: > I attach an updated patch with the offending bit snipped. Pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Patch to .gitignore

2011-12-22 Thread Reuben Thomas
I attach an updated patch with the offending bit snipped. -- http://rrt.sc3d.org From c030756d03e7dadadc90b1cfa12561585f2c856a Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Mon, 19 Dec 2011 09:38:14 +0100 Subject: [PATCH 1/6] .gitignore: ignore gnulib.dvi and regex.info * doc/.gitignore:ad

[PATCH] init.sh: do not emit simulated diff output to stderr

2011-12-22 Thread Jim Meyering
I've begun writing tests of init.sh's compare and found this right away. I'll wait at least a few minutes before pushing this fix. >From f70e860ca35f95bf888a2bc23e9a52ee524f8099 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 22 Dec 2011 16:04:36 +0100 Subject: [PATCH] init.sh: do not emit

Re: Patch to .gitignore

2011-12-22 Thread Reuben Thomas
On 22 December 2011 14:54, Eric Blake wrote: > > Looks like you have some unrelated stuff in this commit. Only in the ChangeLog. Do I need to resend or can you just snip out the bogus entry? -- http://rrt.sc3d.org

Re: Patch to .gitignore

2011-12-22 Thread Eric Blake
On 12/22/2011 07:47 AM, Reuben Thomas wrote: > Ignore a couple of generated files. > >>From c030756d03e7dadadc90b1cfa12561585f2c856a Mon Sep 17 00:00:00 2001 > From: Reuben Thomas > Date: Mon, 19 Dec 2011 09:38:14 +0100 > Subject: [PATCH 1/6] .gitignore: ignore gnulib.dvi and regex.info > > * do

Patch to .gitignore

2011-12-22 Thread Reuben Thomas
Ignore a couple of generated files. >From c030756d03e7dadadc90b1cfa12561585f2c856a Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Mon, 19 Dec 2011 09:38:14 +0100 Subject: [PATCH 1/6] .gitignore: ignore gnulib.dvi and regex.info * doc/.gitignore:add gnulib.dvi and regex.info --- ChangeLog

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Jim Meyering
Pádraig Brady wrote: > On 12/22/2011 11:44 AM, Jim Meyering wrote: >> FYI, after updating to the latest tests/init.sh, I noticed new >> failures in vc-dwim's "make check". Tracked it down to this: >> > >> diff --git a/tests/init.sh b/tests/init.sh >> index 19c0cf4..458a448 100644 >> --- a/tests/i

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Jim Meyering
Stefano Lattarini wrote: > Hi Jim. > > On 12/22/2011 12:44 PM, Jim Meyering wrote: >> FYI, after updating to the latest tests/init.sh, I noticed new >> failures in vc-dwim's "make check". Tracked it down to this: >> >> From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001 >> From

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Pádraig Brady
On 12/22/2011 11:44 AM, Jim Meyering wrote: > FYI, after updating to the latest tests/init.sh, I noticed new > failures in vc-dwim's "make check". Tracked it down to this: > > diff --git a/tests/init.sh b/tests/init.sh > index 19c0cf4..458a448 100644 > --- a/tests/init.sh > +++ b/tests/init.sh >

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Stefano Lattarini
Hi Jim. On 12/22/2011 12:44 PM, Jim Meyering wrote: > FYI, after updating to the latest tests/init.sh, I noticed new > failures in vc-dwim's "make check". Tracked it down to this: > > From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 22 Dec

[PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Jim Meyering
FYI, after updating to the latest tests/init.sh, I noticed new failures in vc-dwim's "make check". Tracked it down to this: >From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 22 Dec 2011 12:42:32 +0100 Subject: [PATCH] init.sh: avoid unwarranted

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2011-12-22 Thread Paul Eggert
On 12/21/11 23:54, Joachim Schmitz wrote: > The code path you modified is not touched at all. Oh well, it was a bit of a stab in the dark anyway. I guess we'll have to do Eric's suggestion to wrap opendir . That should work around the problem,

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2011-12-22 Thread Joachim Schmitz
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Wednesday, December 21, 2011 6:32 PM > To: Joachim Schmitz > Cc: 'Jim Meyering'; 10...@debbugs.gnu.org; 'Paul Eggert'; bug- > gnu...@gnu.org > Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF > > On 12/21/2011 10:12 AM, Joachim