I like Bruno's patch better than what I proposed.
One nit: the pathmax.h comment suggests a fallback of 8192,
but the code uses 1024; I suggest making them consistent.
If the common idiom is a local variable of size PATH_MAX,
perhaps the default should be 4000 or so?
Hi Simon,
> I'm trying to get gnulib to work on the Hurd, and ran into this in
> test-getcwd.c:
>
> test-getcwd.c: In function 'test_long_name':
> test-getcwd.c:119:11: error: missing binary operator before token "("
>
> The code is:
>
> 29#include "pathmax.h"
> ...
>108
Paul Eggert writes:
> On 08/03/11 13:07, Simon Josefsson wrote:
>> It seems weird for test-getcwd.c to include pathmax.h and then do a
>> #ifndef PATH_MAX test?
>
> It is weird, and wrong. And looking at the code, there are other
> glitches with respect to PATH_MAX. Does the following quick pat
On 06/30/2011 06:57 AM, Eric Blake wrote:
On 06/29/2011 11:22 PM, Bastien ROUCARIES wrote:
Could we raise the same issue with socketpair to austin group ?
Good point, I'll go ahead and test that scenario as well.
Done: http://austingroupbugs.net/view.php?id=483
But that doesn't help gnulib
On 08/03/11 13:07, Simon Josefsson wrote:
> It seems weird for test-getcwd.c to include pathmax.h and then do a
> #ifndef PATH_MAX test?
It is weird, and wrong. And looking at the code, there are other
glitches with respect to PATH_MAX. Does the following quick patch
work for you on the Hurd? T
I'm trying to get gnulib to work on the Hurd, and ran into this in
test-getcwd.c:
test-getcwd.c: In function 'test_long_name':
test-getcwd.c:119:11: error: missing binary operator before token "("
The code is:
29 #include "pathmax.h"
...
108 static int
109 test_long_name (void)
1
