On 05/09/2011 05:15 PM, Bruno Haible wrote:
> Eric Blake wrote:
>> - int proc_self_fd = open ("/proc/self/fd", O_SEARCH);
>> + int proc_self_fd = open ("/proc/self/fd",
>> + O_SEARCH | O_DIRECTORY | O_NOCTTY |
>> O_NONBLOCK);
>
> What is the point of playin
Eric Blake wrote:
> - int proc_self_fd = open ("/proc/self/fd", O_SEARCH);
> + int proc_self_fd = open ("/proc/self/fd",
> + O_SEARCH | O_DIRECTORY | O_NOCTTY |
> O_NONBLOCK);
What is the point of playing with O_NOCTTY and O_NONBLOCK here?
It could trigger
On 05/09/2011 04:37 PM, Eric Blake wrote:
> open/access/close is cheaper than open/stat/stat/close.
>
> * lib/openat-proc.c (openat_proc_name): Simplify.
> * modules/openat (Depends-on): Drop same-inode.
> Reported by Bastien ROUCARIES.
>
> Signed-off-by: Eric Blake
> ---
>
> I'm pushing this.
open/access/close is cheaper than open/stat/stat/close.
* lib/openat-proc.c (openat_proc_name): Simplify.
* modules/openat (Depends-on): Drop same-inode.
Reported by Bastien ROUCARIES.
Signed-off-by: Eric Blake
---
I'm pushing this.
ChangeLog |7 +++
lib/openat-proc.c | 13 +
On 05/09/2011 02:34 PM, Eric Blake wrote:
> On 05/09/2011 01:10 PM, Eric Blake wrote:
>> On 05/09/2011 12:06 PM, Bastien ROUCARIES wrote:
>>> Sorry for top post (android)
>>>
>>> Proposed algo:
>>> Ofd=open(/proc,o_search)
>>> follow link /proc/self/fd/ofd/../proc
>>> If bug will resolve to
>>> /pr
On 05/09/2011 01:10 PM, Eric Blake wrote:
> On 05/09/2011 12:06 PM, Bastien ROUCARIES wrote:
>> Sorry for top post (android)
>>
>> Proposed algo:
>> Ofd=open(/proc,o_search)
>> follow link /proc/self/fd/ofd/../proc
>> If bug will resolve to
>> /proc/self/fd/proc that does not exist
>> If not bug su
[ apologies if you receive this multiple times ]
Hello,
* Bruce Korb wrote on Wed, May 04, 2011 at 08:04:05PM CEST:
> So, if I've not mis-stated nor missed anything, we only wait for Derek,
> Paolo and Ralf.
OK by me.
Sorry for the delay,
Ralf
[ apologies if you receive this multiple times ]
* Reuben Thomas wrote on Wed, May 04, 2011 at 11:14:57AM CEST:
> $ ls
> */{acosl,asinl,atanl,cosl,expl,logl,sinl,sqrtl,tanl,isfinite,tmpfile,fflush,futimens,nanosleep,getgroups,tzset,strtoimax,strtoumax}.*
> |xargs git log --pretty=format:%aN |sort
On 05/09/2011 12:06 PM, Bastien ROUCARIES wrote:
> Sorry for top post (android)
>
> Proposed algo:
> Ofd=open(/proc,o_search)
> follow link /proc/self/fd/ofd/../proc
> If bug will resolve to
> /proc/self/fd/proc that does not exist
> If not bug suceed (because we have already opened /proc
I still
Sorry for top post (android)
Proposed algo:
Ofd=open(/proc,o_search)
follow link /proc/self/fd/ofd/../proc
If bug will resolve to
/proc/self/fd/proc that does not exist
If not bug suceed (because we have already opened /proc
Bastien
Le 9 mai 2011 19:37, "Eric Blake" a écrit :
On 05/09/2011 05:
On 05/09/2011 05:49 AM, Bastien ROUCARIES wrote:
> Hi,
>
> I am trying to modularize openat-proc, in order to create an openat using
> passfd. I have created a test file for openat-proc, and I
> think we could a little bit simplify the test of solaris bug, and drop a
> dependency on same inode.
Feedback welcome.
In using this in iwhd, I decided to extend
the variable-matching code, and the easiest way
was to allow for /default_regexp/ || /custom_regexp/.
Since each has a single (...) match, it "just works".
I'm sure I could use some fancy new regexp capability
that's only available in pe
On 05/08/11 15:24, Reuben Thomas wrote:
Still missing a header:
...
In file included from lposix.c:25:0:
/usr/local/include/libposix/glob.h:381:23: fatal error: glob-libc.h:
No such file or directory
The derived file "glob.h" unconditionally sources "glob-libc.h".
Therefore, whenever "glob.h"
Eric Blake writes:
> On 05/09/2011 06:54 AM, Bruno Haible wrote:
>> Hi Simon,
>>
>>> I noticed the 'strcase' module is marked as obsolete. ... What
>>> should be used instead?
>>
>> You are confusing "obsolete" with "deprecated". As explained in [1][2], the
>> meaning of "obsolete" in gnulib i
On 05/09/2011 06:54 AM, Bruno Haible wrote:
> Hi Simon,
>
>> I noticed the 'strcase' module is marked as obsolete. ... What
>> should be used instead?
>
> You are confusing "obsolete" with "deprecated". As explained in [1][2], the
> meaning of "obsolete" in gnulib is that you don't need it, *not
Hi Simon,
> I noticed the 'strcase' module is marked as obsolete. ... What
> should be used instead?
You are confusing "obsolete" with "deprecated". As explained in [1][2], the
meaning of "obsolete" in gnulib is that you don't need it, *not* that it will
go away.
[1] http://www.gnu.org/software
Hi,
I am trying to modularize openat-proc, in order to create an openat using
passfd. I have created a test file for openat-proc, and I
think we could a little bit simplify the test of solaris bug, and drop a
dependency on same inode.
Instead of comparing /proc/self inode why not trying to ope
I noticed the 'strcase' module is marked as obsolete. I don't see
anything in NEWS about that, doc/posix-functions/strcasecmp still refers
to 'strcase', and the 'strcase' module is used by some other modules
(argp, strptime). Is the module really meant to be obsolete? What
should be used instead
I've been using a precursor of this rule in coreutils for many years,
added it to idutils a year or two ago and added it to grep just recently.
I did not like having to duplicate and customize bits
in the separate copies, depending on where I used it,
so finally have made it general enough so that
I've noticed a few times when re-running bootstrap
within my coreutils directory, that the build will fail because
it seems that the timestamps of the symlinks in m4/ are used,
rather than those of the target m4 files.
For example recently, @HAVE_SIGHANDLER_T@ was left unsubstituted in
lib/signal.
Bruno Haible writes:
> Hi Simon,
>
> The macro gl_PREREQ_GC in m4/gc.m4 is nowhere invoked in gnulib and also not
> needed, because none of the files lib/gc.h, lib/gc-libgcrypt.c,
> lib/gc-gnulib.c
> uses the 'restrict' keyword.
>
> I guess this macro could just be removed?
Hi Bruno. Yes. It
21 matches
Mail list logo
