Re: verify fails on ia64-hpux11.23 in libunistring-0.9.3

2011-04-30 Thread Paul Eggert
On 04/30/11 22:10, Gary V. Vaughan wrote: > test-stdint.o test-stdint.c >> "test-stdint.c", line 189: error #2105: invalid size for bit field >> verify (TYPE_MAXIMUM (uint_fast8_t) == UINT_FAST8_MAX); >> ^ >> This would appear to be a bug in stdint, not in verify. What is the value o

Re: Compilation failure for libunistring-0.9.3 on ia64 hpux 11.23 and 11.31

2011-04-30 Thread Gary V. Vaughan
Ping number 4. Should I stop pinging every week and assume upstream does not want ia64 hpux compatibility? Guile-2.0.0 depends on libunistring, so an important part of GNU does not work on ia64 unless each user who needs it is prepared to diagnose and fix the release locally. HP is moving from hpp

Re: verify fails on ia64-hpux11.23 in libunistring-0.9.3

2011-04-30 Thread Gary V. Vaughan
Ping? On Sat, Apr 23, 2011 at 11:52:30AM +, Gary V. Vaughan wrote: > I'm trying to build a 64bit libunistd on ia64-hpux11.23, but it fails > while building it's gnulib tests with: > > source='test-stdint.c' object='test-stdint.o' libtool=no \ > DEPDIR=.deps depmode=hp2 /opt/fsw/bash32/bin

Re: bad typo in netdb.in.h

2011-04-30 Thread Bruno Haible
Paul Eggert wrote: > > -# define AI_ADDRCONFIG 0 /* 0x0020: Use configuration of this host to > > choose > > +# define AI_ADDRCONFIG 0 /* 0x0020: Use configuration of this host to > > choose \ > >returned address type. */ > > A backslash-newline in a

[PATCH] fclose: don't fail on non-seekable input stream

2011-04-30 Thread Eric Blake
On mingw, for a project that uses both sockets and streams, then fclose(stdin) when getting input from a terminal or pipe was spuriously failing. * modules/fclose (Depends-on): Add freading, fflush, fseeko. * lib/fclose.c (rpl_fclose): Skip fflush for non-seekable input, since fflush is allowed to

Cleanup 64-bit warning in argp-help.c for Mac OS X 10.6

2011-04-30 Thread Jonathan Creekmore
Another package I was trying to build threw a warning on lib/argp-help.c on my 64-bit box. In this case, the assert statement only needs to be compiled if SIZE_MAX <= UINT_MAX, otherwise a warning is generated in the assert statement. I have attached a patch. I hope this helps. From 27b442d78074e

Re: VC-tag again

2011-04-30 Thread Reuben Thomas
On 30 April 2011 21:33, Jim Meyering wrote: > Reuben Thomas wrote: >> On 30 April 2011 11:54, Bruno Haible wrote: >>> The secondary mechanism is that a package can have a README-release.diff >>> file and use the --local-dir option. >> >> That seems like a nice way of editing in per-project sectio

Re: VC-tag again

2011-04-30 Thread Jim Meyering
Reuben Thomas wrote: > On 30 April 2011 11:54, Bruno Haible wrote: >> The secondary mechanism is that a package can have a README-release.diff >> file and use the --local-dir option. > > That seems like a nice way of editing in per-project sections, but > seems a bit over the top for just getting

Re: bad typo in netdb.in.h

2011-04-30 Thread Paul Eggert
On 04/30/11 03:55, Bruno Haible wrote: > -# define AI_ADDRCONFIG 0 /* 0x0020: Use configuration of this host to > choose > +# define AI_ADDRCONFIG 0 /* 0x0020: Use configuration of this host to > choose \ >returned address type. */ A backslash-newline

Re: VC-tag again

2011-04-30 Thread Reuben Thomas
On 30 April 2011 11:54, Bruno Haible wrote: > The secondary mechanism is that a package can have a README-release.diff > file and use the --local-dir option. That seems like a nice way of editing in per-project sections, but seems a bit over the top for just getting the name of the project in. J

Re: VC-tag again

2011-04-30 Thread Reuben Thomas
On 30 April 2011 10:34, Jim Meyering wrote: > > Ideally, there would be a way to hook into gnulib-tool itself do > this, so the module file would be self-contained, rather than > having to recommend adding an additional manual bit off in another > file like bootstrap.conf You took the words off o

Re: Emacs local variables

2011-04-30 Thread Jim Meyering
Reuben Thomas wrote: > On 30 April 2011 07:03, Jim Meyering wrote: >> >> Actually, there is not requirement for space-based indentation in >> ChangeLog.  I prefer consistent TAB-based indentation and have >> periodically performed the s/^ {8}/\t/ global substitution on ChangeLog. >> I've just done

Re: Emacs local variables

2011-04-30 Thread Reuben Thomas
On 30 April 2011 07:03, Jim Meyering wrote: > > Actually, there is not requirement for space-based indentation in > ChangeLog.  I prefer consistent TAB-based indentation and have > periodically performed the s/^ {8}/\t/ global substitution on ChangeLog. > I've just done that again. Thanks. It wou

Re: manywarnings.m4 indentation

2011-04-30 Thread Pádraig Brady
On 30/04/11 12:13, Bruno Haible wrote: > Pádraig Brady wrote: >> I've amended that, and the indenting issue Bruno noticed, and pushed. > > That file also has other indentation issues: the basic indentation > sometimes is 1, sometimes 2, even in the same statement. I'm fixing it: I notice the seri

URL module

2011-04-30 Thread Jose E. Marchesi
Hi Giuseppe. What do you think about making an 'url' gnulib module containing the (adapted) code from src/url.[ch] in wget? Such a module would ease the management of urls in both libraries and programs. It is not funny to link with libcurl just because you need to escape a url string, for exam

Re: git-version-gen and EXTRA_DIST

2011-04-30 Thread Bruno Haible
Hi Simon, > I got a report [1] that it wasn't possible to run 'autoreconf' in a > distribution tarball because build-aux/git-version-gen was not > distributed. Can you show such a tarball? In coreutils-8.12.tar.gz, build-aux/git-version-gen is distributed. > > +You must add EXTRA_DIST += build-a

Re: git-version-gen and EXTRA_DIST

2011-04-30 Thread Eric Blake
On 04/30/2011 09:53 AM, Simon Josefsson wrote: > I got a report [1] that it wasn't possible to run 'autoreconf' in a > distribution tarball because build-aux/git-version-gen was not > distributed. Is this intended to work automatically somehow? > Otherwise, how about this patch? > > /Simon > > [

git-version-gen and EXTRA_DIST

2011-04-30 Thread Simon Josefsson
I got a report [1] that it wasn't possible to run 'autoreconf' in a distribution tarball because build-aux/git-version-gen was not distributed. Is this intended to work automatically somehow? Otherwise, how about this patch? /Simon [1] http://lists.nongnu.org/archive/html/oath-toolkit-help/2011-

netdb.h in C++ mode

2011-04-30 Thread Bruno Haible
Now that we have a function substitute in , let me add a test of it in C++ mode. #if GNULIB_TEST_GETADDRINFO SIGNATURE_CHECK (GNULIB_NAMESPACE::getaddrinfo, int, (const char *, const char *, const struct addrinfo *, struct addrinfo **)); SIGNATURE_CHECK (GNULIB_N

Re: reading from non-blocking pipes on Windows

2011-04-30 Thread Bruno Haible
I wrote on 2011-04-14: > * lib/stdio.in.h (_GL_ATTRIBUTE_FORMAT_SCANF, > _GL_ATTRIBUTE_FORMAT_SCANF_SYSTEM): New macros. > (fgetc, fgets, fread, fscanf, getc, getchar, gets, scanf, vfscanf, > vscanf): New declarations. Oops, this leads to compilation errors in C++ m

Re: [PATCH 3/3] passfd: speed up configure and drop unused code

2011-04-30 Thread Bruno Haible
Eric Blake wrote: >struct msghdr msg; > -# if HAVE_UNIXSOCKET_SCM_RIGHTS_BSD44_WAY > +# ifdef CMSG_FIRSTHDR >struct cmsghdr *cmsg; So that we don't forget which code applies to which platforms, let me add some comments: 2011-04-30 Bruno Haible passfd: Add comments. *

Re: [PATCH 1/3] sys_uio: new module

2011-04-30 Thread Bruno Haible
On OpenBSD 4.4, is not self-contained: $ cat foo.c #include struct iovec x; $ gcc -c foo.c In file included from foo.c:1: /usr/include/sys/uio.h:40: error: syntax error before "size_t" In file included from foo.c:1: /usr/include/sys/uio.h:75: error: syntax error before "preadv" /usr/include/sys

Re: [PATCH 2/3] passfd: allow compilation on mingw

2011-04-30 Thread Bruno Haible
Eric Blake wrote: > --- a/tests/test-sys_socket.c > +++ b/tests/test-sys_socket.c > @@ -30,6 +30,12 @@ int a[] = { SHUT_RD, SHUT_WR, SHUT_RDWR }; >  /* Check that the 'socklen_t' type is defined.  */ >  socklen_t t1; > > +/* Check that 'struct iovec' is defined.  */ > +struct iovec io; > This ne

Re: [PATCH 1/3] sys_uio: new module

2011-04-30 Thread Bruno Haible
Eric Blake wrote: > +/* All known platforms that lack also lack any declaration > + of struct iovec in any other header. */ > +struct iovec { > + void *iov_base; > + size_t iov_len; > +}; When we define a 'struct' type in a gnulib header, we need to take care of two things: - In the situa

Re: manywarnings.m4 indentation

2011-04-30 Thread Bruno Haible
Pádraig Brady wrote: > I've amended that, and the indenting issue Bruno noticed, and pushed. That file also has other indentation issues: the basic indentation sometimes is 1, sometimes 2, even in the same statement. I'm fixing it: 2011-04-30 Bruno Haible manywarnings: fix indentatio

bad typo in netdb.in.h

2011-04-30 Thread Bruno Haible
The commit on 2010-02-17 introduced a half comment in a macro and another half comment outside of declarations. This fixes it: 2011-04-30 Bruno Haible netdb: Fix invalid C syntax. * lib/netdb.in.h (AI_ADDRCONFIG): Fix comment syntax. --- lib/netdb.in.h.orig Sat Apr 30 11:38:0

Re: VC-tag again

2011-04-30 Thread Bruno Haible
Jim Meyering wrote: > > perl -pi -e "s/\@PACKAGE\@/$package/g" README-release > > Ideally, there would be a way to hook into gnulib-tool itself do > this, so the module file would be self-contained, rather than > having to recommend adding an additional manual bit off in another > file like boot

Re: [PATCH] fatal-signal: silence coverity warning

2011-04-30 Thread Pádraig Brady
On 30/04/11 00:26, Eric Blake wrote: > Looks nice from my reading of it. Although for the cache variable > names, should we go with gl_cv_cc_nomfi_supported rather than > gl_cv_nomfi_supported (that is, add cc_ to each of the cache variable > names), to make it clear that the cache variables are a

Re: VC-tag again

2011-04-30 Thread Jim Meyering
Jim Meyering wrote: ... > Instead, simply recommend to add something like this in autogen.sh > or in bootstrap.conf's bootstrap_epilogue function: > > perl -pi -e "s/\@PACKAGE\@/$package/g" README-release To clarify: that should work as-is in bootstrap_epilogue, but probably not in autogen.sh.

Re: VC-tag again

2011-04-30 Thread Jim Meyering
Reuben Thomas wrote: > On 29 April 2011 20:51, Reuben Thomas wrote: >> On 29 April 2011 20:49, Jim Meyering wrote: >>> >>> Hmm... in grep's README-release, I count five URLs containing >>> the package name: >>> >>>    http://hydra.nixos.org/jobset/gnu/grep-master >>>    https://savannah.gnu.org/p

Re: [PATCH] fatal-signal: silence coverity warning

2011-04-30 Thread Bruno Haible
Pádraig Brady wrote: > Proposed patch attached. Lines 65..76 ought to be indented by two more spaces. Bruno -- In memoriam Casey Jones