Re: bug in ftoastr example

2010-12-19 Thread Paul Eggert
On 12/19/2010 06:34 PM, Ben Pfaff wrote: > So "%.*g" in the example is wrong: it needs to get replaced by a > "flags" argument. Thanks for catching that; the comment was referring to an earlier (draft) version. I pushed this: diff --git a/ChangeLog b/ChangeLog index 308b450..9796a9b 100644 ---

Re: Possible Bug in Gnulib

2010-12-19 Thread Noah Lavine
Hello, I tested this with Guile, and it removes the build error. Thank you very much for being so helpful! Noah On Sun, Dec 19, 2010 at 6:23 PM, Bruno Haible wrote: > Hello Noah, > >> I configured Guile with >> >> ./configure --prefix=/Users/noah/Desktop/guile >> --with-libiconv-prefix=/opt/loc

bug in ftoastr example

2010-12-19 Thread Ben Pfaff
The example in lib/ftoastr.h is: int r = dtoastr (buf, sizeof buf, "%*.*g", 0, 0.1); but the prototype for dtoastr() is: int dtoastr (char *buf, size_t bufsize, int flags, int width, double x); So "%.*g" in the example is wrong: it needs to get replaced by a "flags" argument. Thanks

isnan: ensure it's a macro

2010-12-19 Thread Bruno Haible
The isnan test suite verifies that isnan() is a macro, not only a function. This test fails on OSF/1 5.1 with gcc: depbase=`echo test-isnan.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; gcc -std=gnu99 -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib -Wall

iswblank on OSF/1

2010-12-19 Thread Bruno Haible
Still on OSF/1 5.1, I see this error: depbase=`echo test-wctype-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; g++ -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib -Wall -mieee -MT test-wctype-c++.o -MD -MP -MF $depbase.Tpo -c -o test-wctype-c++.o te

SIGRTMIN on OSF/1 5.1

2010-12-19 Thread Bruno Haible
On OSF/1 5.1, I'm seeing this warning: strsignal.c: In function 'strsignal': strsignal.c:111: warning: format '%d' expects type 'int', but argument 4 has type 'long int' The reason is that while POSIX says that SIGRTMIN and SIGRTMAX expand to an expression of type 'int', on this platform it'

socket functions on OSF/1

2010-12-19 Thread Bruno Haible
On OSF/1, the functions recv(), recvfrom(), send(), sendto() are declared with an old-style declaration (return value 'int' instead of 'ssize_t', and no use of 'socklen_t') by default. The fix is easy, this time: just setting _POSIX_PII_SOCKET does it. 2010-12-19 Bruno Haible sys_sock

tcgetsid on OSF/1

2010-12-19 Thread Bruno Haible
On OSF/1 5.1, the function tcgetsid() exists but is not declared by default. (It would be with _XOPEN_SOURCE=500, but this is not a choice we can make.) This leads to an error: In file included from test-termios-c++.cc:22: ../gllib/termios.h:355: error: '::tcgetsid' has not been declared ../gllib

popen on OSF/1 5.1

2010-12-19 Thread Bruno Haible
On OSF/1 5.1 I got these test build failures: depbase=`echo test-stdio-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; g++ -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib -mieee -MT test-stdio-c++.o -MD -MP -MF $depbase.Tpo -c -o test-stdio-c++.o tes

Re: Possible Bug in Gnulib

2010-12-19 Thread Bruno Haible
Hello Noah, > I configured Guile with > > ./configure --prefix=/Users/noah/Desktop/guile > --with-libiconv-prefix=/opt/local > --with-libunistring-prefix=/opt/local --with-libgmp-prefix=/opt/local > --with-libintl-prefix=/opt/local --with-libreadline-prefix=/opt/local > --enable-guile-debug. Thi

Re: new stdbool test provokes warning

2010-12-19 Thread Bruno Haible
Hi Jim, > The new stdbool test causes this warning/failure in coreutils: > > cc1: warnings being treated as errors > test-stdbool.c: In function 'main': > test-stdbool.c:98:9: error: unused variable 'e1' [-Wunused-variable] > make[8]: *** [test-stdbool.o] Error 1 I nearly expecte

Re: [PATCH] setenv: restore to working order

2010-12-19 Thread Bruno Haible
Jim Meyering wrote: > $HAVE_SETENV is used in gl_FUNC_SETENV, yet its definitions were > mistakenly removed. Oops, I missed this use of HAVE_SETENV. Sorry for the trouble, and thanks for the quick fix! Bruno

new stdbool test provokes warning

2010-12-19 Thread Jim Meyering
Hi Bruno, The new stdbool test causes this warning/failure in coreutils: cc1: warnings being treated as errors test-stdbool.c: In function 'main': test-stdbool.c:98:9: error: unused variable 'e1' [-Wunused-variable] make[8]: *** [test-stdbool.o] Error 1 Here's the code: mai

[PATCH] setenv: restore to working order

2010-12-19 Thread Jim Meyering
In preparation for coreutils-8.8, I tried to update gnulib to the latest to get Paul's recent Solaris 8 vs. ACL fix. However, the OSF-vs-unsetenv portability fixes caused trouble: building coreutils configured with --enable-gcc-warnings, I saw this new failure: cc1: warnings being treated as e

signature warnings on OSF/1 5.1

2010-12-19 Thread Bruno Haible
On OSF/1 5.1 I'm also seeing these gcc warnings: * test-getaddrinfo.c:26: warning: initialization from incompatible pointer type This one is because the gai_strerror declaration is different from POSIX: - POSIX: const char *gai_strerror(int); - OSF/1: char *gai_strerror(int); I think there's

Re: Possible Bug in Gnulib

2010-12-19 Thread Noah Lavine
Hello, > Thanks for your report. For a good report, you should also have stated >  - how you configured guile, >  - the precise error message that you got. Sorry about that. I configured Guile with ./configure --prefix=/Users/noah/Desktop/guile --with-libiconv-prefix=/opt/local --with-libunistri

Re: Can't build libposix

2010-12-19 Thread Bastien ROUCARIES
Any news ? On Thu, Dec 16, 2010 at 6:11 PM, Bastien ROUCARIES wrote: > Le jeudi 16 décembre 2010 16:50:50, Bastien ROUCARIES a écrit : >> Le dimanche 12 décembre 2010 06:38:24, Peter O'Gorman a écrit : >> > On 12/11/2010 11:09 PM, Bastien ROUCARIES wrote: >> > > On Sun, Dec 12, 2010 at 10:04 AM,

doc about vasprintf-posix module

2010-12-19 Thread Bruno Haible
The doc does not mention the advantages of the 'vasprintf-posix' module, compared to the 'vasprintf' module. This fixes it. 2010-12-19 Bruno Haible doc: Mention vasprintf-posix module. * doc/glibc-functions/asprintf.texi: Mention the workarounds present in the 'vasprin

unsetenv on OSF/1

2010-12-19 Thread Bruno Haible
On OSF/1, unsetenv() is also not declared by default. As a consequence, there is an error in the C++ tests: ../gllib/stdlib.h:1022: error: 'unsetenv' was not declared in this scope ../gllib/stdlib.h:1022: error: invalid type in declaration before ';' token and also the configure test "checking fo

setenv on OSF/1

2010-12-19 Thread Bruno Haible
On new verisons of OSF/1 5.1, setenv() is not declared by default. It's only declared if _BSD is defined, but defining it has also some negative consequences. Consequence: This error: ../gllib/stdlib.h:907: error: 'setenv' was not declared in this scope ../gllib/stdlib.h:907: error: invalid type i

Re: [PATCH] relocatable-prog-wrapper: fix test suite

2010-12-19 Thread Ben Pfaff
Bruno Haible writes: > The problem is that RELOCATABLE_VIA_WRAPPER is defined in module > 'relocatable-prog' but is used in 'relocatable-prog-wrapper'. Recall the > distinction of these two modules: > - 'relocatable-prog-wrapper' is just the source code for the wrapper > program. > - 'reloca

mknod on OSF/1

2010-12-19 Thread Bruno Haible
On OSF/1 with g++, I'm seeing this error in the test suite: depbase=`echo test-glob-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; g++ -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib -mieee -MT test-glob-c++.o -MD -MP -MF $depbase.Tpo -c -o test-glo

Re: [PATCH] stdbool: avoid rejecting clang

2010-12-19 Thread Bruno Haible
Paul Eggert wrote on 2010-08-24, in : > the C standard > says that "&s" is a valid static initializer, but I suppose > one could argue that there's an implicit conversion to bool that would > clearly be invalid if one made it expli

fseeko, ftello on OSF/1

2010-12-19 Thread Bruno Haible
Hi, On OSF/1 5.1, the declarations of fseeko() and ftello() are missing by default. Setting _XOPEN_SOURCE=500 would provide these declarations but is not the right fix (see previous mail about fchdir()). I'll add this fix for fseeko and similarly for ftello: 2010-12-19 Bruno Haible f

fchdir on OSF/1

2010-12-19 Thread Bruno Haible
Hi, On newer versions of OSF/1 5.1, fchdir is not declared in by default, leading to this error: source='test-fchdir.c' object='test-fchdir.o' libtool=no DEPDIR=.deps depmode=tru64 /bin/ksh ./../build-aux/depcomp cc -O -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I

Re: [PATCH] relocatable-prog-wrapper: fix test suite

2010-12-19 Thread Bruno Haible
Hi, Ian Beckwith wrote: > relocatable-prog-wrapper fails the test suite. Indeed, $ ./gnulib-tool --create-testdir ... relocatable-prog-wrapper fails like this: gllib/Makefile.am:148: RELOCATABLE_VIA_WRAPPER does not appear in AM_CONDITIONAL The problem is that RELOCATABLE_VIA_WRAPPER is def

Re: [PATCH] unistr/u8-mbsnlen-tests: fix deps

2010-12-19 Thread Bruno Haible
Hi, Ian Beckwith wrote: > u8-mbsnlen's tests fail due to a missing dep. Thanks for the report. This regression was introduced on 2010-11-13. > Trivial patch attached. The error message that I get is gcc -g -O2 -o test-u8-mbsnlen unistr/test-u8-mbsnlen.o ../gllib/libgnu.a ../gllib/libgnu.a

Re: [PATCH] iconv: fix deps

2010-12-19 Thread Bruno Haible
Hi Ian, Ian Beckwith wrote: > iconv fails the test suite due to a missing dep. Thanks. This regression was introduced on 2010-11-26. > Trivial patch attached. Actually, the intent was that the 'iconv' module does not require the 'iconv-h' module. The AM_ICONV macro is documented (in the gettext