Re: [PATCH] test-select-stdin.c: avoid warn_unused_result warnings

Hi Jim, > I think it is uncontroversial. > > Pushed. I hope that's ok. The time window you gave me to react on this one was less than 24 hours; I couldn't answer in time. On this one, I would have preferred to silence the warnings in a cheaper way. It's irrelevant for the train of events insid

Re: -Werror in tests

Hi Jim, > With that, I can enable -Werror in coreutils' gnulib-tests directory. Only on glibc systems, I hope? On other platforms, there will be lots of other warnings that I don't want to deal with individually. Globally, I don't think it is such a good move. We need more unit tests, and with a

Re: [PATCH 0/7] contents of topic/libposix for merge to master

Hi Gary, > >> Distcheck results by architecture and compiler: > >> > >>dec Tru64 5.1 Compaq C 6.5 (mbrlen.c compile failed: > >> rpl_mbstate_t has no linkage and a > >> prior > >> declaration in scope at 415:./wc

Re: [PATCH] bootstrap: add bootstrap_sync option.

Hi Paul, On Sun, 17 Oct 2010, Paul Eggert wrote: > On 10/17/2010 09:27 AM, Joel E. Denny wrote: > > Now that Bison's bootstrap is in sync with gnulib's, I'd like to make sure > > we keep it that way. This patch will help. Ok to push? > > I dunno, this sounds like it would discourage outsider

Re: [PATCH] test-nl_langinfo: avoid "unsigned expression >= 0 is always true" warning

Bruno Haible wrote: > Hi Jim, > >> test-nl_langinfo.c:56: warning: comparison of unsigned expression >= 0 \ >> is always true [-Wtype-limits] > >> Is this change ok with you? >> Alternatively, I'd be slightly happier simply >> to remove the warning-evoking tests. > > Commenting out or removin

Re: userspec: simplify module description

Bruno Haible wrote: > Hi Jim, > > There is no need to list lib/inttostr.h as one of the files of module > 'userspec', since this module already depends on module 'inttostr'. > > It's a leftover from 2009-11-28 > . > > OK to commit

Re: [PATCH] test-nl_langinfo: avoid "unsigned expression >= 0 is always true" warning

Hi Jim, > test-nl_langinfo.c:56: warning: comparison of unsigned expression >= 0 \ > is always true [-Wtype-limits] > Is this change ok with you? > Alternatively, I'd be slightly happier simply > to remove the warning-evoking tests. Commenting out or removing these tests is not OK. These l

userspec: simplify module description

Hi Jim, There is no need to list lib/inttostr.h as one of the files of module 'userspec', since this module already depends on module 'inttostr'. It's a leftover from 2009-11-28 . OK to commit this? 2010-10-17 Bruno Haible

Re: [PATCH] inttostr.h: add compile-time buffer overrun checks

Jim Meyering wrote: > Nice and thorough work. Thanks for covering almost all of the > remaining cases. OK, here's a proposed patch, for inttostr. If that works fine, I'll continue with the *sprintf variants in libunistring. 2010-10-17 Jim Meyering Bruno Haible Add boun

Re: [PATCH] bootstrap: add bootstrap_sync option.

On 10/17/2010 09:27 AM, Joel E. Denny wrote: > Hi, > > Now that Bison's bootstrap is in sync with gnulib's, I'd like to make sure > we keep it that way. This patch will help. Ok to push? I dunno, this sounds like it would discourage outsiders from contributing to development. Surely there's a

[PATCH] bootstrap: add bootstrap_sync option.

Hi, Now that Bison's bootstrap is in sync with gnulib's, I'd like to make sure we keep it that way. This patch will help. Ok to push? >From 8b8690c8758371880c85e2186b5491de1bc307b2 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Sun, 17 Oct 2010 11:54:21 -0400 Subject: [PATCH] bootstrap: a

Re: alloc_size attribute

Bruno Haible wrote: > Jim Meyering wrote: >> But did you intend to remove 2009 from those >> two copyright year lists? > > Yes, since the two files were not really changed in 2009. A years-old habit > of mine... No big deal, but the maintainers guide encourages us to update the year lists regardle

Re: alloc_size attribute

Jim Meyering wrote: > But did you intend to remove 2009 from those > two copyright year lists? Yes, since the two files were not really changed in 2009. A years-old habit of mine... > They look fine. Tested with gcc 4.3 and 4.2. I pushed it. Bruno

Re: alloc_size attribute

Bruno Haible wrote: > Jim Meyering wrote: >> - >> While looking through gcc's documentation (latest upstream), >> I noticed this, which can be put to good use in xalloc.h: >> >> @item alloc_size >> @cindex @code{alloc_size} attribute >> The @c

Re: [PATCH] inttostr.h: add compile-time buffer overrun checks

Bruno Haible wrote: > Hi Jim, > >> @smallexample >> #undef memcpy >> #define bos0(dest) __builtin_object_size (dest, 0) >> #define memcpy(dest, src, n) \ >> __builtin___memcpy_chk (dest, src, n, bos0 (dest)) >> ... >> Such built-in functions are provided for @code{memcpy}, @code{mempcpy}, >> @cod

Re: alloc_size attribute

Jim Meyering wrote: > - > While looking through gcc's documentation (latest upstream), > I noticed this, which can be put to good use in xalloc.h: > > @item alloc_size > @cindex @code{alloc_size} attribute > The @code{alloc_size} attribute is

Re: [PATCH] bootstrap: anchor .gitignore entries.

Joel E. Denny wrote: > On Sun, 17 Oct 2010, Jim Meyering wrote: > >> Joel E. Denny wrote: > >> > * build-aux/bootstrap (insert_sorted_if_absent): Replace all uses >> > with... >> > (insert_vc_ignore): ... this new function, which prepends `/' to >> > all .gitignore entries before passing them to >

Re: [PATCH] bootstrap: anchor .gitignore entries.

On Sun, 17 Oct 2010, Jim Meyering wrote: > Joel E. Denny wrote: > > * build-aux/bootstrap (insert_sorted_if_absent): Replace all uses > > with... > > (insert_vc_ignore): ... this new function, which prepends `/' to > > all .gitignore entries before passing them to > > insert_sorted_if_absent. >

Re: [PATCH] inttostr.h: add compile-time buffer overrun checks

Hi Jim, > @smallexample > #undef memcpy > #define bos0(dest) __builtin_object_size (dest, 0) > #define memcpy(dest, src, n) \ > __builtin___memcpy_chk (dest, src, n, bos0 (dest)) > ... > Such built-in functions are provided for @code{memcpy}, @code{mempcpy}, > @code{memmove}, @code{memset}, @cod

Re: TinyCC bugs

Hi Ralf, Ralf Wildenhues writes: > * Ludovic Courtès wrote on Sun, Oct 17, 2010 at 12:16:30AM CEST: >> BTW, TinyCC compiles all the configure tests and Gnulib files in Guile. >> It eventually bails out because Libtool insists on invoking it with >> ‘-rpath’, which it doesn’t support: >>

Re: TinyCC bugs

Hi, Bruno Haible writes: >> > I can reproduce it like this: >> > >> > stdlib.h >> > #include >> > foo.c --- >> > #include >> > -- >> > $ /arch/x86-linux/gnu-inst-tcc/0.9.25/bi

Re: [PATCH] bootstrap: anchor .gitignore entries.

Joel E. Denny wrote: > Quite some time ago, we discussed the fact that a .gitignore entry without > a leading `/' applies recursively to subdirectories, and Bruno then fixed > gnulib-tool to prepend a `/' to .gitignore entries that it constructs: > > http://lists.gnu.org/archive/html/bug-gnulib/2

Re: [PATCH] inttostr.h: add compile-time buffer overrun checks

Bruno Haible wrote: > Hi Jim, > >> +# define inttostr(n, s)                                                 \ >> +   ((void) verify_true (sizeof (s) == sizeof (void *)                   \ >> +                        || INT_BUFSIZE_BOUND (int) <= sizeof (s)),      \ >> +    (inttostr) (n, s)) > > N