Re: [Bug-tar] exclude wildcards with backslash

2010-05-06 Thread Sergey Poznyakoff
Eric Blake ha escrit: > This doesn't handle: []\a] as the set that recognizes '\\', 'a', or ']'. > Should it? No, it should not. This function is applied to strings that failed the fnmatch_pattern_has_wildcards test, i.e. which are not (valid) globbing patterns. Your example, however, is a va

Re: [Bug-tar] exclude wildcards with backslash

2010-05-06 Thread Eric Blake
On 05/06/2010 02:24 PM, Sergey Poznyakoff wrote: > Jean-Louis Martineau ha escrit: > >> $ tar xf file.tar --wildcards --exclude 't\*s' >> It worked for all tar version up to 1.22 >> With tar-1.23, it extract everything except the file 't\*s. > > There was a bug in the `exclude' module. I have in

Re: [Bug-tar] exclude wildcards with backslash

2010-05-06 Thread Sergey Poznyakoff
Jean-Louis Martineau ha escrit: > $ tar xf file.tar --wildcards --exclude 't\*s' > It worked for all tar version up to 1.22 > With tar-1.23, it extract everything except the file 't\*s. There was a bug in the `exclude' module. I have installed the attached patch. Regards, Sergey >From abe9c758

[PATCH] verify: automate tests

2010-05-06 Thread Eric Blake
Had we automated this sooner, we would have caught the issue with gcc -Werror -Wredundant-decls sooner. * modules/verify-tests: New module. * tests/test-verify.sh: New file. * tests/test-verify.c: Guard each negative test with a unique id. Also avoid warning about unused left hand of comma express