Re: test results on Cygwin

2010-04-05 Thread Bruno Haible
> Failures on Cygwin 1.7.2 > > > test-mbsnrtowcs.c:181: assertion failed > ./test-mbsnrtowcs2.sh: line 15:  5708 Aborted                 (core dumped) > LC_ALL=$LOCALE_FR_UTF8 ./test-mbsnrtowcs${EXEEXT} 2 > FAIL: test-mbsnrtowcs2.sh > > test-mbsrtowcs.c:181: assertion fa

Re: test results on Cygwin

2010-04-05 Thread Bruno Haible
> Failures on Cygwin 1.7.2 > > > test-btowc.c:48: assertion failed > ./test-btowc1.sh: line 15: 2892 Aborted (core dumped) > LC_ALL=$LOCALE_FR ./test-btowc${EXEEXT} 1 > FAIL: test-btowc1.sh > > test-btowc.c:56: assertion failed > ./test-btowc2.sh: line 1

Re: [Patch] stdio-impl.h has too indiscriminate #ifdef

2010-04-05 Thread Hauke Fath
At 0:15 Uhr +0100 5.4.2010, Bruno Haible wrote: >I'm applying this patch. Thanks a lot! hauke -- "It's never straight up and down" (DEVO)

Re: portability of 'printf' command

2010-04-05 Thread Bob Friesenhahn
On Mon, 5 Apr 2010, Eric Blake wrote: On 01/-10/-28163 12:59 PM, Bruno Haible wrote: Is the 'printf' command portable enough to be used in configure files and autoconf macros? The GNU Coding Standards [1] don't mention it as a portable utility. Indeed, when you use bash version 1 (which does n

Re: test results on Cygwin

2010-04-05 Thread Bruno Haible
> Failures on Cygwin 1.7.2 > > > Starting test_cond .../bin/sh: line 5: 4200 Aborted > FAIL: test-cond.exe > > Starting test_lock .../bin/sh: line 5: 2296 Aborted > FAIL: test-lock.exe > > Starting test_tls .../bin/sh: line 5: 2656 Aborted > FAIL: test-tls.exe These

Re: init.sh features

2010-04-05 Thread Eric Blake
On 04/05/2010 03:08 PM, Bruno Haible wrote: > Jim Meyering wrote: >> This could be an argument for wrapping some of the C-only tests in a >> simple init.sh-using driver (maybe even automatically). Any test that >> creates a temporary file would benefit. > > Yes, I agree: It would make things simp

Re: popen binary mode patch

2010-04-05 Thread Eric Blake
On 04/05/2010 02:56 PM, Bruce Korb wrote: > And also the write flavors of popen: popen(xx,O_BINARY?"wb":"w") > > I have to say, though, the "I know what you want, but I won't > do it because you didn't ask for "r" mode the way I want you to" > error messages are the bain of one's programming exis

Re: init.sh features

2010-04-05 Thread Bruno Haible
Jim Meyering wrote: > This could be an argument for wrapping some of the C-only tests in a > simple init.sh-using driver (maybe even automatically). Any test that > creates a temporary file would benefit. Yes, I agree: It would make things simpler and more robust if all tests that require tempora

Re: popen binary mode patch

2010-04-05 Thread Bruce Korb
On Mon, Apr 5, 2010 at 1:05 PM, Jim Meyering wrote: My philosophy is slightly different.  I prefer to go with whatever it is that makes life easier for programming to multiple platforms. >>> >>> http://sources.redhat.com/bugzilla/show_bug.cgi?id=11312 >> >> Unfortunately, Uli rejected it

Re: Fwd: Os2

2010-04-05 Thread Elbert Pol
On 5-04-10 18:53, Paolo Bonzini wrote: Hi all, Sorry din't forward to all... -- Forwarded message -- From: Elbert Pol Date: Mon, Apr 5, 2010 at 17:59 Subject: Re: Os2 To: Paolo Bonzini On 5-04-10 10:13, Paolo Bonzini wrote: On 04/04/2010 09:49 PM, Elbert Pol wrote:

Re: popen binary mode patch

2010-04-05 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 2/22/2010 4:29 PM: >> According to Bruce Korb on 2/22/2010 3:50 PM: The question, though, is whether cygwin's extension is useful enough to push on all platforms. Gnulib tends to favor glibc extensions rather than cygwin extensions. In

Re: portability of 'printf' command

2010-04-05 Thread Eric Blake
On 01/-10/-28163 12:59 PM, Bruno Haible wrote: > Is the 'printf' command portable enough to be used in configure files > and autoconf macros? > > The GNU Coding Standards [1] don't mention it as a portable utility. Indeed, > when you use bash version 1 (which does not have 'printf' built-in) on a

Re: popen binary mode patch

2010-04-05 Thread Eric Blake
According to Eric Blake on 2/22/2010 4:29 PM: > According to Bruce Korb on 2/22/2010 3:50 PM: >>> The question, though, is whether cygwin's extension is useful enough to >>> push on all platforms. Gnulib tends to favor glibc extensions rather than >>> cygwin extensions. In other words, it is hard

new module 'strncat'

2010-04-05 Thread Bruno Haible
This test failure was seen on Solaris 8/SPARC: > FAIL: test-u8-strncat Since u8_strncat is just a wrapper around strncat, this indicates a bug in the system's strncat function. In fact, strncat(dest,src,n) appears to always access at least n+1 bytes starting at src, when src[0..n-1] don't contain

Re: init.sh features

2010-04-05 Thread Jim Meyering
Bruno Haible wrote: >> I had already converted tests/test-xstrtol.sh. >> This continues the process with the other test-xstrto*.sh scripts > > What are, in summary, the benefits of init.sh? I'm wondering whether > we might be putting in features here that are not available tests > written entirely

Re: init.sh features

2010-04-05 Thread Bruno Haible
Hi Jim, > I had already converted tests/test-xstrtol.sh. > This continues the process with the other test-xstrto*.sh scripts What are, in summary, the benefits of init.sh? I'm wondering whether we might be putting in features here that are not available tests written entirely in C. As far as I c

begin to convert tests/*.sh to use init.sh

2010-04-05 Thread Jim Meyering
I had already converted tests/test-xstrtol.sh. This continues the process with the other test-xstrto*.sh scripts as well as the atexit tests, even though that module is marked as obsolete. >From 5c92acef552620a440dc134faf6d1f7fd14f825f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 5 Apr

Re: #defines in unistd.h

2010-04-05 Thread Bruno Haible
> 2010-03-28 Bruno Haible > > unistd: Avoid #define replacements in C++ mode. > * lib/unistd.in.h (socket, connect, accept, bind, getpeername, > getsockname, getsockopt, listen, recv, send, recvfrom, sendto, > setsockopt, shutdown, select): In C++, attach a warning to th

Re: fseeko on mingw

2010-04-05 Thread Bruno Haible
> ../gllib/stdio.h:632: error: `fseeko' was not declared in this scope > > This should fix it. This did not fix it completely, because m4/fflush.m4 also fiddles with REPLACE_FSEEKO. This fixes it, now. 2010-04-05 Bruno Haible fseeko: Fix C++ test error on mingw. * m4/fseek

Re: test results on Solaris

2010-04-05 Thread Jim Meyering
Bruno Haible wrote: > Hi, > > Here are the test results of a complete gnulib testdir on Solaris 8, > compiled once with gcc, once with cc. > > > Failures > > > test-flock.c:62: assertion failed > FAIL: test-flock > > Unconnected socket test... passed > Connected sockets test... failed (ex

test results on Cygwin

2010-04-05 Thread Bruno Haible
Here are the test results of a complete gnulib testdir on Cygwin. Failures on both Cygwin 1.5.25 and 1.7.2 file_has_acl("tmpdir0") returned yes, expected no FAIL: test-file-has-acl.sh Unconnected socket test... passed Connected sockets test... passed Gene

test results on Solaris

2010-04-05 Thread Bruno Haible
Hi, Here are the test results of a complete gnulib testdir on Solaris 8, compiled once with gcc, once with cc. Failures test-flock.c:62: assertion failed FAIL: test-flock Unconnected socket test... passed Connected sockets test... failed (expecting POLLHUP after shutdown) General sock

Re: measuring elapsed time on mingw

2010-04-05 Thread Eric Blake
On 04/05/2010 08:56 AM, Bruno Haible wrote: > Hi Eric, > >>> - QueryPerformanceCounter [1] has a resolution of 0.5 ms or higher. >> >> ... if you use it, then you run into the issues of file timestamp mismatch >> (cygwin currently has a known issue where, because it uses >> QueryPerformanceCount

Re: global year updates

2010-04-05 Thread Bruno Haible
Eric Blake wrote: > I see no reason to remove years that were added during a global year update. Listing the years individually gave at least a certain idea about whether a file is "active", i.e. heavily used and maintained, or on the bitrot slope. Well, you can also see that by peeking into the g

Re: rmdir: simplify test

2010-04-05 Thread Bruno Haible
Eric Blake wrote: > I'm okay with removing it; if someone complains, we have version control > to allow us to resuscitate it at that time. Done. Bruno

Re: measuring elapsed time on mingw

2010-04-05 Thread Bruno Haible
Hi Eric, > > - QueryPerformanceCounter [1] has a resolution of 0.5 ms or higher. > > ... if you use it, then you run into the issues of file timestamp mismatch > (cygwin currently has a known issue where, because it uses > QueryPerformanceCounter instead of GetSystemTimeAsFileTime for > impleme

Re: Zile build breaks in lib/btow.c on NetBSD 1.5

2010-04-05 Thread Eric Blake
On 04/05/2010 08:43 AM, Bruno Haible wrote: > Eric Blake wrote: >>> - Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. >>> + Copyright (C) 2008, 2010 Free Software Foundation, Inc. >> >> Oops. You meant "2008-2010", not "2008, 2010". > > No, the file's contents was not modified i

Re: Zile build breaks in lib/btow.c on NetBSD 1.5

2010-04-05 Thread Bruno Haible
Eric Blake wrote: > > - Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. > > + Copyright (C) 2008, 2010 Free Software Foundation, Inc. > > Oops. You meant "2008-2010", not "2008, 2010". No, the file's contents was not modified in 2009. Bruno

Re: rmdir: simplify test

2010-04-05 Thread Jim Meyering
Eric Blake wrote: > On 04/04/2010 09:10 AM, Bruno Haible wrote: >> Hi, >> >> The rmdir module does not satisfy the common idiom (distinguish >> missing and broken function). But this part is already marked as >> "simplify this module in 2010 if no one reports a missing rmdir" >> >> Did someone re

Re: rmdir: simplify test

2010-04-05 Thread Eric Blake
On 04/04/2010 09:10 AM, Bruno Haible wrote: > Hi, > > The rmdir module does not satisfy the common idiom (distinguish > missing and broken function). But this part is already marked as > "simplify this module in 2010 if no one reports a missing rmdir" > > Did someone report a missing rmdir? Or

Re: measuring elapsed time on mingw

2010-04-05 Thread Eric Blake
On 04/04/2010 04:41 AM, Bruno Haible wrote: > Hi, > > Just a side note about how to measure elapsed time on mingw. > (I needed this in order to evaluate how to implement nanosleep on mingw.) > > Summary: > - GetSystemTimeAsFileTime, _ftime, gettimeofday (from newer mingw runtimes) > all hav

[PATCH] init.sh: fix typo

2010-04-05 Thread Jim Meyering
Annoying to have missed this... >From 50e8c42eba9bd52548e0de3fec113ab2ea1e0f4b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 5 Apr 2010 16:10:05 +0200 Subject: [PATCH] init.sh: fix typo * tests/init.sh: Restore omitted ":" before stderr_fileno_ initialization. --- ChangeLog |3

fchownat on Solaris

2010-04-05 Thread Bruno Haible
On Solaris 8, I'm seeing this error: In file included from test-unistd-c++.cc:22: ../gllib/unistd.h:750: error: 'fchownat' was not declared in this scope The problem is that REPLACE_FCHOWNAT is set to 1 although HAVE_FCHOWNAT is already set to 0. Here is a proposed fix. Jim, is this OK to co

Re: Zile build breaks in lib/btow.c on NetBSD 1.5

2010-04-05 Thread Eric Blake
On 04/04/2010 05:39 PM, Bruno Haible wrote: > +++ lib/btowc.c Mon Apr 5 01:27:46 2010 > @@ -1,5 +1,5 @@ > /* Convert unibyte character to wide character. > - Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. > + Copyright (C) 2008, 2010 Free Software Foundation, Inc. Oops.

Re: frexpl on Solaris, Cygwin

2010-04-05 Thread Bruno Haible
> ../gllib/math.h:620: error: 'frexpl' was not declared in this scope > > Again, the problem is that REPLACE_FREXPL is set when the function does > not exist. This fixes it. Oops, it did not fix it, because gl_FUNC_FREXPL_NO_LIBM can still set REPLACE_FREXPL=1 when the function exists. I'm appl

Re: Os2

2010-04-05 Thread Eric Blake
[adding bug-gnulib] On 04/03/2010 03:48 PM, Elbert Pol wrote: > Hello all, > > I tried today to port it to OS2 > I used Gcc 4.4.2 and the make fails here: > > In file included from fnmatch.c:175: > fnmatch_loop.c: In function 'internal_fnmatch': > fnmatch_loop.c:53: error: 'FNM_EXTMATCH' undecla

vasprintf: Update documentation

2010-04-05 Thread Bruno Haible
The 'vasprintf' module provides not only the vasprintf, but also the asprintf function. But the doc does not mention it. This fixes it: 2010-04-05 Bruno Haible vasprintf: Update documentation. * doc/glibc-functions/asprintf.texi: Mention the 'vasprintf' module. --- doc/glibc-

memchr: Avoid a possible C++ test error

2010-04-05 Thread Bruno Haible
Also the function memchr could lead to a C++ test error, on those old platforms where it is missing. This should fix it. 2010-04-05 Bruno Haible memchr: Avoid a possible C++ test error. * lib/string.in.h (memchr): Provide declaration if function is missing. * m4/memchr

strtok_r: Improve idiom

2010-04-05 Thread Bruno Haible
This tiny improvement should have no visible effect either. 2010-04-05 Bruno Haible strtok_r: Improve idiom. * m4/strtok_r.m4 (gl_FUNC_STRTOK_R): Invoke gl_PREREQ_STRDUP only when AC_LIBOBJ is used. --- m4/strtok_r.m4.orig Mon Apr 5 12:53:07 2010 +++ m4/strtok_r.m4

strdup: Improve idiom

2010-04-05 Thread Bruno Haible
This improves the idiom used in strdup.m4. It should have no effect on any platform, since all platforms which lack strdup are UNIX platforms, i.e. have a POSIX compliant malloc. 2010-04-05 Bruno Haible strdup: Improve idiom. * m4/strdup.m4 (gl_FUNC_STRDUP): Invoke gl_PREREQ_S

mbsinit, mbrtowc, wcrtomb: Improve idioms

2010-04-05 Thread Bruno Haible
A similar problem with the idiom coulds also lead to a C++ mode link error with the functions mbsinit, mbrtowc, wcrtomb, etc. This improves it: 2010-04-05 Bruno Haible mbsinit, mbrtowc, wcrtomb: Improve idioms. * m4/mbsinit.m4 (gl_FUNC_MBSINIT): When the function does not exis

ldexpl idiom

2010-04-05 Thread Bruno Haible
Likewise for ldexpl, although the use of a dangerous idiom did not lead to a test compilation error on Solaris 8 and Cygwin this time. 2010-04-05 Bruno Haible ldexpl: Improve idiom. * m4/ldexpl.m4 (gl_FUNC_LDEXPL): When the function is not declared, make sure to set HA

[PATCH] init.sh: make it easier for a test script to write to the tty, ...

2010-04-05 Thread Jim Meyering
FYI, >From b8b72c1b316e0db012f9d2e2dc6b7028bd5e96c2 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 5 Apr 2010 10:01:07 +0200 Subject: [PATCH] init.sh: make it easier for a test script to write to the tty, ... when using automake's parallel-tests mode. * tests/init.sh (stderr_fileno_): D