Re: [PATCH] maint: enforce one small aspect of formatting style: space-before-"("

2010-03-24 Thread Bruno Haible
Jim Meyering wrote: > > - t = pi - acosl(-x); > > + t = pi - acosl (- x); > > For a unary "-", it seems more readable to omit the following space. ok. There were no other objections in 4 days, so I committed the patch. Bruno

[PATCH] arpa/inet: fix mingw compilation warning

2010-03-24 Thread Eric Blake
Mingw doesn't have , so a conditional use of warning about duplicate declarations under -Wredundant-decls. Making the #pragma unconditional (as was already done in at least fcntl.in.h) shuts up gcc. * lib/arpa_inet.in.h (system_header): Hoist to be unconditional. Reported by Matthew Bolte. Signed

Re: multiple definitions of __printf__

2010-03-24 Thread Michel Boaventura
The project is pspp, and I'm using the latest git version of gnulib Could be other problem?

Re: multiple definitions of __printf__

2010-03-24 Thread Eric Blake
On 03/24/2010 04:21 PM, Michel Boaventura wrote: > Hello, > > I'm trying to compile a project which uses both gettext and gnulib. I'm > using mingw, and getting the above error: Could the project just be using a stale snapshot of gnulib? > Looking at the archive of this list, this error should b

multiple definitions of __printf__

2010-03-24 Thread Michel Boaventura
Hello, I'm trying to compile a project which uses both gettext and gnulib. I'm using mingw, and getting the above error: /home/michel/prof/pspp/sources/mingw/usr/i686-pc-mingw32/lib/libintl.a(printf.o): In function `__printf__': /home/arquivos/prof/pspp/sources/mingw/tmp-gettext/gettext-0.17/get

relaxing xnanosleep

2010-03-24 Thread Eric Blake
Right now, xnanosleep is GPL. But I don't see it calling exit() (which is normally the reason why most x*() interfaces are GPL), and it would be useful to use in libvirt. Any objections to relaxing the license to LGPLv2+, including a technical reason I might be overlooking? nanosleep and sigacti

Re: [PATCH 3/3] glob: test previous patch

2010-03-24 Thread Eric Blake
On 03/23/2010 05:29 PM, Bruno Haible wrote: > Hi Eric, > >> * tests/test-glob.c (main): Enhance test. >> * doc/posix-functions/glob.texi (glob): Document the fix. > > Thanks for providing this. > > Now, I still have a hard time understanding the other part of Andreas > Schwab's patch. "Match onl

[PATCH] build: sync primary and tests-related gnulib module lists

2010-03-24 Thread Jim Meyering
This patch is for information/discussion only. With today's wctob build failure problem and with two or three similar incidents recently, I wanted a way to automatically derive the list of modules used in gnulib-tests, but not in lib/. Here it is (see the "comm" use below). What to do with that li

Re: sc_Wundef_boolean

2010-03-24 Thread Simon Josefsson
I have pushed the patch now. /Simon

Re: sc_Wundef_boolean

2010-03-24 Thread Simon Josefsson
Pádraig Brady writes: > On 24/03/10 08:56, Simon Josefsson wrote: >> This syntax-check warning appears to fail: >> >> j...@mocca:~/src/libidn master$ make sc_Wundef_boolean >> Wundef_boolean >> grep: : No such file or directory >> j...@mocca:~/src/libidn master$ >> >> Any reason we can't use t

Re: sc_Wundef_boolean

2010-03-24 Thread Pádraig Brady
On 24/03/10 08:56, Simon Josefsson wrote: > This syntax-check warning appears to fail: > > j...@mocca:~/src/libidn master$ make sc_Wundef_boolean > Wundef_boolean > grep: : No such file or directory > j...@mocca:~/src/libidn master$ > > Any reason we can't use the normal VC_LIST_EXCEPT instead?

sc_Wundef_boolean

2010-03-24 Thread Simon Josefsson
This syntax-check warning appears to fail: j...@mocca:~/src/libidn master$ make sc_Wundef_boolean Wundef_boolean grep: : No such file or directory j...@mocca:~/src/libidn master$ Any reason we can't use the normal VC_LIST_EXCEPT instead? It will check more files than just config.h. Alternative

Re: new module 'pt_chown'

2010-03-24 Thread Simon Josefsson
Bruno Haible writes: > 2010-03-23 Bruno Haible > > pt_chown: Don't depend on GPLed modules. > * lib/pt_chown.c: Don't include idpriv.h. > (main): Don't drop privileges. > * modules/pt_chown (Depends-on): Remove idpriv-drop. > Reported by Simon Josefsson. ... > 201

Re: new syntax-check rule for @acronym?

2010-03-24 Thread Simon Josefsson
k...@freefriends.org (Karl Berry) writes: > syntax-check test for this seems useful, to foster harmonization across > GNU packages. How about the patch below? > > I have no objection, certainly. I pushed the patch below. Thanks, Simon >From 59255e746536e35c3ebd748535cc0469720949e9 Mon