Re: new module 'pt_chown'

2010-03-23 Thread Bruno Haible
Simon Josefsson wrote: > Btw, there is also some errors when building these modules: > > gllib/Makefile.am:4103: `pkglibexec_PROGRAMS' is used but `pkglibexecdir' is > undefined > ... > gllib/Makefile.am:4104: variable `pt_chown_LDADD' is defined but no program or > gllib/Makefile.am:4104: librar

Re: new module 'pt_chown'

2010-03-23 Thread Bruno Haible
Hi Simon, > Did you intend for the 'grantpt' and 'pt_chown' modules (marked as LGPL) > to depend on 'idpriv-drop' which is marked as GPL? I'm not sure what > you meant above though, so I could be missing something, but I got these > warnings: > > gnulib-tool: warning: module grantpt depends on a

COPYING text updates

2010-03-23 Thread Karl Berry
FYI, at Brett's request, I have updated the gnulib/doc/COPYING* files (and gnu.org, etc.) to not contain tabs. The only one that did not changes was COPYINGv3. Sigh.

Re: [PATCH 3/3] glob: test previous patch

2010-03-23 Thread Bruno Haible
Hi Eric, > * tests/test-glob.c (main): Enhance test. > * doc/posix-functions/glob.texi (glob): Document the fix. Thanks for providing this. Now, I still have a hard time understanding the other part of Andreas Schwab's patch. "Match only directories when pattern ends in a slash." Nothing in the

Re: new syntax-check rule for @acronym?

2010-03-23 Thread Karl Berry
syntax-check test for this seems useful, to foster harmonization across GNU packages. How about the patch below? I have no objection, certainly.

Re: portable openpty, forkpty

2010-03-23 Thread Simon Josefsson
(I'm adding bug-gnulib to the discussion, maybe it can move over there completely.) The forkpty code builds fine as a part of InetUtils on Mac OS X. I tried the gnulib self-checks for forkpty, but they failed: Making check in gltests make check-recursive make check-TESTS PASS: test-alignof PAS

new syntax-check rule for @acronym?

2010-03-23 Thread Simon Josefsson
k...@freefriends.org (Karl Berry) writes: > Hi Simon, > > Is the intention that even the n...@acronym{gnu} cases should be > replaced? Then what purpose is the @acronym keyword for? > > I wrote about that earlier. Minor typographic change which is rarely > used in GNU manuals. De facto

#defines in unistd.h

2010-03-23 Thread John W. Eaton
The current gnulib unistd.in.h file includes the following section: #if @GNULIB_GETHOSTNAME@ /* Get all possible declarations of gethostname(). */ # if @UNISTD_H_HAVE_WINSOCK2_H@ # if !defined _GL_SYS_SOCKET_H # undef socket # define socket socket_used_without_inclu

Re: new module 'pt_chown'

2010-03-23 Thread Simon Josefsson
Bruno Haible writes: > I put the module under LGPL rather GPL, because the modules 'openpty' and > 'forkpty' should stay under LGPL and I'm not willing to go into long > discussions about whether a module that uses (and cannot work without) a > GPLed program is a "combined work" based on that GPL

Re: [PATCH 1/3] glob: synchronize from glibc

2010-03-23 Thread Eric Blake
On 03/23/2010 01:34 AM, Bert Wesarg wrote: >> + * lib/glob.c (glob): Lose register modifier. Drop redundant >> + code. >> glob (pattern, flags, errfunc, pglob) >> - const char * restrict pattern; >> + const char *pattern; > > Thats 'restrict' not 'register'. Hmm. I wasn't r

Re: [PATCH 1/3] glob: synchronize from glibc

2010-03-23 Thread Bert Wesarg
On Tue, Mar 23, 2010 at 00:34, Eric Blake wrote: > diff --git a/ChangeLog b/ChangeLog > index 5153846..b2e66e4 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,11 @@ > +2010-03-22  Eric Blake   > + > +       glob: synchronize from glibc > +       * lib/glob.c (glob): Lose register modifier.