Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Eric Blake
According to Ralf Wildenhues on 2/18/2010 1:57 PM: >> Thanks for the offer, Ralf, but I feel pretty strongly >> that adding $EXEEXT as a suffix to every invocation would >> constitute "too much" pollution, and for what? To enable >> mingw-like systems to run tests using a portable shell. > > IIUC

Re: error after adding #includes to config.h

2010-02-18 Thread Bruce Korb
I guess I'd have been better off pretending that this was a completely new project and ignoring all the left over stuff. This was billed as a trivial-to-maintain project. *sigh*. I got it working, but I'm sure this is considered cheating. bootstrap now contains: > extra_libs=$' \\\n'$( >

Re: error after adding #includes to config.h

2010-02-18 Thread Bruno Haible
Bruce Korb wrote: > "make distcheck" is failing. The compile statement needs a "-I../../lib" > for this to be successful. Since I do not even have a Makefile.am in > the "intl" directory, it is unclear what I ought to be doing. > > > make[1]: Entering directory > > `/old-home/gnu/proj/sharutils

Re: error: redefinition of 'struct option'

2010-02-18 Thread Bruce Korb
Bruno Haible wrote: > Bruce Korb wrote: >> there is a bizarre >> dependency problem that causes close-hook.c to be recompiled for me, >> but you don't see it. Just for grins, try removing close-hook.o and >> see if it rebuilds correctly. :-} >> ... >> Some more data points. sharutils-bld/lib/get

Re: error: redefinition of 'struct option'

2010-02-18 Thread Bruno Haible
Bruce Korb wrote: > there is a bizarre > dependency problem that causes close-hook.c to be recompiled for me, > but you don't see it. Just for grins, try removing close-hook.o and > see if it rebuilds correctly. :-} > ... > Some more data points. sharutils-bld/lib/getopt.h gets rewritten > somew

Re: error: redefinition of 'struct option'

2010-02-18 Thread Bruce Korb
Hi Bruno, Eric, Bruno Haible wrote: > Hi Bruce, > >> My build procedure is to blow away the build tree, copy in the >> repository source files and do the build. It doesn't get any cleaner. > > Can you give us a recipe how to reproduce it? In the worst case, you can > do a "make distclean", tar

Re: error: redefinition of 'struct option'

2010-02-18 Thread Bruce Korb
Bruno Haible wrote: > Hi Bruce, Hi Bruno, Eric, Some more data points. sharutils-bld/lib/getopt.h gets rewritten somewhere along the line. The first version is correct and the initial build is successful. The second version is in error and the new copy time stamp triggers a recompile of close-

Re: gnulib and C++

2010-02-18 Thread Bruno Haible
The idiom for declaring the 'open' override can be simplified as follows, through the definition of three new macros _GL_DECL_NAMESPACE_C, _GL_ALIAS_RPL, _GL_ALIAS_STD. *** lib/fcntl.in.h.orig Fri Feb 19 00:25:00 2010 --- lib/fcntl.in.h Fri Feb 19 00:14:03 2010 *** *** 79,87

Re: gnulib and C++

2010-02-18 Thread Bruno Haible
Hi John, Ralf proposes: > I suggest you could > produce a helper header to #undef them again; you could even do that > automatically during bootstrap with above. Then only a portability > layer would need to avoid using these symbols in another namespace. This would only be a makeshift. Your exa

Re: gnulib and C++

2010-02-18 Thread Ralf Wildenhues
* John W. Eaton wrote on Thu, Feb 18, 2010 at 09:49:05PM CET: > On 18-Feb-2010, Ralf Wildenhues wrote: > | * John W. Eaton wrote on Thu, Feb 18, 2010 at 09:22:39PM CET: > | > On 18-Feb-2010, Ralf Wildenhues wrote: > | > | $ autoconf '--trace=AC_DEFINE:$1:$2' | grep ':rpl_[^:]*$' > | > > | > Runnin

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Thu, Feb 18, 2010 at 03:48:15PM CET: > According to Eric Blake on 2/18/2010 6:39 AM: > > For that matter, we should also try 'set +o posix' prior to looking for a > > better shell; it is certainly faster, and works for bash: > > > > $ /bin/sh -c 'a-b() { echo hi; }; a

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Ralf Wildenhues
* Jim Meyering wrote on Thu, Feb 18, 2010 at 09:44:59PM CET: > Ralf Wildenhues wrote: > > alias names are typically more relaxed, POSIX does not guarantee hyphens > > but dash, /bin/sh -> bash support them, Solaris sh doesn't but its ksh > > does. > That sounds like a good idea, but does it work?

Re: gnulib and C++

2010-02-18 Thread John W. Eaton
On 18-Feb-2010, Ralf Wildenhues wrote: | * John W. Eaton wrote on Thu, Feb 18, 2010 at 09:22:39PM CET: | > On 18-Feb-2010, Ralf Wildenhues wrote: | > | $ autoconf '--trace=AC_DEFINE:$1:$2' | grep ':rpl_[^:]*$' | > | > Running this with the Octave configure.ac file produces only | > | > gmtime:

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Jim Meyering
Ralf Wildenhues wrote: > * Eric Blake wrote on Thu, Feb 18, 2010 at 03:48:15PM CET: >> According to Eric Blake on 2/18/2010 6:39 AM: >> > For that matter, we should also try 'set +o posix' prior to looking for a >> > better shell; it is certainly faster, and works for bash: >> > >> > $ /bin/sh -c '

Re: gnulib and C++

2010-02-18 Thread Ralf Wildenhues
* John W. Eaton wrote on Thu, Feb 18, 2010 at 09:22:39PM CET: > On 18-Feb-2010, Ralf Wildenhues wrote: > | $ autoconf '--trace=AC_DEFINE:$1:$2' | grep ':rpl_[^:]*$' > > Running this with the Octave configure.ac file produces only > > gmtime:rpl_gmtime > localtime:rpl_localtime > > but I know

Re: gnulib and C++

2010-02-18 Thread John W. Eaton
On 18-Feb-2010, Ralf Wildenhues wrote: | Hello John, | | * John W. Eaton wrote on Thu, Feb 18, 2010 at 08:37:30PM CET: | > However, there is one issue that has caused a bit of trouble as I | > have started using more gnulib modules. | > | > Octave is mostly written in C++ and am having some diff

Re: gnulib and C++

2010-02-18 Thread Ralf Wildenhues
Hello John, * John W. Eaton wrote on Thu, Feb 18, 2010 at 08:37:30PM CET: > However, there is one issue that has caused a bit of trouble as I > have started using more gnulib modules. > > Octave is mostly written in C++ and am having some difficulty with the > rpl_ redefinitions of symbols that h

gnulib and C++

2010-02-18 Thread John W. Eaton
Hi, I'm trying to use gnulib with GNU Octave and am overall very pleased, as it is allowing me to remove a lot of cruft from Octave's source files and just assume that a POSIX environment is available without having to use a lot of #ifdefs. To me, that's a significant improvement. However, there

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Eric Blake
According to Eric Blake on 2/18/2010 6:39 AM: > For that matter, we should also try 'set +o posix' prior to looking for a > better shell; it is certainly faster, and works for bash: > > $ /bin/sh -c 'a-b() { echo hi; }; a-b' > /bin/sh: `a-b': not a valid identifier > $ /bin/sh -c 'set +o posix; a-

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Eric Blake
According to Jim Meyering on 2/18/2010 2:20 AM: >> On that system, /bin/sh is bash 3.2.49 from latest cygwin 1.7.x. I've been meaning to update cygwin's bash to 4.1, but the point is the same for either shell - the trick is that invoking the script with #!/bin/sh is what disables - in function nam

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 2/18/2010 1:34 AM: >> Simon Josefsson wrote: >>> ./init.sh: line 139: `test-acos': not a valid identifier >>> FAIL: test-pread.sh >> That failure is because we cannot create a function name containing a "-" >> using that shell. This is another porta

Re: Cygwin build report on Windows XP

2010-02-18 Thread Eric Blake
According to Simon Josefsson on 2/18/2010 6:00 AM: >> I've seen these failures for a long time now, but have not been bothered >> enough by them to do anything about it (m4 is single-threaded, so I use >> gnulib-tool --avoid tls-tests to avoid the test in the first place). >> > I don't think there

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Eric Blake
According to Jim Meyering on 2/18/2010 1:34 AM: > Simon Josefsson wrote: >> ./init.sh: line 139: `test-acos': not a valid identifier >> FAIL: test-pread.sh > That failure is because we cannot create a function name containing a "-" > using that shell. This is another portability hurdle that we sho

Re: Cygwin build report on Windows XP

2010-02-18 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 2/18/2010 12:52 AM: >> Bruno Haible writes: >> Starting test_cond .../bin/sh: line 5: 3124 Aborted (core dumped) FAIL: test-cond.exe Starting test_lock .../bin/sh: line 5: 1336 Aborted

Re: Cygwin build report on Windows XP

2010-02-18 Thread Eric Blake
According to Simon Josefsson on 2/18/2010 12:52 AM: > Bruno Haible writes: > >>> Starting test_cond .../bin/sh: line 5: 3124 Aborted (core >>> dumped) >>> FAIL: test-cond.exe >>> >>> Starting test_lock .../bin/sh: line 5: 1336 Aborted (core >>> dumped) >>> FAIL

Re: error: redefinition of 'struct option'

2010-02-18 Thread Bruno Haible
Hi Bruce, > My build procedure is to blow away the build tree, copy in the > repository source files and do the build. It doesn't get any cleaner. Can you give us a recipe how to reproduce it? In the worst case, you can do a "make distclean", tar up your source tarball on some site and let us in

Re: interix and rpl_select

2010-02-18 Thread Markus Duft
Simon Josefsson wrote: > Markus Duft writes: > >> Hey! >> >> a while ago you guys implemented a select() fix for interix 3.5 (thanks >> again ;)). now i was surprised to see the same issue come up again (it's >> there since a while now again, just had no time to dig into the problem). >> >> i now

Re: interix and rpl_select

2010-02-18 Thread Simon Josefsson
Markus Duft writes: > Hey! > > a while ago you guys implemented a select() fix for interix 3.5 (thanks > again ;)). now i was surprised to see the same issue come up again (it's > there since a while now again, just had no time to dig into the problem). > > i now had some time to look into it, an

interix and rpl_select

2010-02-18 Thread Markus Duft
Hey! a while ago you guys implemented a select() fix for interix 3.5 (thanks again ;)). now i was surprised to see the same issue come up again (it's there since a while now again, just had no time to dig into the problem). i now had some time to look into it, and i discovered, that select is onl

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Simon Josefsson
Jim Meyering writes: > Can you confirm that those tests succeed when you replace > #!/bin/sh with #!/bin/bash in the test scripts that use init.sh? Yes, then the self-test works. (I only tested test-pread.sh, but expect the others to behave the same.) /Simon

[PATCH] init.sh: don't use $(...) just yet

2010-02-18 Thread Jim Meyering
I tested init.sh on Solaris 10 by doing this locally, ./gnulib-tool --create-testdir --with-tests --dir=tt xstrtoll Running (in tt) ./configure && make && make dist, and copying the tarball to the Solaris system. There, I untarred and ran the usual ./configure && make && make check and got thi

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Jim Meyering
Simon Josefsson wrote: > Jim Meyering writes: > >> Right. The *.exe names are sorted, and test-acos is the >> first one encountered. > > Ah. > >> Is there a more functional shell on that system? >> If so, is it already detected and thus mentioned >> somewhere in config.status? > > checking for a

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Simon Josefsson
Jim Meyering writes: > Right. The *.exe names are sorted, and test-acos is the > first one encountered. Ah. > Is there a more functional shell on that system? > If so, is it already detected and thus mentioned > somewhere in config.status? checking for a shell that conforms to POSIX... /bin/s

Re: Cygwin build report on Windows XP

2010-02-18 Thread Simon Josefsson
Ralf Wildenhues writes: > * Simon Josefsson wrote on Thu, Feb 18, 2010 at 08:58:14AM CET: >> > The build times are interesting: >> > >> > gnulib-tool: 324 minutes >> > ./configure: 36 minutes >> > make check: 34 minutes > >> The build times are now: >> >> gnulib-tool: 418 minutes >> ./configure:

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Jim Meyering
Simon Josefsson wrote: > Below is a strange error that can be seen on: > > http://autobuild.josefsson.org/gnulib/log-201002171652277193000.txt > > There are no make -j switches here, which I suspected could be involved. > > ./init.sh: line 139: `test-acos': not a valid identifier > FAIL: test-pread

Re: ./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Jim Meyering
Simon Josefsson wrote: > Below is a strange error that can be seen on: > > http://autobuild.josefsson.org/gnulib/log-201002171652277193000.txt > > There are no make -j switches here, which I suspected could be involved. > > ./init.sh: line 139: `test-acos': not a valid identifier > FAIL: test-pread

Re: Cygwin build report on Windows XP

2010-02-18 Thread Ralf Wildenhues
* Simon Josefsson wrote on Thu, Feb 18, 2010 at 08:58:14AM CET: > > The build times are interesting: > > > > gnulib-tool: 324 minutes > > ./configure: 36 minutes > > make check: 34 minutes > The build times are now: > > gnulib-tool: 418 minutes > ./configure: 43 minutes > make check: 38 minutes >

./init.sh: line 139: `test-acos': not a valid identifier

2010-02-18 Thread Simon Josefsson
Below is a strange error that can be seen on: http://autobuild.josefsson.org/gnulib/log-201002171652277193000.txt There are no make -j switches here, which I suspected could be involved. ./init.sh: line 139: `test-acos': not a valid identifier FAIL: test-pread.sh ... ./init.sh: line 139: `test-a