Re: ASSERT macro

2009-12-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/24/2009 1:08 PM: >>> Either way we create macros.h and put ASSERT there > > Done this this big commit, now. > > > 2009-12-24 Bruno Haible > > Refactor common macros used in tests. > * tests/macros.h: N

Re: SIZEOF macro

2009-12-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/25/2009 3:58 AM: > Pádraig Brady wrote: >> I use LENGTHOF in my personal code. > > It's certainly handy and easy to remember. But in C we often make the > distinction between "length" (= number of elements that matter)

Re: new module 'unused-parameter'

2009-12-25 Thread Bruno Haible
Jim Meyering wrote: > > * lib/se-context.in.h: Arrange to include _GL_UNUSED_PARAMETER > > definition. Use _GL_UNUSED_PARAMETER instead of _GL_UNUSED. > > That looks fine. You're welcome to push it. Committed and pushed. Bruno

Re: localcharset: fix security problem

2009-12-25 Thread Bruno Haible
Hi, I wrote on 2009-10-18: > * m4/fcntl_h.m4 (gl_FCNTL_O_FLAGS): New macro, extracted from > gl_FCNTL_H. > (gl_FCNTL_H): Require it. > * modules/localcharset (Files): Add m4/fcntl_h.m4. When the 'localcharset' module contains a .m4 file, GNU gettextize will distribute this

Re: new module 'unused-parameter'

2009-12-25 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > > Eric wrote: >> Also, se-context.in.h and se-selinux.in.h would benefit from an >> unused-parameter module. > > Here's a proposed patch to make the generated selinux/selinux.h and > selinux/context.h files independent of the stuff defined in config.h. Hi Bruno, >

Re: SIZEOF macro

2009-12-25 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: >> According to Eric Blake on 12/24/2009 4:21 PM: >>> According to Bruno Haible on 12/24/2009 1:08 PM: >> Either way we create macros.h and put ASSERT there Done this this big commit, now. >>> >>> Hmm. macros.h defines SIZEOF, and test-argv-iter.c d

Re: SIZEOF macro

2009-12-25 Thread Bruno Haible
Pádraig Brady wrote: > I use LENGTHOF in my personal code. It's certainly handy and easy to remember. But in C we often make the distinction between "length" (= number of elements that matter) and "size" (= number of elements for which room is allocated). The array L"abc" has length 3, as determin

Re: cleaner headers

2009-12-25 Thread Bruno Haible
Jim Meyering wrote: > > > > openat: Fix warning. > > * lib/openat-proc.c: Include . > > > > Sure. Thanks. Committed and pushed. Bruno

Re: new module 'unused-parameter'

2009-12-25 Thread Bruno Haible
Hi Jim, Eric wrote: > Also, se-context.in.h and se-selinux.in.h would benefit from an > unused-parameter module. Here's a proposed patch to make the generated selinux/selinux.h and selinux/context.h files independent of the stuff defined in config.h. 2009-12-25 Bruno Haible * lib/s

Re: SIZEOF macro

2009-12-25 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 12/24/2009 4:21 PM: >> According to Bruno Haible on 12/24/2009 1:08 PM: > Either way we create macros.h and put ASSERT there >>> Done this this big commit, now. >> >> Hmm. macros.h defines SIZEOF, and test-argv-iter.c defines >> ARRAY_CARDINALITY

Re: cleaner headers

2009-12-25 Thread Jim Meyering
Bruno Haible wrote: > Now that gnulib's and don't include any more, > I'm seeing this warning: > > openat-proc.c: In function 'openat_proc_name': > openat-proc.c:91: warning: implicit declaration of function 'close' > > Jim, is it ok to apply this? > > > 2009-12-24 Bruno Haible > > open