Re: GL_LINK_WARNING

2009-12-15 Thread Jim Meyering
Eric Blake wrote: > Another thing to consider. Why are we even bothering with a link warning, > which only works for ELF, when gcc provides a more generic solution that will > also work for Cygwin and other non-ELF platforms? ... > In other words, maybe I should go with option: > 4. Redefine GL_LI

Re: GL_LINK_WARNING

2009-12-15 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/15/2009 4:51 PM: >>> to instead use >>> #define func (GL_LINK_WARNING("..."),func) > > You would need that only for functions that take a variable number of > arguments. > Currently > - openat, fprintf, printf, snpr

Re: coreutils-8.2 misc/ls-time test failure

2009-12-15 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-gnulib] According to Eric Blake on 12/15/2009 7:48 PM: > According to John Stanley on 12/15/2009 4:42 PM: >> Basically, what's happening is that 'touch -a ..' updated ctime in >> coreutils-7.6, >> but does not update ctime in coreutils-8.2

Re: btwowc(EOF) hang with gcc 4.4.2

2009-12-15 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-gnulib] According to Karl Berry on 12/15/2009 3:49 PM: > Hi Jim and all, > > On a CentOS 5.4 system, compiling with gcc 4.4.2, configure goes into an > infinite loop here: > checking whether btowc(EOF) is correct... > > Running gdb on c

Re: _GL_ARG_NONNULL

2009-12-15 Thread Bruno Haible
Hi Simon, > The cause seems to be a un-expanded _GL_ARG_NONNULL: > > j...@mocca:~/gnutls4win$ grep 'NONNULL is copied' > build/libidn-1.16/gltests/stdlib.h > /* The definition of _GL_ARG_NONNULL is copied here. */ _GL_ARG_NONNULL should be defined in the lines that follow this one. If not, th

_GL_ARG_NONNULL

2009-12-15 Thread Simon Josefsson
Libidn with recent gnulib fails on mingw: ./stdlib.h: In function 'rpl_putenv': ./stdlib.h:337: error: expected declaration specifiers before '_GL_ARG_NONNULL' The cause seems to be a un-expanded _GL_ARG_NONNULL: j...@mocca:~/gnutls4win$ grep 'NONNULL is copied' build/libidn-1.16/gltests/stdlib

Re: GL_LINK_WARNING (was: fcntl for mingw)

2009-12-15 Thread Bruno Haible
Hi Eric, > > 2. Ditch this series, and instead go and change all uses of > > GNULIB_POSIXCHECK > > that used > > #define func(args) (GL_LINK_WARNING("..."),func(args)) > > to instead use > > #define func (GL_LINK_WARNING("..."),func) You would need that only for functions that take a variable

Re: [PATCH] link-warning, arg-nonnull: fix Makefile.am target

2009-12-15 Thread Joel E. Denny
On Tue, 15 Dec 2009, Joel E. Denny wrote: > Recent gnulib changes break the build of Bison's master branch, where we > have a single top-level Makefile.am that includes local.mk from each > subdirectory. There's no problem on Bison's branch-2.5, where we still > have a Makefile.am in each subd

Re: GL_LINK_WARNING

2009-12-15 Thread Simon Josefsson
Eric Blake writes: > Also, the point of GNULIB_POSIXCHECK was not whether other compilers > can detect the problem, so much as making it easy for a random > developer on Linux to quickly determine if they are using something > that merely happened to work because they were on Linux, but would > f

Re: GL_LINK_WARNING

2009-12-15 Thread Eric Blake
Simon Josefsson josefsson.org> writes: > > Another thing to consider. Why are we even bothering with a link warning, > > which only works for ELF, when gcc provides a more generic solution that will > > also work for Cygwin and other non-ELF platforms? > > Because gcc is not the only support

Re: GL_LINK_WARNING

2009-12-15 Thread Simon Josefsson
Eric Blake writes: > Eric Blake byu.net> writes: > >> >> So, what should I do? Options: >> 1. Check in the patches below as-is >> 2. Ditch this series, and instead go and change all uses of >> GNULIB_POSIXCHECK >> that used >> #define func(args) (GL_LINK_WARNING("..."),func(args)) >> to ins

[PATCH] link-warning, arg-nonnull: fix Makefile.am target

2009-12-15 Thread Joel E. Denny
Recent gnulib changes break the build of Bison's master branch, where we have a single top-level Makefile.am that includes local.mk from each subdirectory. There's no problem on Bison's branch-2.5, where we still have a Makefile.am in each subdirectory. Make complains that it cannot find lib/l

Re: [PATCH] maint.mk (null_AM_MAKEFLAGS, built_programs): remove unused definitions

2009-12-15 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Tue, Dec 15, 2009 at 07:48:21AM CET: > Ralf Wildenhues wrote: > > Adding LIBTOOL here is wrong; you meant LIBTOOLIZE. > > I've removed it. > I don't see anything except bootstrap that runs $(LIBTOOLIZE). Do you? No, adding LIBTOOLIZE should be fine. > > There ar

GL_LINK_WARNING (was: fcntl for mingw)

2009-12-15 Thread Eric Blake
Eric Blake byu.net> writes: > > So, what should I do? Options: > 1. Check in the patches below as-is > 2. Ditch this series, and instead go and change all uses of GNULIB_POSIXCHECK > that used > #define func(args) (GL_LINK_WARNING("..."),func(args)) > to instead use > #define func (GL_LINK_W

Re: fcntl for mingw

2009-12-15 Thread Eric Blake
Bruno Haible clisp.org> writes: > > #elif defined GNULIB_POSIXCHECK > > -# undef openat > > -# define openat(f,u,g) \ > > -(GL_LINK_WARNING ("openat is not portable - " \ > > - "use gnulib module openat for portability"), \ > > - openat) > > +/* Can't provide link wa

Re: gnulib-tests with dup_cloexec() failing on old Linux kernel

2009-12-15 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ondřej Vašík on 12/15/2009 2:27 AM: > Hello, > as you could see at > http://koji.fedoraproject.org/koji/taskinfo?taskID=1872609 > gnulib-tests (from coreutils-8.2 tarball) with dup_cloexec() function > are failing in koji build system (wit

gnulib-tests with dup_cloexec() failing on old Linux kernel

2009-12-15 Thread Ondřej Vašík
Hello, as you could see at http://koji.fedoraproject.org/koji/taskinfo?taskID=1872609 gnulib-tests (from coreutils-8.2 tarball) with dup_cloexec() function are failing in koji build system (with old RHEL-5 xen kernel) - errno EINVAL . I temporarily skipped those tests to get coreutils 8.2 (and agai

Re: areadlink: relax license to LGPLv2+

2009-12-15 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> I'd like to relax the areadlink's license to LGPLv2+, ... >> Is that ok with you? > > Sure. All my contributions to areadlink.c, areadlinkat.c, > areadlink-with-size.c, areadlinkat-with-size.c (if any) can be > under LGPLv2+. > > This code was based on the old xre

Re: [PATCH] fprintf-posix: fix memory leak

2009-12-15 Thread Bruno Haible
Hi Joel, > +2009-12-15 Joel E. Denny > + > + fprintf-posix: fix memory leak > + * lib/fprintf.c (fprintf): Free memory allocated by vasnprintf. The fix is obviously correct. But it's good that you ask, because the bug occurs also in 3 other places. Below is what I'm committing. > I ha

Re: areadlink: relax license to LGPLv2+

2009-12-15 Thread Bruno Haible
Hi Jim, > I'd like to relax the areadlink's license to LGPLv2+, ... > Is that ok with you? Sure. All my contributions to areadlink.c, areadlinkat.c, areadlink-with-size.c, areadlinkat-with-size.c (if any) can be under LGPLv2+. This code was based on the old xreadlink.c by you and Paul Eggert; so