Re: fix mkostemp, add pipe2-safer

2009-12-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2009 5:18 PM: > - The code accesses an undefined variable 'result'. You caught one, but missed the other. I noticed some other things while fixing it. Pushing these: - -- Don't work too hard, make some time for f

Re: pty.h replacement

2009-12-07 Thread Bruno Haible
Hi Simon, > > Darwin has forkpty in util.h instead of the glibc name of pty.h. I'm > > working on a gnulib module to provide compatibility mappings... stay > > tuned. > > Here it is. Tested on glibc debian and Mac OS X 10.5. As far as I can see the portability situation of openpty and forkpty

Re: mgetgroups improvements

2009-12-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 12/4/2009 7:55 PM: > Good thinking. I've pushed the first two, and here's a respin of the > third for further review. No further comment, so I've pushed the third patch; mgetgroups now ignores trivial duplicates. - -- Don'

Re: fix mkostemp, add pipe2-safer

2009-12-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 12/6/2009 5:53 PM: >> If this is specifically targeted at non-POSIX systems, it would be good to >> have >> a comment about it. > > Okay, then, a comment describing that dup2 is used as an EBADF filter, and > not for an

Re: update copyrights?

2009-12-07 Thread Alfred M. Szmidt
You mean, changing Copyright (C) 1999, 2000, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc. to Copyright (C) 1999-2009 Free Software Foundation, Inc. ? It's allowed by current FSF rules, but the fact that the FSF did not want it for 1

Re: Build failure on Darwin

2009-12-07 Thread Simon Josefsson
Simon Josefsson writes: > l...@gnu.org (Ludovic Courtès) writes: > >> Hello, >> >> Current Git fails to build on Darwin: >> >> http://hydra.nixos.org/build/175517/log/raw >> >> I haven’t investigated any further, though. > > Darwin has forkpty in util.h instead of the glibc name of pty.h. I'm

Re: update copyrights?

2009-12-07 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> If everyone agrees, I'd like to update copyrights, too, >> before the new year. > > You mean, changing >Copyright (C) 1999, 2000, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 >Free Software Foundation, Inc. > to >Copyright (C) 1999-2009 Fr

Re: untabify?

2009-12-07 Thread Jim Meyering
Bruno Haible wrote: >> I would be happy to do that to all of gnulib. >> It is long overdue. > > Great! > > When? It's a disruptive change: Everyone who has patches on top of gnulib Actually it need not be disruptive. You just need a little rigor and a trick or two: > will have to update these. Bu

Re: update copyrights?

2009-12-07 Thread Bruno Haible
Jim Meyering wrote: > If everyone agrees, I'd like to update copyrights, too, > before the new year. You mean, changing Copyright (C) 1999, 2000, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc. to Copyright (C) 1999-2009 Free Software Foundation, Inc. ? It's

Re: untabify?

2009-12-07 Thread Bruno Haible
Hi Jim, > I would be happy to do that to all of gnulib. > It is long overdue. Great! When? It's a disruptive change: Everyone who has patches on top of gnulib will have to update these. But since we are in continuous development mode constantly, any time is as good as any other time. (Actually,