usleep (was: pending patches?)

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/14/2009 6:18 AM: > I'm also thinking of adding a usleep module to guarantee Linux semantics > (usleep(100) waits a second, rather than failing instantly with > EINVAL). That will clean up its use somewhat. I'm pushin

Re: OpenBSD chown

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/16/2009 10:16 PM: > According to Eric Blake on 11/14/2009 12:48 PM: >> However, I'm now seeing a failure on OpenBSD, where chown refuses to >> change ctime on files if there is no change to ownership: > > It turns out tha

Re: mkostemps

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/4/2009 7:18 PM: > According to Eric Blake on 11/2/2009 4:18 PM: >> Now that glibc 2.11 offers mkostemps, we should too. Any objections to this >> patch series? > > No comments, so I went ahead and pushed this. One more

Re: test-xalloc-die buglet

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/17/2009 12:07 PM: >> -compare - t-xalloc-die.tmp <<\EOF || { (exit 1); exit 1; } >> +cat $tmperr | tr -d '\015' > ${tmperr}2 > > Useless use of cat. Also, check for errors. Try: > > tr -d '\015' < $tmperr > ${tmperr}2

Re: #ifndef __need_getopt not working in getopt.h

2009-11-17 Thread Bruce Korb
Nope. The first time through, it is still the installed getopt.h and it is the broken configured version the second time through. I could do my testing thus: configure make make dist cp /usr/include/getopt.h lib/. make check but I'd rather understand why A) the configured version is invalid, and

Re: #ifndef __need_getopt not working in getopt.h

2009-11-17 Thread Bruce Korb
On Sat, Nov 14, 2009 at 2:57 PM, Eric Blake wrote: > Is this something you can reproduce using just './gnulib-tool --with-tests > - --test [your list of modules]'?  Is this a case where you need to upgrade > your list of modules to use getopt-posix or getopt-gnu, instead of the > deprecated plain

Re: Error message doesn't say, "error"

2009-11-17 Thread Bruce Korb
Alfred M. Szmidt wrote: > Bruce, how about this? I'd actually rather see the whole version.m4 > mess be removed, but this is a decent fix for now. A good and proper define-in-one-place fix for version stamps is a really good idea. Sticking the original version string into an AC_INIT() m4 macro i

Re: [PATCH] Add ‘gnulib-tool’ support for LGPLv3+

2009-11-17 Thread Simon Josefsson
l...@gnu.org (Ludovic Courtès) writes: > Hello, > > The attached patch fixes LGPLv3+ support in ‘gnulib-tool’. Hi! Pushed, thanks. /Simon

Re: [PATCH] Add ‘gnulib-tool’ support for LGPLv3+

2009-11-17 Thread Jim Meyering
Ludovic Courtès wrote: > The attached patch fixes LGPLv3+ support in ‘gnulib-tool’. > > Thanks, > Ludo’. > > From 29c308aa797c07f9cc40074338ae6b5e5a290be8 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= > Date: Tue, 17 Nov 2009 21:38:51 +0100 > Subject: [PATCH] Add `gnulib-tool

[PATCH] Add ‘gnulib-tool’ support for LGPLv3+

2009-11-17 Thread Ludovic Courtès
Hello, The attached patch fixes LGPLv3+ support in ‘gnulib-tool’. Thanks, Ludo’. From 29c308aa797c07f9cc40074338ae6b5e5a290be8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= Date: Tue, 17 Nov 2009 21:38:51 +0100 Subject: [PATCH] Add `gnulib-tool --import' support for LGPLv3+.

Re: test-xalloc-die buglet

2009-11-17 Thread Jim Meyering
Eric Blake wrote: ... > test ! -s $tmpout || { (exit 1); exit 1; } > > Hmm, I'm really starting to like the idea of a common init script, so we can > just do "Exit 1" instead of "{ (exit 1); exit 1; }". Exactly. The next question is whether to automatically create a temporary directory for each te

Re: test-xalloc-die buglet

2009-11-17 Thread Eric Blake
Simon Josefsson josefsson.org> writes: > > I noticed an EOL problem on mingw and pushed the fix below. You beat me to it; I noticed the same, but didn't have quite as large a patch. > > -tmpfiles="t-xalloc-die.tmp" > +tmpout=t-xalloc-die.tmp-stderr > +tmperr=t-xalloc-die.tmp-stdout > +tmpfile

test-xalloc-die buglet

2009-11-17 Thread Simon Josefsson
I noticed an EOL problem on mingw and pushed the fix below. /Simon >From 3e00f5fce5b904dc642aff88abbcf75867263e0a Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Tue, 17 Nov 2009 19:58:12 +0100 Subject: [PATCH] tests/test-xalloc-die.sh: Deal with EOL differences, and more. --- ChangeLog

Re: the _t suffix

2009-11-17 Thread Bruce Korb
Hi Simon, It's true. However, it is so ubiquitously used that there's no way that it could ever be enforced. I consider it bogus. Too big of a name space grab. It also reserves functions beginning with "str", too. Also egregious, even if not stratospherically over the top. On Tue, Nov 17, 20

Re: vasnprintf warnings

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/4/2009 6:50 PM: > According to Eric Blake on 10/30/2009 10:27 AM: >> Bruno, is it okay to apply this patch to silence these compiler warnings? > >> * lib/vasnprintf.c (VASNPRINTF): Avoid shadowing our own local >> variabl

Re: {un,}setenv fixes

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/17/2009 2:45 AM: >> I'll test on a few more platforms, then push. > > test-unsetenv is failing on Solaris 10: Well, you obviously spotted a platform I missed in re-testing. ;) > The above makes me wonder if Solaris 10

Re: Intel C++ compiler for Linux 11.1 doesn't build m4 1.4.13 on NetBSD

2009-11-17 Thread Alexander Nasonov
17.11.09, 06:12, "Eric Blake" : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > Are you sure you are using a C++ compiler instead of a C compiler? I was refering to the product called "Intel® C++ Compiler Professional Edition for Linux". They ship the C compiler as well. Thanks, Alex

Re: Intel C++ compiler for Linux 11.1 doesn't build m4 1.4.13 on NetBSD

2009-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Alexander Nasonov on 11/17/2009 2:37 AM: > it fails here: > > fflush.c(95): error: a value of type "__off_t={__int64_t={long long}}" cannot > be assigned to an entity of type "fpos_t" > fp_->_offset = pos; > ^ > comp

the _t suffix

2009-11-17 Thread Simon Josefsson
I've seen some people suggest that POSIX reserves the _t suffix namespace for its own variables. Is this true? If so, is there any need to worry about gnulib? There are several gnulib modules that declares types with the _t suffix. I've found this link but it is not really clear to me that it r

Re: {un,}setenv fixes

2009-11-17 Thread Jim Meyering
Eric Blake wrote: > Coreutils got recent reports of a FreeBSD failure on 'env -u a=b', which > should > fail because unsetenv should reject invalid environment variable names (kind > of > obvious, though, when you realize BSD unsetenv returns void instead of int, > contrary to the POSIX signature

Re: xalloc-die-tests

2009-11-17 Thread Simon Josefsson
Simon Josefsson writes: > One though on the changes is that if we use a shell script to wrap > running the binary, we'd might as well make the shell script check that > the xalloc-die binary returns a non-0 exit code and drop the XFAIL_TESTS > approach for the module. But I don't care strongly a

Re: xalloc-die-tests

2009-11-17 Thread Simon Josefsson
Thanks Eric and Jim. One though on the changes is that if we use a shell script to wrap running the binary, we'd might as well make the shell script check that the xalloc-die binary returns a non-0 exit code and drop the XFAIL_TESTS approach for the module. But I don't care strongly about it. /S