Hi Jim,
> I noticed that when the test-c-stack2.sh test is skipped,
> it leaves behind its temporary file.
>
> I propose to fix it by adding a trap ... 0.
I would prefer the attached patch, because it's simpler (straightforward)
and avoids the 'trap ... 0' command which
1. has portability prob
Hi Jim,
> Without this change, this test's temporary file is left behind every
> time it is run.
>
> Any objection?
The #include and the first unlink are fine. Thanks, well spotted.
The second unlink is better omitted, since when the message "file operations
failed"
message is printed, the use
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruce Korb on 11/14/2009 1:48 PM:
>> rm -f libgnu.a
>> ar cru libgnu.a close-hook.o openat-die.o xalloc-die.o xstrtoimax.o \
>> basename-lgpl.o chdir-long.o dirname-lgpl.o dup-safer.o dup2.o exitfail.o \
>> fd-safer.o fdopendir.o getcwd
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Robert Millan on 11/14/2009 8:30 AM:
: p - startp + 1U;
to still show that we intend for unsigned math, but without a cast?
>>> The warning persists.
>> Can you show the exact gcc version, command line options, and warning
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruce Korb on 11/14/2009 12:15 PM:
> In file included from ../lib/inttostr.h:24,
> from shar.c:140:
> ../lib/intprops.h:44:1: warning: "TYPE_MINIMUM" redefined
> shar.c:108:1: warning: this is the location of the previous
This only seems to be happening during "make check".
> make check-recursive
> make[2]: Entering directory `/home/gnu/proj/sharutils-bld/lib'
> make[3]: Entering directory `/home/gnu/proj/sharutils-bld/lib'
> rm -f getopt.h-t getopt.h && \
> { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY!
$ gcc -H -DHAVE_CONFIG_H -I. -I.. -g -Wall -MT close-hook.o \
-MD -MP -MF .deps/close-hook.Tpo -c -o close-hook.o close-hook.c
. ../config.h
.. ./stdlib.h
... /usr/include/stdlib.h
/usr/include/features.h
. /usr/include/sys/cdefs.h
.. /usr/include/bits/wordsize.h
. /usr/include/gnu
Bruce Korb wrote:
> Eric Blake wrote:
>> According to Bruce Korb on 11/14/2009 11:36 AM:
>>> Still trying to build shar (now without "gnits").
>>> I see the sources for these in sharutils/lib, but:
>> Are you using gnulib-tool --import, the bootstrap script from gnulib, or
>> some other means to im
In file included from ../lib/inttostr.h:24,
from shar.c:140:
../lib/intprops.h:44:1: warning: "TYPE_MINIMUM" redefined
shar.c:108:1: warning: this is the location of the previous definition
../lib/intprops.h:50:1: warning: "TYPE_MAXIMUM" redefined
shar.c:113:1: warning: this is th
Eric Blake wrote:
> According to Bruce Korb on 11/14/2009 11:36 AM:
>> Still trying to build shar (now without "gnits").
>> I see the sources for these in sharutils/lib, but:
>
> Are you using gnulib-tool --import, the bootstrap script from gnulib, or
> some other means to import gnulib modules?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruce Korb on 11/14/2009 11:36 AM:
> Still trying to build shar (now without "gnits").
> I see the sources for these in sharutils/lib, but:
Are you using gnulib-tool --import, the bootstrap script from gnulib, or
some other means to impor
Still trying to build shar (now without "gnits").
I see the sources for these in sharutils/lib, but:
gcc -g -Wall -o shar shar.o encode.o ../lib/libgnu.a ../lib/libgnu.a
shar.o: In function `walkdown':
/home/gnu/proj/sharutils-bld/src/shar.c:407: undefined reference to `xmalloc'
/home/gnu/proj
Hi Eric,
On Sat, Nov 14, 2009 at 10:04 AM, Eric Blake wrote:
> According to Bruce Korb on 11/14/2009 11:01 AM:
>> that includes 140 lines of warning messages all caused by gnulib
>
> We've brought that up before, but Bruno didn't like Ralf's patch to
> silence the warnings in his macros. For now
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruce Korb on 11/14/2009 11:01 AM:
> that includes 140 lines of warning messages all caused by gnulib
We've brought that up before, but Bruno didn't like Ralf's patch to
silence the warnings in his macros. For now, you'll just have to ig
Without some clear marker, it is more than a little hard to find.
This is line 414 of 619 lines of typescript text:
configure.ac:9: version `sharutils_version' doesn't follow Gnits standards
that includes 140 lines of warning messages all caused by gnulib
macros. By the way, I didn't find this:
Ralf Wildenhues writes:
> Hi Simon,
>
> * Simon Josefsson wrote on Fri, Nov 13, 2009 at 10:41:20AM CET:
>> I prepared a code coverage report for gnulib:
>>
>> http://www.gnu.org/software/gnulib/coverage/
>
> Thank you for doing this!
>
> How did you create the report, and was manual hacking need
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/14/2009 8:37 AM:
> Who would object to my making every test script source a file
> that contains this function definition:
Making every gnulib unit test shell script source a common file seems
reasonable to me.
- --
Do
Ralf Wildenhues wrote:
> * Jim Meyering wrote on Sat, Nov 14, 2009 at 02:51:34PM CET:
>> Ralf Wildenhues wrote:
>> > But that separate patch would belong before your proposed one, as the
>> > zero trap exposes this issue more.
>>
>> If someone actually objects, I'll change each exit N to "(exit N);
On Sat, Nov 14, 2009 at 07:41:24AM -0700, Eric Blake wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> According to Robert Millan on 11/9/2009 2:50 PM:
> >> I'm not a fan of unnecessary casts. Can't we instead write this as:
> >>
> >> : p - startp + 1U;
> >>
> >> to still show that we
Eric Blake wrote:
> I was surprised when I got a link failure when using the Solaris cc on
> test-chown.c due to missing program_name, even though using gcc did just
> fine. It turns out that mgetgroups.c uses xalloc_oversized from
> "xalloc.h", which is only a macro and by itself drags nothing in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Robert Millan on 11/9/2009 2:50 PM:
>> I'm not a fan of unnecessary casts. Can't we instead write this as:
>>
>> : p - startp + 1U;
>>
>> to still show that we intend for unsigned math, but without a cast?
>
> The warning persists.
Can
On Sat, Nov 14, 2009 at 06:47:15AM -0700, Eric Blake wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> According to Robert Millan on 11/9/2009 2:00 PM:
> >> This is wrong, since 'echo -n' is not portable. It should use printf
> >> instead,
> >> or find some other portable way to coun
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I was surprised when I got a link failure when using the Solaris cc on
test-chown.c due to missing program_name, even though using gcc did just
fine. It turns out that mgetgroups.c uses xalloc_oversized from
"xalloc.h", which is only a macro and by it
* Jim Meyering wrote on Sat, Nov 14, 2009 at 02:51:34PM CET:
> Ralf Wildenhues wrote:
> > But that separate patch would belong before your proposed one, as the
> > zero trap exposes this issue more.
>
> If someone actually objects, I'll change each exit N to "(exit N); exit N"
> in the affected fi
Ralf Wildenhues wrote:
> * Jim Meyering wrote on Sat, Nov 14, 2009 at 01:33:14PM CET:
>> Ralf Wildenhues wrote:
>> > Not only that, you also have to ensure to get the right exit status into
>> > the zero trap, by using something like
>> > (exit $N); exit $N
>> >
>> > throughout, see '(autoconf.in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Robert Millan on 11/9/2009 2:00 PM:
>> This is wrong, since 'echo -n' is not portable. It should use printf
>> instead,
>> or find some other portable way to count $m4dirs.
>
> Hi,
>
> In that case, please use printf. It should work
> Unfortunately, doing that is often at odds with the goals of
> keeping the test code simple and efficient. If you find small
> and clean changes that improve matters without inducing
> inordinate inefficiency even in projects with thousands of source
> files, please send a patch.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/13/2009 11:46 PM:
> With the patch I committed,
> ./bootstrap --gnulib-srcdir=$HOME/w/co/gnulib
> now updates .gitmodules (as indicated by your diff below).
> Before it did not.
Or if $GNULIB_SRCDIR is set in your env
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/14/2009 12:20 AM:
> Eventually, it'd be good to factor out your nap function definition,
> maybe into a module. There is already one copy in test-stat-time.c,
> and this patch adds two more. I presume they're all ident
* Jim Meyering wrote on Sat, Nov 14, 2009 at 01:17:19PM CET:
> Unfortunately, doing that is often at odds with the goals of keeping the
> test code simple and efficient. If you find small and clean changes
> that improve matters without inducing inordinate inefficiency even in
> projects with thou
* Jim Meyering wrote on Sat, Nov 14, 2009 at 01:33:14PM CET:
> Ralf Wildenhues wrote:
> > Not only that, you also have to ensure to get the right exit status into
> > the zero trap, by using something like
> > (exit $N); exit $N
> >
> > throughout, see '(autoconf.info)Limitations of Builtins'.
>
Ralf Wildenhues wrote:
> * Jim Meyering wrote on Sat, Nov 14, 2009 at 01:11:38PM CET:
>> I propose to fix it by adding a trap ... 0.
>> A welcome side-effect is that with this change, you remove
>> temporary files from only one place: the trap, rather
>> than just prior to every other exit point.
>
Hi Bruno,
Without this change, this test's temporary file is left behind every
time it is run.
Any objection?
>From 314ab5c4729f34bcb2aca85181091a4f22d98e52 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 14 Nov 2009 13:20:25 +0100
Subject: [PATCH] test-freading: remove a temporary file
Hi Jim,
* Jim Meyering wrote on Sat, Nov 14, 2009 at 01:11:38PM CET:
> I propose to fix it by adding a trap ... 0.
> A welcome side-effect is that with this change, you remove
> temporary files from only one place: the trap, rather
> than just prior to every other exit point.
>
> The only tricky
Alfred M. Szmidt wrote:
> it would be nice if the output from syntax-check was compatible with
> compilation mode so that one can use it to jump to each line easily.
I agree that it would be nice.
Unfortunately, doing that is often at odds with the goals of keeping the
test code simple and effici
I noticed that when the test-c-stack2.sh test is skipped,
it leaves behind its temporary file.
I propose to fix it by adding a trap ... 0.
A welcome side-effect is that with this change, you remove
temporary files from only one place: the trap, rather
than just prior to every other exit point.
Th
copyright-check doesn't handle multi-line copyright years for texinfo,
the following causes an error that the year list is outdated:
Copyright @copyright{} 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007,
2008, 2009 Free Software Foundation, Inc.
it would be nice if the output from syntax-check was compatible with
compilation mode so that one can use it to jump to each line easily.
Hi Simon,
* Simon Josefsson wrote on Fri, Nov 13, 2009 at 10:41:20AM CET:
> I prepared a code coverage report for gnulib:
>
> http://www.gnu.org/software/gnulib/coverage/
Thank you for doing this!
How did you create the report, and was manual hacking needed in order to
get it to work? I'm runn
You may have seen the tests in maint.mk that help you avoid inclusion
of unused header files, e.g.,
# Prohibit the inclusion of assert.h without an actual use of assert.
sc_prohibit_assert_without_use:
@h='' re='\
in a file with no "use" of assert. Of course, it's a naive chec
On 14-Nov-2009, Jim Meyering wrote:
| John W. Eaton wrote:
| > Would the following patch be OK for recognizing Mercurial in the
| > build-aux/bootstrap script? It seems to work for me. Maybe there is
| > a better way of recognizing that a file is tracked, but I'm not sure
| > what it is.
|
| Ca
41 matches
Mail list logo
