Jim Meyering wrote:
> There are other ways to avoid the warning that are cleaner
Yes, I would have handled this one by adding a 'default: break;'
alternative to the 'switch' statement. As a by-product of silencing
the warning, it would also increase the robustness of the code.
Bruno
+diff --git a/lib/regcomp.c b/lib/regcomp.c
This is okay.
diff --git a/gl/lib/regex_internal.c.diff b/gl/lib/regex_internal.c.diff
This is okay. There is one caller of re_node_set_remove_at, in
regexec.c, which might pass SIZE_MAX as the second parameter to
re_node_set_remove_at. This wo
Jim Meyering wrote:
> With these two change sets, ./configure --enable-gcc-warnings && make
> in builds with most warnings enabled also in lib/.
>
> To make that work, I've chosen to disable-in-lib/ some warning options, via
>
> -Wno-missing-prototypes
> -Wno-uninitialized
> -Wno-unused-macro
There are other ways to avoid the warning that are cleaner (outlined
on this list already), but those are more invasive, so I've taken the
easy way out, for now:
>From 57eaa6500c8afacc43b4dd301e6ff7123ee2fe48 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 28 Oct 2009 09:26:04 +0100
Subjec
Here's hoping that POSIX (or ISO C) will eventually fix fputc/fwrite/etc.
so that we don't have to add caveats like what I wrote in the comment below.
As far as I know, date, du --time and uptime are the only clients that
use fprintftime, so even if this can hide a real failure, it's not
*that* bi
Bruno Haible wrote:
> math.in.h does declare everything that it provides. But math.in.h is not
> always present when isnan[fdl].c is compiled.
>
> This should silence gcc and address your question.
>
> 2009-10-27 Bruno Haible
>
> * lib/isnan.c (rpl_isnan[fdl]): Repeat the specification dec
Bruno Haible wrote:
> Jim Meyering wrote:
>> build (--enable-gcc-warnings): enable gcc's -Werror also in lib/
>
> Does your README-hacking file say that building with
> --enable-gcc-warnings is only supported on glibc systems with
> recent enough GCC?
Good point. We all knew that, but it wasn't d
