Re: enable -Werror for lib/ in coreutils

2009-10-27 Thread Bruno Haible
Eric Blake wrote: > > b/lib/isnan.c > > +@@ -67,6 +67,8 @@ > > + ((sizeof (DOUBLE) + sizeof (unsigned int) - 1) / sizeof (unsigned int)) > > + typedef union { DOUBLE value; unsigned int word[NWORDS]; } memory_double; > > + > > ++int FUNC (DOUBLE x); > > Why are there no header files declari

Re: enable -Werror for lib/ in coreutils

2009-10-27 Thread Bruno Haible
Jim Meyering wrote: > build (--enable-gcc-warnings): enable gcc's -Werror also in lib/ Does your README-hacking file say that building with --enable-gcc-warnings is only supported on glibc systems with recent enough GCC? It is known that on other platforms and with older GCC versions, gcc shows ma

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Giuseppe Scrivano
Bruno Haible writes: > Pádraig Brady wrote: >> >> Of course this should only apply if its effect is not externally >> >> observable; if I have a very small file B and a very large file A, and I >> >> can get >> >> >> >> $ md5sum --threads A B >> >> abcdabcdabcdabcdabcdabcdabcdabcd B >> >>

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Bruno Haible
Pádraig Brady wrote: > >> Of course this should only apply if its effect is not externally > >> observable; if I have a very small file B and a very large file A, and I > >> can get > >> > >> $ md5sum --threads A B > >> abcdabcdabcdabcdabcdabcdabcdabcd B > >> 123412341234123412341234123

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Paolo Bonzini
I was thinking of an additional option that would automatically decrease -n so that the requested number of processes is started (then of course the load may not be well balanced). So you mean, rather than the current situation of: $ yes . | head -n13 | xargs -n4 -P2 . . . . . . . . . . . . .

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Pádraig Brady
Paolo Bonzini wrote: > On 10/27/2009 01:16 PM, Pádraig Brady wrote: >> I already suggested to the xargs maintainer that `xargs -P` >> should be equivalent to xargs -P$(nproc). > > I was thinking of an additional option that would automatically decrease > -n so that the requested number of processe

Re: more test suite problems

2009-10-27 Thread Eric Blake
Ian Beckwith erislabs.net> writes: > Debian stable & unstable, i386 & ia64. > > Any of the modules listed in my last mail (or below), for instance this fails: > > $ ./gnulib-tool --create-megatestdir --with-tests --dir=test fseek fwritable > $ cd test/ALL/ > $ ./configure > $ make Aha. I fin

Re: solaris 9: undefined symbol rpl_open

2009-10-27 Thread Eric Blake
Thomas Guyot-Sionnest aei.ca> writes: > # Reproduce by: gnulib-tool --import --dir=. --lib=libgnu > --source-base=gl --m4-base=gl/m4 --doc-base=doc --tests-base=tests > --aux-dir=build-aux --no-libtool --macro-prefix=gl base64 dirname floorf > fsusage getaddrinfo gethostname getloadavg getopt get

Re: enable -Werror for lib/ in coreutils

2009-10-27 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 10/27/2009 6:24 AM: >> + >> + AC_SUBST([GNULIB_WARN_CFLAGS]) >> + GNULIB_WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes >> -Wno-uninitialized -Wno-unused-macros -Wno-old-style-definition" > > Shouldn't this use gl_MANYWARN_COMPLEMENT([var], [$w

Re: enable -Werror for lib/ in coreutils

2009-10-27 Thread Pádraig Brady
Jim Meyering wrote: > Subject: [PATCH 2/2] build (--enable-gcc-warnings): enable gcc's -Werror also > in lib/ > > * configure.ac (GNULIB_WARN_CFLAGS): Define. > * lib/Makefile.am (AM_CFLAGS): Use $(GNULIB_WARN_CFLAGS) > rather than $(WARN_CFLAGS) and add $(WERROR_CFLAGS). > * gl/lib/isnan.c.diff:

Re: enable -Werror for lib/ in coreutils

2009-10-27 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/27/2009 6:24 AM: > + > + AC_SUBST([GNULIB_WARN_CFLAGS]) > + GNULIB_WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes > -Wno-uninitialized -Wno-unused-macros -Wno-old-style-definition" Shouldn't this use gl_MANYWARN_C

enable -Werror for lib/ in coreutils

2009-10-27 Thread Jim Meyering
With these two change sets, ./configure --enable-gcc-warnings && make in builds with most warnings enabled also in lib/. To make that work, I've chosen to disable-in-lib/ some warning options, via -Wno-missing-prototypes -Wno-uninitialized -Wno-unused-macros -Wno-old-style-definition" In

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Paolo Bonzini
On 10/27/2009 01:16 PM, Pádraig Brady wrote: I already suggested to the xargs maintainer that `xargs -P` should be equivalent to xargs -P$(nproc). I was thinking of an additional option that would automatically decrease -n so that the requested number of processes is started (then of course t

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Pádraig Brady
Paolo Bonzini wrote: > Maybe we want a --parallel option (too bad -p is taken) for xargs that > forces the creation of the number of processes passed with -P or taken > from nproc (for example by starting "md5sum $1 $5 $9 ...", "md5sum $2 $6 > $10 ...", etc.)? > That would be an interesting alterna

Re: areadlinkat

2009-10-27 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 10/21/2009 9:33 PM: >>> + * lib/at-func.c (FUNC_FAIL): New define. >>> + (AT_FUNC_NAME, VALIDATE_FLAG): Use it rather than raw -1. >> >> Oops - I missed one instance relating to FUNC_FAIL. test-areadlinkat was >> failing on older Linux, because /p

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Paolo Bonzini
On 10/27/2009 11:55 AM, Pádraig Brady wrote: $ md5sum --threads A B abcdabcdabcdabcdabcdabcdabcdabcd B 12341234123412341234123412341234 A Grr. An argument for_not_ splitting. It is indeed that way. In http://lists.gnu.org/archive/html/bug-coreutils/2009-10/msg00179.html you say

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Pádraig Brady
Pádraig Brady wrote: > Paolo Bonzini wrote: >> >> Of course this should only apply if its effect is not externally >> observable; if I have a very small file B and a very large file A, and I >> can get >> >> $ md5sum --threads A B >> abcdabcdabcdabcdabcdabcdabcdabcd B >> 123412341234123

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Pádraig Brady
Paolo Bonzini wrote: > >>> Some programs, like 'msgmerge' from GNU gettext, already pay >>> attention to the OMP_NUM_THREADS variable - a convention shared >>> by all programs that rely on OpenMP. Can you make the 'sort' >>> program use the same convention? >> >> I am not working on the multi-thre

Re: [PATCH] core-count: A new program to count the number of cpucores

2009-10-27 Thread Pádraig Brady
Bruno Haible wrote: > Pádraig Brady wrote: > >> Hmm it's a bit surprising that min()/max() are not available >> as $((shell arithmetic)) or in `expr`. Consequently I agree that >> adding the option you suggest is useful. > > But min() and max() are available through the 'test' > program or shell

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Paolo Bonzini
Some programs, like 'msgmerge' from GNU gettext, already pay attention to the OMP_NUM_THREADS variable - a convention shared by all programs that rely on OpenMP. Can you make the 'sort' program use the same convention? I am not working on the multi-threaded sort, but if somebody asks I can mak

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Giuseppe Scrivano
Hi Bruno, Bruno Haible writes: >> No, it should not be a hardware inspection tool but a portable >> tool to help shell scripts to have an idea of how many >> processes can be executed at the same time. If we get too >> much into details then we loose portability > > Good. This is important info