Fix a linker error when used by a C++ program

2009-10-18 Thread Giuseppe Scrivano
I am going to use gnulib in a C++ program. This is the first problem I encountered. Cheers, Giuseppe >From 27c9d4725bfb95915c98644e12f5e5d7818a19aa Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Mon, 19 Oct 2009 01:56:20 +0200 Subject: [PATCH] Fix a linker error when used by a C++ prog

Re: ctype functions with char argument

2009-10-18 Thread Bruno Haible
Hi Eric, > Can we go ahead and make the replacement ctype.h catch additional bugs, by > rewriting the various ctype macros to cause gcc -Wall warnings when passed > a char (rather than int or unsigned char)? Gnulib is not the right place for implementing this kind of warnings: 1. because the nu

Re: new module ctype

2009-10-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 10/18/2009 1:52 PM: > Here is the 'ctype' module: > > 2009-10-18 Bruno Haible > > New module 'ctype'. > * lib/ctype.in.h: New file. > * m4/ctype.m4: New file. > * modules/ctype: New file. >

Re: How to get isblank?

2009-10-18 Thread Reuben Thomas
You star, Bruno!

Re: How to get isblank?

2009-10-18 Thread Bruno Haible
Here comes the documentation for isblank and the other ctype.h functions. 2009-10-18 Reuben Thomas Bruno Haible * doc/posix-functions/isascii.texi: Document the 2 alternative APIs. * doc/posix-functions/isalnum.texi: Document the 4 alternative APIs. * doc/

new module isblank

2009-10-18 Thread Bruno Haible
Here comes the 'isblank' module: 2009-10-18 Bruno Haible New module 'isblank'. * lib/isblank.c: New file. * m4/isblank.m4: New file. * modules/isblank: New file. * doc/posix-functions/isblank.texi: Mention the new module. ===

new module ctype

2009-10-18 Thread Bruno Haible
Here is the 'ctype' module: 2009-10-18 Bruno Haible New module 'ctype'. * lib/ctype.in.h: New file. * m4/ctype.m4: New file. * modules/ctype: New file. * doc/posix-headers/ctype.texi: Mention the new module. === lib/ctype.in.

Re: How to get isblank?

2009-10-18 Thread Bruno Haible
Reuben Thomas wrote: > 2009/10/7 Eric Blake : > > Can we add a summary of this logic to the isblank.texi documentation, to > > point people to better replacements? > > Proposed patch: > > diff --git a/doc/posix-functions/isblank.texi > b/doc/posix-functions/isblank.texi > index 2547793..a4924c7

Re: use of AC_SUBST

2009-10-18 Thread Bruno Haible
Jim Meyering wrote: > My impression is that the traditional style makes it so the initialization > and AC_SUBST *textually* bracket all uses of the variable. When they > do not (as induced by your patch), it's less valuable, and perhaps even > obtuse, since the other assignment is in a separate au

Re: use of AC_SUBST

2009-10-18 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> your patch was already moving the AC_SUBST use, >> which was technically unnecessarily. > > Huh? There is a 'case' statement in gl_GETHRXTIME. If the user had > set LIB_GETHRXTIME as an environment variable and the first alternative > of the 'case' state

Re: use of AC_SUBST

2009-10-18 Thread Bruno Haible
Jim Meyering wrote: > your patch was already moving the AC_SUBST use, > which was technically unnecessarily. Huh? There is a 'case' statement in gl_GETHRXTIME. If the user had set LIB_GETHRXTIME as an environment variable and the first alternative of the 'case' statement was chosen, the value prop

Re: use of AC_SUBST

2009-10-18 Thread Jim Meyering
Bruno Haible wrote: >> > Likewise with LIB_GETHRXTIME. How about this proposed fix? >> >> Good catch. > > Patch applied. > >> However, please make these two lines adjacent: >> (pulling the AC_SUBST "up") >> ... >> I nearly moved the AC_SUBST lines in the changes I made recently, >> but opted not to

Re: use of AC_SUBST

2009-10-18 Thread Bruno Haible
Hi Jim, > > Likewise with LIB_GETHRXTIME. How about this proposed fix? > > Good catch. Patch applied. > However, please make these two lines adjacent: > (pulling the AC_SUBST "up") > ... > I nearly moved the AC_SUBST lines in the changes I made recently, > but opted not to: I didn't want to mix

Re: [PATCH] don't let environment settings perturb build

2009-10-18 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> Setting the envvars, LIB_CLOCK_GETTIME, LIB_EACCESS or LIB_NANOSLEEP >> could cause a configure-time and/or build-time malfunction. > > Likewise with LIB_GETHRXTIME. How about this proposed fix? Good catch. However, please make these two lines adjacent:

localcharset: fix security problem

2009-10-18 Thread Bruno Haible
This fixes a possible symlink attack in localcharset module. The security hole was probably small, but that's not a reason for not making it even smaller. 2009-10-18 Bruno Haible Avoid symlink attack in localcharset module. * lib/localcharset.c: Include , . (O_NOFOLLOW

Re: [PATCH] don't let environment settings perturb build

2009-10-18 Thread Bruno Haible
Jim Meyering wrote: > Setting the envvars, LIB_CLOCK_GETTIME, LIB_EACCESS or LIB_NANOSLEEP > could cause a configure-time and/or build-time malfunction. Likewise with LIB_GETHRXTIME. How about this proposed fix? 2009-10-17 Bruno Haible * m4/gethrxtime.m4 (gl_GETHRXTIME): Initialize L

nproc: port to mingw

2009-10-18 Thread Bruno Haible
And this finally adds mingw support to the nprocs module. Quite trivial once you have found out which Win32 function to use (GetLogicalProcessorInformation? NtQuerySystemInformation? GetSystemInfo?). 2009-10-18 Bruno Haible Implement nproc for mingw. * lib/nproc.c: Include

Re: nproc: use pstat_getdynamic when it is available.

2009-10-18 Thread Bruno Haible
And this adds support for IRIX to the nproc module. Untested. Testing is welcome. 2009-10-18 Bruno Haible Implement nproc for IRIX. * lib/nproc.c: Include . (num_processors): On IRIX systems, try sysmp. * m4/nproc.m4 (gl_PREREQ_NPROC): Check for sys/sysmp.h and

nproc: use pstat_getdynamic when it is available.

2009-10-18 Thread Bruno Haible
And this adds support for HP-UX to the nproc module. 2009-10-18 Bruno Haible Implement nproc for HP-UX. * lib/nproc.c: Include (num_processors): On HP-UX systems, try pstat_getdynamic. * m4/nproc.m4 (gl_PREREQ_NPROC): Check for sys/pstat.h and pstat_ge

Re: [PATCH] nproc: use `sysctl' when it is available.

2009-10-18 Thread Bruno Haible
Hi, Giuseppe Scrivano wrote: > On BSDs, where SC_NPROCESSORS_ONLN is not available, the number of > online processors can be retrieved using `sysctl'. > > From 73c11226e320c1144887daeb15e3f549b0bb2ee5 Mon Sep 17 00:00:00 2001 > From: Giuseppe Scrivano > Date: Sun, 18 Oct 2009 01:20:14 +0200 > Su

physmem: fix recognition of sys/sysctl.h

2009-10-18 Thread Bruno Haible
On OpenBSD 4.0, #include fails if was not included previously. This fixes the recognition of : 2009-10-18 Bruno Haible Fix recognition of sys/sysctl.h on OpenBSD 4.0. * m4/physmem.m4 (gl_PHYSMEM): Before including sys/sysctl.h, include sys/param.h. *** m4/physmem.m4