Re: make lchmodat friendlier

Eric Blake wrote: > Jim, what do you think of this patch, so that lchmodat only fails with > ENOSYS when called on a symlink (when called on other file types, it would > now succeed)? > > Also, should "openat.h" provide shortcuts named: > > accessat() => faccessat(,0) > euidaccessat() => faccessat(

make lchmodat friendlier

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim, what do you think of this patch, so that lchmodat only fails with ENOSYS when called on a symlink (when called on other file types, it would now succeed)? Also, should "openat.h" provide shortcuts named: accessat() => faccessat(,0) euidaccessat(

Re: make openat declarations consistent

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/6/2009 3:14 PM: > Additionally, this patch fixes a bug: gl_FUNC_OPENAT did not AC_REQUIRE > gl_OPENAT_DEFAULTS. So it could happen that gl_FUNC_OPENAT gets expanded > before gl_UNISTD_H_DEFAULTS, and then the variable GNU

Re: make openat declarations consistent

Eric Blake wrote: > > OK to apply? > > Yes, please. Applied and pushed. Bruno

Re: make openat declarations consistent

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/6/2009 3:14 PM: > No, really, all macros needed for constructing the replacement > are supposed to sit in m4/unistd_h.m4. Good argument. > Another plus is that it separates the blocks for different functions in > unist

Re: make openat declarations consistent

Eric Blake wrote: > So we only need the > AC_SUBST (provided by gl_OPENAT_DEFAULTS), not the AC_DEFINE (provided by > gl_MODULE_INDICATOR). Yes, okay to make that change. Done: 2009-09-06 Bruno Haible * modules/openat (configure.ac): Remove unneeded witness. --- modules/openat.orig

Re: make openat declarations consistent

Eric Blake wrote: > --- a/modules/unistd > +++ b/modules/unistd > @@ -4,6 +4,7 @@ A GNU-like . >  Files: >  m4/unistd_h.m4 >  lib/unistd.in.h > +m4/openat.m4 So every package that needs now needs to include a file named openat.m4? It we had gone this route, the generation of would now depend on

Re: mingw test cleanups

Eric Blake wrote: > But my shortcut > is generally adequate enough to shave time and limp by with a single step > instead of two (it is already time-consuming enough to use gnulib-tool on > cygwin, due to slow forks). gnulib-tool is there to make your life easier. So, you would probably like it to

coreutils snapshot in ~10 hours

I think coreutils is ready for its pre-7.6 snapshot and expect to make that tomorrow morning. I hope to be able to use the latest from gnulib for that. If you have doubts, or if you know of parts that are not quite ready, please let me know. Thanks, Jim

Re: mingw test cleanups

Eric Blake wrote: > > EOPNOTSUPP is an error code related to sockets. I also see it sometimes on > > NFS mounts. POSIX [1] describes it as "Operation not supported on socket". > > Probably ENOSYS ("Function not supported.") is a better error code. > > ENOSYS does make more sense (even though POSIX

Re: make openat declarations consistent

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/6/2009 2:22 PM: > Eric Blake wrote: >> configure.ac: >> gl_FUNC_OPENAT >> +gl_MODULE_INDICATOR([openat]) > > This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C > preprocessor macro anywhere in lib/,

Re: make openat declarations consistent

Eric Blake wrote: >  configure.ac: >  gl_FUNC_OPENAT > +gl_MODULE_INDICATOR([openat]) This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C preprocessor macro anywhere in lib/, nor in coreutils. So I propose to remove this unneeded witness. Bruno

Re: make openat declarations consistent

I'm adding this doc tweak and indentation fix: 2009-09-06 Bruno Haible * doc/posix-headers/fcntl.texi (AT_*): Mention affected platforms. * lib/sys_stat.in.h: Fix preprocessor command indentation. --- doc/posix-headers/fcntl.texi.orig 2009-09-06 21:37:44.0 +0200 +++

Re: mingw test cleanups

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/6/2009 11:27 AM: >> $ cross_compiling=yes gl_cv_func_open_slash=no CC='gcc -mno-cygwin' \ >>CFLAGS='-Wall -gdwarf-2' ./gnulib-tool --with-tests --test canonicalize >> ... >> for the situation where AC_CANONICAL_HOST i

Re: fix bug in glibc 2.7 macro implementation of strtok_r.

Bruno Haible writes: > Ben Pfaff wrote: >> This works around a bug in the glibc 2.7 macro implementation of >> strtok_r described here: >> http://sources.redhat.com/bugzilla/show_bug.cgi?id=5614. > > Thanks. I've done the following modifications to your patch: [...] Wow! I was planning to keep

Re: mingw test cleanups

Hi Eric, > I will be pushing these later today as prerequisites to fixing fchdir and > splitting fdopendir into its own module. This series avoids some compilation > warnings due to missing chmod on mingw, and allows me to run gnulib > testsuites > under cygwin while cross-compiling to mingw:

Re: fix bug in glibc 2.7 macro implementation of strtok_r.

Ben Pfaff wrote: > This works around a bug in the glibc 2.7 macro implementation of > strtok_r described here: > http://sources.redhat.com/bugzilla/show_bug.cgi?id=5614. Thanks. I've done the following modifications to your patch: - Choose a macro name that is more similar to the current gnulib

Re: lib/exclude.c calls towlower() without checking for wideline support

Bruno Haible ha escrit: > Like Solaris 2.5.1 and IRIX 5.3, you mean? This should do it. Thanks, Bruno! Regards, Sergey

Re: bootstrap: improve find_tool

Akim Demaille wrote: > Hi Friends, > > This makes Bison's and gnulib's bootstraps more alike. Hi Akim! Thanks. I've pushed that with a couple comment tweaks.