Re: update-copyright local hook

2009-08-17 Thread Joel E. Denny
Hi Eric and Jim. On Sat, 15 Aug 2009, Eric Blake wrote: > According to Jim Meyering on 8/15/2009 2:37 AM: > >> It changed a bit due to the merge; here's what I'm pushing. > > I haven't pushed yet, in case we decide something different... > > > ... > >>grep -l -w Copyright $$($(VC_LIST_EXCEP

popen bugs, popen_safer

2009-08-17 Thread Eric Blake
Even though Bruno's pipe module is generally a better interface than popen, I discovered yet another popen bug in cygwin today[1] (I fixed a cygwin popen bug in August 2006, only to have it regress in December of that year when cgf rewrote the implementation to be faster). So even though m4 no lo

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Paolo Bonzini
Or is it something that can only be detected with valgrind? Only valgrind, because the second sigaction will also fail and -1 will be returned. Paolo

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Eric Blake
> > If others agree that adding this crutch is worthwhile > > Yes, I'm in favour of this new module. Just because a module is present doesn't mean I have to use it; so I am not opposed to adding the module now that others have expressed interest in in (the note in posix-functions/siginterrupt.te

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Bruno Haible
Eric Blake wrote: > If others agree that adding this crutch is worthwhile Yes, I'm in favour of this new module. 'siginterrupt' was already considered obsolete in 1993 or so, as I remember from discussions with H.J. Lu at that time. But Simon's module is so clear, small, self-contained, that I see

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Paolo Bonzini
On 08/17/2009 05:57 PM, Simon Josefsson wrote: Eric Blake writes: It fails to build on IRIX 5.3 due to missing siginterrupt function: ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by tests.o. Since gnulib does not provide a siginterrupt replacement I instead added the

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Simon Josefsson
Eric Blake writes: >> > It fails to build on IRIX 5.3 due to missing siginterrupt function: >> > ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by >> > tests.o. >> > >> > Since gnulib does not provide a siginterrupt replacement I instead added >> > the replacement used by b

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Paolo Bonzini
+int +siginterrupt (int sig, int flag) +{ + struct sigaction act; + + if (sigaction (sig, NULL,&act)< 0) +return -1; POSIX ignores sigaction failure here, rather than returning -1. In practice the only difference is that for EINVAL the POSIX version will cause spurious valgrind failur

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Eric Blake
> > It fails to build on IRIX 5.3 due to missing siginterrupt function: > > ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by > > tests.o. > > > > Since gnulib does not provide a siginterrupt replacement I instead added > > the replacement used by bash 4.0 to tests.c: > > T

Re: Buildreport for GnuTLS 2.8.3

2009-08-17 Thread Simon Josefsson
"Tom G. Christensen" writes: > It fails to build on IRIX 5.3 due to missing siginterrupt function: > ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by > tests.o. > > Since gnulib does not provide a siginterrupt replacement I instead added > the replacement used by bash 4.0