Re: [PATCH] tests: avoid warnings due to implicit declaration of memset

Bruno Haible wrote: > Jim Meyering wrote: >> Ok to push this fix? >> >> +* tests/test-select-stdin.c: Include for decl of memset, > > No. test-select-stdin.c does not use memset(), therefore there is no reason > for this file to include . > > The memset() call that the warnings refers to come

Re: [PATCH] Exclude optimization

Hello Sergey, > The proposed patch considerably speed-ups the exclude module > for large exclusion lists of non-wildcard patterns. Great idea! 'is_fnmatch_pattern' is probably a misnomer, because its argument is by definition already an fnmatch pattern. What the function is testing is whether it

Re: [PATCH] tests: avoid warnings due to implicit declaration of memset

Jim Meyering wrote: > Ok to push this fix? > > + * tests/test-select-stdin.c: Include for decl of memset, No. test-select-stdin.c does not use memset(), therefore there is no reason for this file to include . The memset() call that the warnings refers to comes from an FD_ZERO expansion. The

[PATCH] Exclude optimization

Hello, The proposed patch considerably speed-ups the exclude module for large exclusion lists of non-wildcard patterns. Ok to push? >From 5421774438de3a67d89f988a0cd735e19a4cafd4 Mon Sep 17 00:00:00 2001 From: Sergey Poznyakoff Date: Mon, 10 Aug 2009 00:14:45 +0300 Subject: [PATCH] Optimize excl

[PATCH] tests: avoid warnings due to implicit declaration of memset

Hi Bruno, Building coreutils on Solaris 10, I saw these two warnings: test-select-fd.c: In function 'main': test-select-fd.c:47: warning: implicit declaration of function 'memset' test-select-fd.c:47: warning: incompatible implicit declaration of built-in function 'memset' CCLD test-

avoid warnings from 'aclocal'

This snippet from modules/error m4_ifdef([AM_XGETTEXT_OPTION], [AM_XGETTEXT_OPTION([--flag=error:3:c-format]) AM_XGETTEXT_OPTION([--flag=error_at_line:5:c-format])]) can lead to warnings by 'aclocal'. Ralf Wildenhues kindly explained the cause of the problem [1]. It's not a problem in

Re: no-c++

Sam Steingold wrote in : > my suggestion eliminates two expensive steps: > > now: > > import the non-C++ module > regenerate all autoconf files > try to compile with c++, fail > import no-c++ > regenerate all autoconf files > add

Re: gettimeofday in c++

Jim Meyering wrote: > While I don't like adding casts, in this case, > (accommodating C++) there is no alternative. Agreed. Applied and pushed. Bruno