fchown-stub.c not pulled in for DJGPP 2.03p2

2009-07-21 Thread Rugxulo
Hey, I'm really not trying to be a pest, honest, but I personally still use DJGPP (on Vista, XP, and real DOS [MS- / DR- / Free-], even). DJGPP still hasn't ever finished the final 2.04, so it's stuck at beta. Hence the DJGPP guys still port stuff to both 2.03p2 and 2.04. DJGPP 2.04 beta does ha

Re: new module pipe-filter

2009-07-21 Thread Paolo Bonzini
> Your proposal is more general, but still assumes that > - the control structure of the reader is simple. This is what Bison requires. Actually Bison's reader is complex, buy the output is fed to a Flex scanner, which takes care of the complexity. > A symmetrical proposal could be done for t

Re: new module pipe-filter

2009-07-21 Thread Bruno Haible
Hi Paolo, Thanks for the comments! > I don't like very much the design of this module. The problem is that > it requires excessive effort on the child's part to buffer writes and/or > to prepare all of the filter's input upfront. You mean, on the parent's part, I guess? (The module's goal is

Re: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when included from C++

2009-07-21 Thread Peter Simons
Hi Jim, > Would you please adjust that patch to do the same for all lib/sha*.h > files as well as lib/md5.h, and (if Simon agrees) lib/md[24].h? sure, the updated patch is attached below. Take care, Peter >From 98e9105fa23067d396f25beb8406cfe407de469d Mon Sep 17 00:00:00 2001 From: Peter Sim

Re: [PATCH] vc-list-files: avoid failure when /bin/sh is dash

2009-07-21 Thread Eric Blake
Jim Meyering meyering.net> writes: > That is because bash and dash work differently: > $ for i in bash dash; do $i -c 'a=odd; a=ok b=$a; echo '$i' $b'; done > bash ok > dash odd Good catch. And yes, this is already documented in the autoconf manual on shell portability; the order of assi

[PATCH] vc-list-files: avoid failure when /bin/sh is dash

2009-07-21 Thread Jim Meyering
I've just pushed the following. It fixes a nasty little portability problem: >From 7c385af22c99df5eceda1e82d7aa595e6d5cb796 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 21 Jul 2009 18:24:22 +0200 Subject: [PATCH] vc-list-files: avoid failure when /bin/sh is dash * build-aux/vc-list-fil

Re: dup2 on mingw

2009-07-21 Thread Eric Blake
Eric Blake byu.net> writes: > Well, it would be nice if doing that didn't hang mingw. It looks like > Microsoft has a bug, because using dup2(fd,fd) when fd is closed appears to > deadlock the process. mingw also hangs on the second dup2 in dup2(fd,fd),dup2(fd,fd+1) if fd is open (meaning th

Re: dup2 on mingw

2009-07-21 Thread Eric Blake
Eric Blake byu.net> writes: > > Yes, that's definitely a portability pitfall that warrants a wrapper module. > > And in writing the testcase, I learned that cygwin 1.5 also has a bug, in > that dup2(1,1) returns 0 (but at least cygwin's dup2(1,2) returns 2). > Although you seldom see code using

Re: dup2 on mingw

2009-07-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 7/20/2009 6:00 PM: > Eric Blake wrote: >> On mingw, dup2 always returns 0 for success, rather than the fd just opened. >> So I guess I'll start the process of writing a dup2 replacement module; > > Yes, that's definitely a

Re: new module pipe-filter

2009-07-21 Thread Paolo Bonzini
On 07/20/2009 01:22 AM, Bruno Haible wrote: Eric Blake wrote: Such piping, where you write from the current process and read into the current process, may hang on BSD systems, because some data is present in system buffers but the system wants the buffers to be full before it continues. A fix fo

Re: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when included from C++

2009-07-21 Thread Jim Meyering
Peter Simons wrote: >>From 640f2ed9570eef3189e43ec7550b32776fdebd0f Mon Sep 17 00:00:00 2001 > From: Peter Simons > Date: Sun, 19 Jul 2009 18:25:44 +0200 > Subject: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when > included from C++ > > +#ifdef __cplusplus > +extern "C" { > +#endif

Re: overly zealous git hook

2009-07-21 Thread Jim Meyering
Bruno Haible wrote: > # "git diff --check" should not reject modules files which end in a blank > line. > * whitespace=-trail > === > > But "git push" is now still rejected: > > modules/pipe-filter:34: ends with blank li

Re: overly zealous git hook

2009-07-21 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> Actually, I see trailing blank lines in any text file >> as an opportunity for unexpected merge conflicts, as >> one person adds or removes one of those oft-unnoticed lines, >> and someone else makes a conflicting change. > > Conflicts generally occur at spots th

Re: overly zealous git hook

2009-07-21 Thread Bruno Haible
Hi Jim, > > FYI, this change in behavior is the result of savannah upgrading to > > the latest version of git, whose git diff --check tests for that. Thanks for the pointer. Indeed, the relevant git changes are: http://git.kernel.org/?p=git/git.git;a=commitdiff;h=877f23ccb88227203f2576abdfb5d1c15