Re: New module argp-version-etc

2009-06-26 Thread Paolo Bonzini
With Bruno's approach, a public function must have *no* spec just before its definition, while each private one does. That also depends on whether you insist on prototypes for all static functions. In that case, that's the place for specs of private functions, and *no* function has a spec bef

Re: [PATCH] do not use GIT_CONFIG_LOCAL

2009-06-26 Thread Paolo Bonzini
Yep, I did something similar for coreutils some time ago. git_modules_config () { GIT_CONFIG=.gitmodules git config "$@" } Do you know if one is more portable than the other? It's the same. --file was introduced in September 2007 (v.1.5.3), the same release that introduced su

definition of NULL

2009-06-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Any objections to this patch? I know that Solaris 10 still uses the following, which meets C99 and POSIX 2001 but is non-compliant with POSIX 2008: #ifndef NULL #if defined(_LP64) #define NULL0L #else #define NULL0 #endif #endif But I can't

Re: New module argp-version-etc

2009-06-26 Thread Bruno Haible
Paolo Bonzini wrote: > > With Bruno's approach, a public function must > > have *no* spec just before its definition, while each private one does. > > That also depends on whether you insist on prototypes for all static > functions. In that case, that's the place for specs of private > function

Re: New module argp-version-etc

2009-06-26 Thread Bruno Haible
Hi Jim, Thanks for your understanding. > It's not a big deal for me, now that I'm used to seeing no documentation > in gnulib's .c files for certain public functions, but it still does rankle > a little, each time I notice. Well, for me, it's the opposite: I start boiling a bit, each time I see

Re: New module argp-version-etc

2009-06-26 Thread Jim Meyering
Eric Blake wrote: ... > I will be checking in this patch, if no one else beats me to it. Thanks! Next time I'll build with coreutils before saying "ok".

Re: [PATCH] do not use GIT_CONFIG_LOCAL

2009-06-26 Thread Jim Meyering
Paolo Bonzini wrote: > "Despite being doucmented, I can't find any sign that it was ever used." > (git commit dc87183). Doh. > > Bison should be updated, for the other projects I know the maintainers > are listening on bug-gnulib. :-) > > Paolo > > 2009-06-26 Paolo Bonzini > > * autoboo

[PATCH] do not use GIT_CONFIG_LOCAL

2009-06-26 Thread Paolo Bonzini
"Despite being doucmented, I can't find any sign that it was ever used." (git commit dc87183). Doh. Bison should be updated, for the other projects I know the maintainers are listening on bug-gnulib. :-) Paolo 2009-06-26 Paolo Bonzini * autoboot: Do not use GIT_CONFIG_LOCAL. di