Re: gettime build failure with recent gnulib for mingw systems

On Friday 19 June 2009 17:47:27 Bruno Haible wrote: > lib/timespec.h includes , which is supposed to define 'struct > timespec'. > > The config.log that you sent contains > SYS_TIME_H_DEFINES_STRUCT_TIMESPEC='0' > TIME_H_DEFINES_STRUCT_TIMESPEC='0' > These two definitions together should ensure

Re: gettime build failure with recent gnulib for mingw systems

Mike Frysinger wrote: > i upgraded gnulib in a project recently and started getting failures in > gettime.c when building with a mingw32 toolchain On the other hand, a gnulib testdir, created through ./gnulib-tool --create-testdir --dir=$HOME/data/tmp/testdir8 --with-tests gettime builds fine o

[PATCH] hash: reverse order of src/dst parameters in an internal interface

No semantic change: >From 5082839d34680c5dea88d3b65f021805b963c04d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 19 Jun 2009 18:49:24 +0200 Subject: [PATCH] hash: reverse order of src/dst parameters in an internal interface * lib/hash.c (transfer_entries): Reverse order of parameters t

Re: another hash cleanup

Jim Meyering wrote: > Eric Blake wrote: > ... >> Done. And with that on master, I've rebased my hash_rehash memory leak plug: >> >> http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash >> $ git pull git://repo.or.cz/gnulib/ericb.git hash > > Thanks. I've just started looking, and one

[PATCH] tests: test-hash: avoid wholesale duplication

FYI, I've just pushed this no-semantic-change patch: diff --git a/ChangeLog b/ChangeLog index 876467c..16cbdbc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2009-06-19 Jim Meyering + tests: test-hash: avoid wholesale duplication + * tests/test-hash.c (main): Don't copy/pa

[PATCH] tests: test-hash: allow seed selection via a command line argument

FYI, just pushed: >From 8b7595fca68a6f6514fe0e29bbe646ccab3ffd77 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 19 Jun 2009 16:56:48 +0200 Subject: [PATCH] tests: test-hash: allow seed selection via a command line argument * tests/test-hash.c (get_seed): New function. (main): Use it. --

Re: another hash cleanup

Jim Meyering meyering.net> writes: > > http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash > > $ git pull git://repo.or.cz/gnulib/ericb.git hash > > By the way, in this change set, > > http://repo.or.cz/w/gnulib/ericb.git?a=commitdiff;h=bf740889e7ca68be9e > fake memory failure

Re: another hash cleanup

Eric Blake wrote: ... > Done. And with that on master, I've rebased my hash_rehash memory leak plug: > > http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash > $ git pull git://repo.or.cz/gnulib/ericb.git hash Thanks. I've just started looking, and one thing struck me: +static

Re: another hash cleanup

Eric Blake wrote: > According to Jim Meyering on 6/19/2009 7:06 AM: >> Looks good, but I haven't tested. >> Ok, presuming you have. > > Yes, I reran test-hash.c, as well as the m4 testsuite, using this version. > >> >> One minor suggested change: >> >> Please combine the declaration and assignment:

Re: another hash cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 6/19/2009 7:06 AM: > Looks good, but I haven't tested. > Ok, presuming you have. Yes, I reran test-hash.c, as well as the m4 testsuite, using this version. > > One minor suggested change: > > Please combine the declarat

Re: another hash cleanup

Eric Blake wrote: > According to Jim Meyering on 6/19/2009 6:02 AM: >>> But, come to think of it, why are we even malloc'ing the new_table at all >>> in this code path? Maybe the better technical approach would be factoring >>> out the table size computation from hash_initialize, and have both >>>

Re: another hash cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 6/19/2009 6:02 AM: >> But, come to think of it, why are we even malloc'ing the new_table at all >> in this code path? Maybe the better technical approach would be factoring >> out the table size computation from hash_initi

[PATCH] tests: make sc_require_test_exit_idiom more generic

I wanted to use this test from vc-dwim, too. It defines the Exit function in a file not named test-lib.sh. Here's what I've done to accommodate that. An alternative is to eliminate the witness file altogether and to search tests/ (aka, $(dir $(Exit_witness_file))) for a definition of Exit, e.g., v

Re: another hash cleanup

Eric Blake wrote: > According to Jim Meyering on 6/19/2009 1:19 AM: >> However, I have a slight preference for this, since it leaves us >> with less duplication of implementation-specific details: >> >> if (new_table->n_buckets == table->n_buckets) >> { >> hash_free (new_table); >>

Re: another hash cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 6/19/2009 1:19 AM: > However, I have a slight preference for this, since it leaves us > with less duplication of implementation-specific details: > > if (new_table->n_buckets == table->n_buckets) > { > hash_fre

Re: another hash cleanup

Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> > Aargh. Ten minutes after I push, I finally see my memory leak. >> > >> > Obviously, new_table needs to be freed before returning true. >> >> Hah! I should have looked at more than the patch. >> >> Is that code path already exercised b