Re: [PATCH] Add ability to print ACL's from ls

2009-05-28 Thread David Bartley
On Sun, May 10, 2009 at 6:32 AM, James Youngman wrote: > On Sat, May 9, 2009 at 11:59 AM, David Bartley > wrote: > >> I considered this. There are at least 3 different variants of ACL's >> (POSIX, NFSv4 and MacOS X) and they are generally incompatible. UMich >> created patches to acl/libacl so th

Re: [PATCH] New fallocate module

2009-05-28 Thread Pádraig Brady
Pádraig Brady wrote: > Bruno Haible wrote: >> >> The return value convention described in >> http://www.kernel.org/doc/man-pages/online/pages/man2/fallocate.2.html >> is a different one. Either this code or that man page is wrong. > > I don't follow. Both return int. ENOSYS to me means it can't

Re: [PATCH] New fallocate module

2009-05-28 Thread Pádraig Brady
Bruno Haible wrote: > Pádraig Brady wrote: >> Take 2 attached. > > Take 2 review: > >> +#ifdef REPLACE_FALLOCATE > > The generated fcntl.h should be maximally standalone. Can you better use > #if @REPLACE_FALLOCATE@ and use an AC_SUBSTed variable REPLACE_FALLOCATE > instead of one defined in con

Re: [PATCH] New fallocate module

2009-05-28 Thread Bruno Haible
Pádraig Brady wrote: > Take 2 attached. Take 2 review: > +#ifdef REPLACE_FALLOCATE The generated fcntl.h should be maximally standalone. Can you better use #if @REPLACE_FALLOCATE@ and use an AC_SUBSTed variable REPLACE_FALLOCATE instead of one defined in config.h? > +# undef fallocate Why the

Re: [PATCH] gnulib-tool: Transform license on build-aux/ files too.

2009-05-28 Thread Bruno Haible
Simon Josefsson wrote: > This patch allows gnulib-tool to be able to change the license from > GPLv2 to GPLv3 just like it can already do for lib/* files. Thanks. Twiddling with '#ifdef HAVE_CONFIG_H' is however not needed on build-auc/* files, so I'm applying this: 2009-05-28 Bruno Haible

[PATCH] gnulib-tool: Transform license on build-aux/ files too.

2009-05-28 Thread Simon Josefsson
The file build-aux/gnupload was recently modified to use GPLv2 instead of GPLv3 in gnulib, but I'd like to use GPLv3 on it for consistency. This patch allows gnulib-tool to be able to change the license from GPLv2 to GPLv3 just like it can already do for lib/* files. Pushed. /Simon --- ChangeLo

Re: [PATCH] New fallocate module

2009-05-28 Thread Pádraig Brady
Eric Blake wrote: > According to Pádraig Brady on 5/27/2009 10:20 AM: >> Take 2 attached. > >> Still outstanding from the gnulib portion is support for solaris. >> I may get time to set this up, but I've very little time lately, >> so I would like not to require this for merging. > > That seems l