Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan Hourihane wrote: > Attached are the freading.c and fwriting.c patches to make them pass. Thanks. I've committed it like this: 2009-02-28 Bruno Haible More support for FreeMiNT. * lib/freading.c (freading) [__MINT__]: Use new macros that were added to FreeMiNT tod

Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan Hourihane wrote: > > > > --- lib/fflush.c.orig 2009-02-28 21:09:16.0 +0100 > > > > +++ lib/fflush.c2009-02-28 21:01:40.0 +0100 > > > > @@ -63,6 +63,12 @@ > > > > } > > > > # elif defined _IOERR /* AIX, HP-UX, IRIX, OSF/1, > > > > Solaris, OpenServ

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

Alan Hourihane wrote: + fp->__pushback_bufp = 0; + if (fp->__mode.__write) +fp->__put_limit = fp->__buffer; + fp->__bufp = fp->__get_limit; I don't think the last statement is right. The purpose of fpurge, on the read side, is to empty the buffer, i.e. drop all read contents. I do agree tha

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Bruno, So I can see the test patches applied in git HEAD. If I take that code and apply the attached conglomeration patch, then all the tests pass. Alan. diff --git a/lib/fflush.c b/lib/fflush.c index 3b17655..9f75ccd 100644 --- a/lib/fflush.c +++ b/lib/fflush.c @@ -63,12 +63,6 @@ clear_unget

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sun, 2009-03-01 at 01:34 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > > I know. It's a kernel issue that needs dealing with > > OK, if you already know it's a kernel issue, it's certainly not a problem > caused by your proposed ftello / fseek... patches. So I'm applying your patch: You

Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan Hourihane wrote: > I know. It's a kernel issue that needs dealing with OK, if you already know it's a kernel issue, it's certainly not a problem caused by your proposed ftello / fseek... patches. So I'm applying your patch: 2009-02-28 Bruno Haible * tests/test-freadseek.c (main)

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 16:40 -0700, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Alan Hourihane on 2/28/2009 4:31 PM: > >> I'll change things around now. > > > > The above is a little unfair as FreeMiNT has problems seeking beyond the > > end of stdin, so I

Re: [patch #6758] Add support for Atari FreeMiNT OS

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Alan Hourihane on 2/28/2009 4:31 PM: >> I'll change things around now. > > The above is a little unfair as FreeMiNT has problems seeking beyond the > end of stdin, so I had to modify the test to remove that final check. Unfair or not, PO

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 22:33 +, Alan Hourihane wrote: > On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote: > > Hi Alan, > > > > > I see this has already landed in git, so let me know how you want to > > > handle any updates. > > > > Can you please take the current gnulib (git HEAD), execut

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sun, 2009-03-01 at 00:17 +0100, Bruno Haible wrote: > Alan, > > + fp->__pushback_bufp = 0; > + if (fp->__mode.__write) > +fp->__put_limit = fp->__buffer; > + fp->__bufp = fp->__get_limit; > > Can you explain me something? I thought the following invariants should > always hold: > fp->

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote: > > > --- lib/fflush.c.orig 2009-02-28 21:09:16.0 +0100 > > > +++ lib/fflush.c 2009-02-28 21:01:40.0 +0100 > > > @@ -63,6 +63,12 @@ > > > } > > > # elif defined _IOERR /* AIX, HP-UX, IRIX, OSF/1, Solaris

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 22:51 +0100, Bruno Haible wrote: > Alan, > > > Just getting back to the fseeko() test. What exactly is meant to be > > tested here ? > > This conditional means to test whether the last call was an fflush(), i.e. > whether no I/O was done on the stream since the last fflush()

Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan, + fp->__pushback_bufp = 0; + if (fp->__mode.__write) +fp->__put_limit = fp->__buffer; + fp->__bufp = fp->__get_limit; Can you explain me something? I thought the following invariants should always hold: fp->__get_limit >= fp->__bufp fp->__put_limit >= fp->__bufp But after these a

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Bruno, Attached are the freading.c and fwriting.c patches to make them pass. Alan. diff --git a/lib/fwriting.c b/lib/fwriting.c index b7fa455..ba05e65 100644 --- a/lib/fwriting.c +++ b/lib/fwriting.c @@ -41,10 +41,9 @@ fwriting (FILE *fp) return ((fp->_Mode & 0x1 /* _MOPENR */) == 0 ||

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Bruno, Patch to fix fpurge.c. fpurge test now passes. Alan. diff --git a/lib/fpurge.c b/lib/fpurge.c index 0e2931e..d54e80f 100644 --- a/lib/fpurge.c +++ b/lib/fpurge.c @@ -115,14 +115,10 @@ fpurge (FILE *fp) fp->_Rend = fp->_Next; return 0; # elif defined __MINT__ /* Ata

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote: > Hi Alan, > > > I see this has already landed in git, so let me know how you want to > > handle any updates. > > Can you please take the current gnulib (git HEAD), execute the tests in > the way I mentioned, show us the test failures (with l

Re: vc-list-files-cvs failure?

* Jim Meyering wrote on Wed, Feb 18, 2009 at 09:40:25AM CET: > Simon Josefsson wrote: > > The test-vc-list-files-cvs.sh self test appears to fail on minimal > > debian lenny installations: > > > > http://autobuild.josefsson.org/gnulib/log-200902170434329384000.txt > > http://autobuild.josefsson.or

Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan, > Just getting back to the fseeko() test. What exactly is meant to be > tested here ? This conditional means to test whether the last call was an fflush(), i.e. whether no I/O was done on the stream since the last fflush(). POSIX has a special requirement for fseeko that immediately follows

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Alan, > I see this has already landed in git, so let me know how you want to > handle any updates. Can you please take the current gnulib (git HEAD), execute the tests in the way I mentioned, show us the test failures (with line numbers of the failing ASSERT) and then put in the minimal set of

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Bruno, Just getting back to the fseeko() test. What exactly is meant to be tested here ? Can you explain as I don't quite understand why this is needed. > > --- lib/fseeko.c.orig 2009-02-28 21:09:16.0 +0100 > > +++ lib/fseeko.c2009-02-28 20:58:14.0 +0100 > > @@ -82,6

Re: compilation of findutils-4.4.0 with gcc-4.4.0-20090225 -- error with wctype.h in gnulib code

Frank Erens wrote: > > Please, on what system? You mentioned the compiler you are using, but the > > platform (`uname -srm`) is also mandatory information. > > > Sorry, I didn't knew this was important: > Linux 2.6.27-11-server i686 Thanks. Yes it's important so that we know at which copy of to l

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 21:30 +0100, Bruno Haible wrote: > Hi Alan, Hi Bruno ! > > > > > > Summary: Add support for Atari FreeMiNT OS > > > Project: GNU Core Utilities > > Looked briefly at the stdio extensions functions, so

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Bruce Korb wrote: > "implementations" are now allowed to reset the handler to > SIG_DFL on exec(2) Ah, an improvement indeed. > so it is "may not work" not "will not work". No, it's still "will not work" because the text is talking about the setting of SIGCHLD in the process that it calling wait

Re: [patch #6758] Add support for Atari FreeMiNT OS

Hi Alan, > > > > Summary: Add support for Atari FreeMiNT OS > > Project: GNU Core Utilities Looked briefly at the stdio extensions functions, some things looked fishy: - In freading.c, the use of a field __flags and a mac

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Hey, I remember this! There was a long discussion about SIGCHLD vs. SIGCLD / SysVR4 vs. BSD on the Austin reflector. "implementations" are now allowed to reset the handler to SIG_DFL on exec(2), so it is "may not work" not "will not work". Anyway, the final answer is that all programs that want th

Re: [patch #6758] Add support for Atari FreeMiNT OS

On Sat, 2009-02-28 at 17:29 +0100, Jim Meyering wrote: > Alan Hourihane wrote: > > > > Summary: Add support for Atari FreeMiNT OS > > Project: GNU Core Utilities > > Thanks for the work. I've included that patch below for c

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Jim Meyering wrote: > > the change I could apply is to add a comment in the specification: > > "This function assumes that the signal handler for SIGCHLD is not set to > > SIG_IGN." > > Thanks. That's probably all that it can do. Done, see below. > Though isn't it better to say it assumes the h

Re: [patch #6758] Add support for Atari FreeMiNT OS

Alan Hourihane wrote: > > Summary: Add support for Atari FreeMiNT OS > Project: GNU Core Utilities Thanks for the work. I've included that patch below for convenience. Most of it applies to gnulib, so I've Cc'd its list. Th

Re: fts: make find *much* faster on dirent.d_type-challenged FS

On Sat, Feb 28, 2009 at 06:27:17AM -0700, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Tom G. Christensen on 2/27/2009 2:19 PM: > > On Fri, Feb 13, 2009 at 11:21:11AM +0100, Simon Josefsson wrote: > >> How does that work? Do most compilers out there really

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Bruno Haible wrote: > Jim Meyering wrote: >> [reviving an old thread...] > > This was a reply to > , > for those who - like me - lost the context after 4 months. > >> I confirmed that running with SIGCHLD ignored, and regardless

Re: %.1s format with vasnprintf reads more than one byte from argument

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 2/28/2009 8:05 AM: > Thanks. Still, I prefer to separate the two tests: It takes more time > to understand a test if it's clobbering the input data of the previous > test. > > Also, in the doc I prefer to keep a canonical

Re: %.1s format with vasnprintf reads more than one byte from argument

Eric Blake wrote: > Even worse. Cygwin 1.5.x appears to do just fine on 2-character strings, > but mishandles 1-character strings, always returning -1, and without > setting errno! Very weird: on OpenBSD the strings of length 1 work and the larger ones fail, and on Cygwin 1.5 it's just the opposi

Re: [PATCH] GNU/kOpenSolaris support

* Robert Millan wrote on Sat, Feb 28, 2009 at 03:52:56PM CET: > > Ping! Adding to this ping (sorry if I wasn't clear enough last time): the triplet has successfully been added to config.{guess,sub} (before it went into Libtool ;-) Cheers, Ralf

Re: [PATCH] GNU/kOpenSolaris support

Ping! On Wed, Feb 04, 2009 at 11:03:01PM +0100, Robert Millan wrote: > > Hi! > > Any news about this? > > On Mon, Jan 19, 2009 at 12:01:04PM +0100, Robert Millan wrote: > > > > Hi, > > > > A triplet for GNU/kOpenSolaris has been assigned in GNU config now. Here's > > the patch for gnulib to

Re: spurious "(cached)" output from AC_CACHE_VAL

Hello Eric, Bruno, * Eric Blake wrote on Sat, Feb 28, 2009 at 02:45:06PM CET: > According to Bruno Haible on 2/27/2009 3:36 PM: > > > > Eric Blake wrote in > > : > >> But your patch has merit in that it makes a nice macro name t

update build-aux/po/Makefile.in.in

When releasing gettext-0.17, I forgot to update this file in gnulib. Now done: 2009-02-28 Bruno Haible * build-aux/po/Makefile.in.in: Update from GNU gettext 0.17. Reported by Loïc Minier .

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Jim Meyering wrote: > [reviving an old thread...] This was a reply to , for those who - like me - lost the context after 4 months. > I confirmed that running with SIGCHLD ignored, and regardless > of which wait function it use

safe-alloc.h uses __GNUC_PREREQ without defining it

Building the latest snapshot on sparc-sun-solaris2.6 fails: In file included from safe-alloc.c:27: safe-alloc.h:30:21: error: missing binary operator before token "(" make[4]: *** [safe-alloc.o] Error 1 It seems __GNUC_PREREQ is used undefined at safe-alloc.h:30. -tgc

Re: spurious "(cached)" output from AC_CACHE_VAL

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 2/27/2009 3:36 PM: > > Eric Blake wrote in > : >> But your patch has merit in that it makes a nice macro name that explains >> what >> you are intendin

Re: fts: make find *much* faster on dirent.d_type-challenged FS

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Tom G. Christensen on 2/27/2009 2:19 PM: > On Fri, Feb 13, 2009 at 11:21:11AM +0100, Simon Josefsson wrote: >> How does that work? Do most compilers out there really support >> decl-after-stmt (not likely?!)? >> > MIPSpro on IRIX in C89

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

Paul Eggert wrote: > Eric Blake writes: >> I just checked POSIX, and this is entirely true - the exec*() family is >> allowed to inherit an ignored SIGCHLD, in deference to older systems like >> SysV; and wait()/waitpid() are allowed to fail with ECHILD if SIGCHLD is >> ignored. But most systems

Re: gnulib-tool bug

Bruno Haible wrote: > Eric Blake wrote: >>> This looks like a bug to me: \\ expands to nothing. No way to produce a >>> backslash in the replacement. >> I concur. > > Thanks. So I'm disabling --posix. Patch appended. > >> "... For each other encountered, the following >> character shall lose it