Re: expand-before-require bug

2009-01-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/28/2009 3:20 PM: >>> -# AC_DEFUN_ONCE(NAME, VALUE) >>> +# AC_DEFUN_ONCE([NAME], VALUE) >>> # -- >> Lengthen the separator line by two dashes, then commit. > > I disagree. Inside autoconf macro do

Re: expand-before-require bug

2009-01-28 Thread Bruno Haible
Eric Blake wrote: > > How about this work-around? > > > > > > -# AC_DEFUN_ONCE(NAME, VALUE) > > +# AC_DEFUN_ONCE([NAME], VALUE) > > # -- > > Lengthen the separator line by two dashes, then commit. I disagree. Inside autoconf macro documentation, brackets denote optional a

Re: mem*/strr*/etc... obsolete warnings

2009-01-28 Thread Mike Frysinger
On Wednesday 28 January 2009 05:02:37 Bruno Haible wrote: > Mike Frysinger wrote: > > i mean something simple like this (and the output from gnulib-tool still > > looks sane to me): > > --- a/modules/memcpy > > +++ b/modules/memcpy > > @@ -5,7 +5,7 @@ Status: > > obsolete > > > > Notice: > > -Thi

Re: url's in --help output

2009-01-28 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 1/27/2009 10:08 AM: >> >> What do you think of this followup, which makes complete sentences, and >> consistently brackets URLs inside <>? > > Since Jim already changed coreutils to use this proposed style, and I just > committed a patch to autoconf t

more require-before-expand items

2009-01-28 Thread Eric Blake
OK to apply this patch? Right now, the autoconf list is debating whether AC_PROG_AWK should remain AC_DEFUN or switch to AC_DEFUN_ONCE (we have already proven that AC_PROG_CC cannot be AC_DEFUN_ONCE, as existing macros intentionally use conditional expansion of the macro, and switching to defu

Re: url's in --help output

2009-01-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 1/27/2009 10:08 AM: > > What do you think of this followup, which makes complete sentences, and > consistently brackets URLs inside <>? Since Jim already changed coreutils to use this proposed style, and I just committed a

Re: expand-before-require bug

2009-01-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 1/28/2009 6:05 AM: > At least autoconf-2.59 warns: > > gnulib/m4/00gnulib.m4:11: warning: underquoted definition of NAME Over-eager sed script, if it is detecting and warning about the comments. > > How about this wor

Re: expand-before-require bug

2009-01-28 Thread Jim Meyering
Eric Blake wrote: ... >>From fcf62c3dfcc0a9ca32860327494e9971623f062c Mon Sep 17 00:00:00 2001 > From: Eric Blake > Date: Mon, 26 Jan 2009 09:08:48 -0700 > Subject: [PATCH] Backport improved autoconf semantics of AC_DEFUN_ONCE. > > * m4/00gnulib.m4: New file. Hi Eric, First, thanks for all your

Re: mem*/strr*/etc... obsolete warnings

2009-01-28 Thread Bruno Haible
Mike Frysinger wrote: > i mean something simple like this (and the output from gnulib-tool still > looks > sane to me): > --- a/modules/memcpy > +++ b/modules/memcpy > @@ -5,7 +5,7 @@ Status: > obsolete > > Notice: > -This module is obsolete. > +This module is obsolete (see gnulib.info::Obsole

[PATCH] useless-if-before-free: recognize more variants

2009-01-28 Thread Jim Meyering
FYI, I've just pushed the patch below. I added test cases to this stand-alone Makefile, but added the final one (for (void*)0) only after pushing the patch below. Then I realized that current limitations prevent detection of that variant of 0/NULL, so have just revised the script accordingly. u =