gnulib and autopoint

2008-12-06 Thread Sylvain Beucler
Hi, I'm trying to integrate gettext in my package. I'm following advice from: http://www.gnu.org/software/gnulib/manual/html_node/gettextize-and-autopoint.html Namely: "When a script of yours run autopoint, invoke gnulib-tool afterwards." However, I'm using 'autoreconf' (2.61), which runs 'aut

Re: stdio: don't replace fseek unless requested

2008-12-06 Thread Bruno Haible
Hi Simon, Simon Josefsson wrote on 2008-11-18: > The stdio.in.h file replaces the fseek function when that isn't > requested. There is a proper replacement for fseeko further down. How > about the patch below? What problem does this patch fix? Without it, fseek is kept consistent with fseeko. W

Re: 'make test' error

2008-12-06 Thread Bruno Haible
Eric Blake wrote: > In other words, it seems like we should consider > modifying the contract of c-stack to state that the application should not > modify SIGBUS handlers. Yes, right. I'm adding this comment: 2008-12-06 Bruno Haible <[EMAIL PROTECTED]> * lib/c-stack.h (c_stack_action):

Re: Bus error

2008-12-06 Thread Bruno Haible
Eric Blake wrote: > maybe swapping the order will help, where I install the > SIGBUS handler first, and then c_stack_action can optionally install an > alternate handler on platforms where it is needed for stack overflow? Yes, I was going to propose this too. Bruno

Re: special characters in filenames in error messages

2008-12-06 Thread Bruno Haible
Henri Sivonen wrote: > > So my proposal is: > > > > - For parsing: > > - If the first character is a '"', then the escaped syntax is > > in use. The filename is enclosed in "..."; inside, > > - occurrences of '"' and '%' are escaped as %22 and %25, > > respectively,

Re: Bus error

2008-12-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2008 7:20 AM: >>> Output from m4: >>> m4: internal error detected; please report this bug to <[EMAIL PROTECTED]>: >>> Bus error > > There is some chance that this test failure might be fixed by the patch I just > comm

Re: 'make test' error

2008-12-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2008 7:02 AM: > I have access to a MacOS X 10.5 machine. What happens in this test is that the > test program installs a SIGSEGV handler but then dies from a SIGBUS: Thanks for the research and gnulib patch. However,

Re: fts: expose dirent.d_type data when possible

2008-12-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2008 5:43 AM: >> + return MultiplyDeBruijnBitPosition[(uint32_t) (p * 0x077CB531UL) >> 27]; > > Why is this done at runtime? Is S_IFMT not guaranteed to be a compile-time > constant? Jim's later patches removed s_i

Re: gnulib-tool and autoreconf

2008-12-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2008 3:18 AM: > It would seem odd to have 'autoreconf' invoke 'gnulib-tool'. gnulib-tool > is a tool that *fetches* source files, whereas autoreconf is a tool that > *combines* source files, generating additional files

Re: gnulib and distros

2008-12-06 Thread James Youngman
On Tue, Nov 18, 2008 at 11:30 AM, Colin Watson <[EMAIL PROTECTED]> wrote: > "Convenience copies" of code have a bad reputation with distributions in > general, particularly with distribution security teams. For example, > zlib has had a couple of security flaws which we've had to fix in Debian > s

Re: Bus error

2008-12-06 Thread Bruno Haible
Thomas J. Duck wrote: > > I have installed m4-1.4.12 on my Mac OS X 10.4 system. 'Make > > check' results in the error below. If there is any further information > > you need, please let me know. --Tom > > > > Checking ./stackovf.test > > Stack soft limit set to 300K > > Failure - m4 aborted

Re: 'make test' error

2008-12-06 Thread Bruno Haible
Eric Blake wrote: > [adding bug-gnulib, since this affects the gnulib module c-stack] > > According to Bruce Dugan on 11/30/2008 9:40 PM: > > I'm not sure what system information you need. > > > > System Version: Mac OS X 10.5.5 (9F33) > > Kernel Version: Darwin 9.5.0 > > frei0r-plugins-1.1

Re: fts: expose dirent.d_type data when possible

2008-12-06 Thread Bruno Haible
Hi Jim, > > This is a constant you could compute at configure time, no? > > See AC_COMPUTE_INT. > > Sure, but why bother? Since any decent compiler will optimize that > function to "return 12;", I prefer to leave the function right next to > the code that uses it. GCC >= 4.0 optimizes away the

Re: fts: expose dirent.d_type data when possible

2008-12-06 Thread Bruno Haible
Jim Meyering wrote: > + /* Find the smallest power of two, P (e.g., 001) such that P & V == P. > */ > + unsigned int p = v ^ (v & (v - 1)); This is equivalent to unsigned int p = v & ~(v - 1); This latter expression may be clearer (depending on the reader's mental model of bitwise e

Re: gnulib and distros

2008-12-06 Thread Bruno Haible
Colin Watson wrote on 2008-11-18: > I'd much rather live in a world where people use > Gnulib and so are willing to use non-portable functions like > asprintf, canonicalize_file_name, openat, and so on than our current > world which is still full of stupid vulnerabilities due to peo

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-12-06 Thread Bruno Haible
Simon Josefsson wrote on 2008-11-18: > I'm trying to force gradual automation of it by making it a two-step > simple process: 1) Sync the list of all warnings with latest GCC > manual. 2) Re-compile and add exceptions for the new warning variables, > and if optionally human time is available, revie

Re: gnulib-tool and autoreconf

2008-12-06 Thread Bruno Haible
Colin Watson wrote: > I find the advice in gnulib's documentation "Caveat: gettextize and > autopoint users" rather difficult to follow in practice. I prefer to use > autoreconf rather than having to track which tools and options I'm > supposed to be using, but autoreconf invokes autopoint followed

Re: final snapshot in preparation for m4 1.4.12

2008-12-06 Thread Bruno Haible
Eric Blake wrote on 2008-09-29: > > On Irix 5.3 it skips test-cstack2.sh because it wants libsigsegv for full > > c-stack functionality and I did not test with that > > (Irix really needs libsigsegv 2.7 which is not yet released). > > That's Bruno's call It's OK that the test-c-stack2.sh test is