This sounds fine to me; I'll try to make time next week to enhance the
gnulib quotearg module to output this style.
That would be great, but please wait until rms has approved it (if we
propose it). I see little point in spending time on it otherwise.
karl
it would be a good idea for that to correspond to a
style constant for the gnulib quotearg module (default_gnu_style for
example). Even if that constant has the same value as some other name
(blah_octal_quoting_style, whatever)
Agreed.
* Simon Josefsson wrote on Sat, Nov 29, 2008 at 01:05:37PM CET:
> >> configure: creating ./config.status
> >> config.status: creating Makefile
> >> config.status: creating config.h
> >> config.status: linking ../../gltests/GNUmakefile to GNUmakefile
> >> config.status: error: ../../gltests/GNUmakef
Hi Bruno,
Sometimes I enable warnings about unused parameters.
When I do, it's distracting to see these go by:
unicodeio.c: In function 'exit_failure_callback':
unicodeio.c:172: warning: unused parameter 'callback_arg'
unicodeio.c: In function 'fallback_failure_callback':
unicodeio.c:185:
Jim Meyering <[EMAIL PROTECTED]> wrote:
> Jim Meyering <[EMAIL PROTECTED]> wrote:
>> "James Youngman" <[EMAIL PROTECTED]> wrote:
>>> As far as I can see, the variable type is assigned in the function
>>> above, but never used. Did you mean to use "type" rather than
>>> "dtype" in the expression
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Karl Berry on 11/28/2008 11:59 AM:
> After some additional discussion with the people who brought up the
> issue in the first place (cc'd), who wanted to use url's in GNU-style
> error messages, my new proposal is to use octal escapes \ooo
On Sat, Nov 29, 2008 at 3:46 PM, Jim Meyering <[EMAIL PROTECTED]> wrote:
> Jim Meyering <[EMAIL PROTECTED]> wrote:
>> "James Youngman" <[EMAIL PROTECTED]> wrote:
>>> As far as I can see, the variable type is assigned in the function
>>> above, but never used. Did you mean to use "type" rather tha
On Fri, Nov 28, 2008 at 6:59 PM, Karl Berry <[EMAIL PROTECTED]> wrote:
> Some months ago we discussed a convention for supporting "special"
> characters in filenames ("sources") in error messages. Our conclusion
> then was to support C-style escapes.
I'm all for bringing a measure of consistency
Jim Meyering <[EMAIL PROTECTED]> wrote:
> "James Youngman" <[EMAIL PROTECTED]> wrote:
>> As far as I can see, the variable type is assigned in the function
>> above, but never used. Did you mean to use "type" rather than
>> "dtype" in the expression which assigns to st->st_mode?
>
> Thanks again.
"James Youngman" <[EMAIL PROTECTED]> wrote:
> As far as I can see, the variable type is assigned in the function
> above, but never used. Did you mean to use "type" rather than
> "dtype" in the expression which assigns to st->st_mode?
Thanks again.
Here's the patch I'll push as soon as you say o
"James Youngman" <[EMAIL PROTECTED]> wrote:
>> +static void
>> +set_stat_type (struct stat *st, unsigned int dtype)
>> +{
>> + mode_t type;
>> + switch (dtype)
>> +{
>> +case DT_BLK:
>> + type = S_IFBLK;
>> + break;
>> +case DT_CHR:
>> + type = S_IFCHR;
>> + break;
"James Youngman" <[EMAIL PROTECTED]> wrote:
> On Fri, Nov 28, 2008 at 7:19 PM, Jim Meyering <[EMAIL PROTECTED]> wrote:
>
> First, many thanks for looking at this!
>
>
>> +/* Map the dirent.d_type value, DTYPE, to the corresponding stat.st_mode
>> + S_IF* bit and set ST.st_mode, thus clearing all
On Fri, Nov 28, 2008 at 7:19 PM, Jim Meyering <[EMAIL PROTECTED]> wrote:
First, many thanks for looking at this!
> +/* Map the dirent.d_type value, DTYPE, to the corresponding stat.st_mode
> + S_IF* bit and set ST.st_mode, thus clearing all other bits in that field.
> */
> +static void
> +se
Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
> Hi Jim,
>
> sorry for not looking earier.
Hi Ralf,
Thanks for looking.
> * Jim Meyering wrote on Sat, Nov 29, 2008 at 12:00:34PM CET:
>> +/* Return the number of bits by which a d_type value must be shifted
>> + left in order to put it into the S_IF
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> Hi Simon,
>
> * Simon Josefsson wrote on Sat, Nov 29, 2008 at 12:25:10PM CET:
>> configure: creating ./config.status
>> config.status: creating Makefile
>> config.status: creating config.h
>> config.status: linking ../../gltests/GNUmakefile to GNUmakef
Hi Jim,
sorry for not looking earier.
* Jim Meyering wrote on Sat, Nov 29, 2008 at 12:00:34PM CET:
> +/* Return the number of bits by which a d_type value must be shifted
> + left in order to put it into the S_IFMT bits of stat.st_mode. */
> +static int
> +s_ifmt_shift_bits (void)
> +{
> + un
Hi Simon,
* Simon Josefsson wrote on Sat, Nov 29, 2008 at 12:25:10PM CET:
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating config.h
> config.status: linking ../../gltests/GNUmakefile to GNUmakefile
> config.status: error: ../../gltests/GNUmakefile:
This set of commands:
gnulib-tool --create-testdir --dir m --with-tests maintainer-makefile
cd m
./configure
make distcheck
results in:
...
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: linking ../../gltests/GNUmakef
As discussed here,
http://lists.gnu.org/archive/html/bug-gnulib/2008-11/index.html
I've just pushed the following:
(one minor difference: updated comments in fts_.h, too)
>From 3270695f352a7ff69ba58424329ccbb0f91b47f3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Fri, 28
19 matches
Mail list logo
