Re: dependency creep: cond

2008-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Sam Steingold on 11/17/2008 12:21 PM: > Hi, > why does the cond module depend on > > errno > stdbool > time > gettimeofday > > it pulls in 4(!) packages. These are modules, not packages. They are much lighter-weight than packages. And

Re: gnulib: cond & spinlocks

2008-11-17 Thread Bruno Haible
Vladimir, Sam, > >> I plan to create the thread2 branch after I switch to gnulib > >> threadlib/lock/cond to get solaris and win32 "for free". As I wrote to Sam on 2008-08-17 in private mail: For clisp, I would attempt to stay with the POSIX threads API, rather than using gnulib's wrapper modules

[PATCH] maintainer-makefile: Fix sed regexp.

2008-11-17 Thread Simon Josefsson
Pushed. /Simon --- ChangeLog|5 + top/maint.mk |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8ae6063..d9673ec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2008-11-18 Simon Josefsson <[EMAIL PROTECTED]> + + * t

Re: dependency creep: cond

2008-11-17 Thread Bruno Haible
Hi Sam, > why does the cond module depend on > > errno > stdbool > time > gettimeofday It depends on - errno because glthread_cond_timedwait may return ETIMEDOUT, an errno value which is missing on some systems, - stdbool because gl_cond_timedwait returns a boolean value, - time becaus

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Paolo Bonzini
Ralf Wildenhues wrote: > * Paolo Bonzini wrote on Mon, Nov 17, 2008 at 10:42:24PM CET: >> Forgot one: >> >> for w in "$@"; do > > No. You *really* want > for w > do > > as I wrote already. Right, I hadn't seen your message, sorry. Paolo

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Mon, Nov 17, 2008 at 10:42:24PM CET: > Forgot one: > > for w in "$@"; do No. You *really* want for w do as I wrote already. This is all documented in autoconf.info. Cheers, Ralf

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Paolo Bonzini
Paolo Bonzini wrote: >> +# does OUTVAR = LISTVAR \ REMOVEVAR. >> +AC_DEFUN([gl_WARN_COMPLEMENT], >> +[ >> + FOO= > > FOO? gl_new_list at the very least. > >> + set -- "$2" > > set args $2; shift > >> + for w in $_; do Forgot one: for w in "$@"; do >> +case "$3" in >> + *" $w "* |

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: Paolo Bonzini <[EMAIL PROTECTED]> writes: ... Thanks for feedback. I've pushed this. /Simon >From ceb6e31c70e82abcb29c58c429683dd89969935b Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[EMAIL PROTECTED]> Date: Mon, 17 Nov 2008 22:11:30 +0100 Subjec

gnulib: cond & spinlocks

2008-11-17 Thread Sam Steingold
Bruno, would it be possible to make gnulib cond allocate on stack? would it be possible to use fast clisp spinlocks in gnulib lock? Thanks. Vladimir Tzankov wrote: On Nov 17, 2008, at 9:28 PM, Sam Steingold wrote: I plan to create the thread2 branch after I switch to gnulib threadlib/lock/cond

Re: warning: module to simplify adding compiler warnings

2008-11-17 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> I want to add some warning flags from configure, including -Werror. > > You can use AC_PREPROC_IFELSE if using GCC: > > $ gcc -E -x c /dev/null -Wno-frobnicate > cc1: error: unrecognized command line option "-Wno-frobnicate" > >

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Paolo Bonzini
> +# does OUTVAR = LISTVAR \ REMOVEVAR. > +AC_DEFUN([gl_WARN_COMPLEMENT], > +[ > + FOO= FOO? gl_new_list at the very least. > + set -- "$2" set args $2; shift > + for w in $_; do > +case "$3" in > + *" $w "* | *" $w" | "$w "*) case " $3 " in *" $w "*) ;; Paolo

dependency creep: cond

2008-11-17 Thread Sam Steingold
Hi, why does the cond module depend on errno stdbool time gettimeofday I expected it to be similar to threadlib and lock in that it unifies the existing system functionality under a uniform API, and it turns out that it pulls in 4(!) packages. is it possible to have a package condlib similar t

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Mon, Nov 17, 2008 at 05:45:46PM CET: > +AC_DEFUN([gl_WARN_COMPLEMENT], > +[ > + FOO= > + set -- "$2" 'set --' is told to not be fully portable. Why don't you allow word-splitting $2 here, so that ... > + for w in $_; do ... here, you don't have to use un

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Simon Josefsson
Follow-up fix. /Simon >From c23fafe9a03c4216789d09d65224d9200d528026 Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[EMAIL PROTECTED]> Date: Mon, 17 Nov 2008 18:17:11 +0100 Subject: [PATCH] Fix last commit. --- m4/warnings.m4 |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) di

[PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

2008-11-17 Thread Simon Josefsson
Pushed. /Simon --- ChangeLog |4 ++ m4/warnings.m4 | 84 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index b5a87b2..0d3139c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2008-1

Re: select self-tests causes build failures under mingw

2008-11-17 Thread Paolo Bonzini
Simon Josefsson wrote: > Paolo Bonzini <[EMAIL PROTECTED]> writes: > >>> Maybe gnulib self-tests directories should have their own configure.ac >>> and config.h, although I fear the build-times of having 6 CONFIG_SUBDIR >>> statements in GnuTLS... I'd probably prefer to disable the gnulib >>> sel

Re: select self-tests causes build failures under mingw

2008-11-17 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: >> Maybe gnulib self-tests directories should have their own configure.ac >> and config.h, although I fear the build-times of having 6 CONFIG_SUBDIR >> statements in GnuTLS... I'd probably prefer to disable the gnulib >> self-tests. Even the move to 3 CO

Re: select self-tests causes build failures under mingw

2008-11-17 Thread Paolo Bonzini
> Maybe gnulib self-tests directories should have their own configure.ac > and config.h, although I fear the build-times of having 6 CONFIG_SUBDIR > statements in GnuTLS... I'd probably prefer to disable the gnulib > self-tests. Even the move to 3 CONFIG_SUBDIR's causes significant > slow-down.

Re: select self-tests causes build failures under mingw

2008-11-17 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> GnuTLS fails to build under mingw (see output below), and the reason is >> that the select-tests module depends on gettimeofday module, which under >> mingw does this: >> >> AC_DEFINE([localtime], [rpl_localtime], >> [Def

Re: select self-tests causes build failures under mingw

2008-11-17 Thread Paolo Bonzini
Simon Josefsson wrote: > GnuTLS fails to build under mingw (see output below), and the reason is > that the select-tests module depends on gettimeofday module, which under > mingw does this: > > AC_DEFINE([localtime], [rpl_localtime], > [Define to rpl_localtime if the replacement function sh

select self-tests causes build failures under mingw

2008-11-17 Thread Simon Josefsson
GnuTLS fails to build under mingw (see output below), and the reason is that the select-tests module depends on gettimeofday module, which under mingw does this: AC_DEFINE([localtime], [rpl_localtime], [Define to rpl_localtime if the replacement function should be used.]) This re-definition

Re: constified parse_duration()

2008-11-17 Thread Bruno Haible
Hi Bruce, > > So, it took 20 minutes to clean up. Attached. > > I should have tested better. I've included a test program and script now. Thanks. I have committed it into gnulib, after adding module descriptions and removing a "Written by Bruno Haible" comment from the test. 2008-11-17 Bruce

Re: warning: module to simplify adding compiler warnings

2008-11-17 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: > This is likely a autoconf or automake question, but since it was related > to the warnings module, and some of the relevant people is on this list > as well, I'm trying to raise it here: > > How do I get the WARN_CFLAGS variable defined in all of my Ma

Re: parse_duration()

2008-11-17 Thread Bruno Haible
Bruce Korb wrote: > I found my round tuit: The problem with "char const" is that > strtoul takes a "char **" as its second argument. So it is > rather a bother to recast a "char const **" address to "char **" > all the time. Yes, it is a bit of a problem. You can work around it by declaring the

Re: test-select-out failures

2008-11-17 Thread Bruno Haible
Simon Josefsson wrote: > It doesn't solve the problem on my system, though: > ... > > It seems to happen on my build machine as well: It also happened on Haiku, and I could not find a workaround. So I disabled this part of the test: 2008-11-17 Bruno Haible <[EMAIL PROTECTED]> * tests

Re: getaddrinfo: port to Haiku

2008-11-17 Thread Bruno Haible
Simon Josefsson wrote: > I like the intention with the patch, and will test after it has been > pushed. Please go ahead. Committed. Bruno

Re: getaddrinfo: port to Haiku

2008-11-17 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Hi Simon, > > Here comes a patch to change the getaddrinfo module to make use of the new > modules 'servent' and 'hostent'. I have tested this on Linux, Solaris, > mingw, and Haiku. > > OK to apply, or objections? I like the intention with the patch, and

Re: scokets: add support for Haiku and BeOS

2008-11-17 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Hi Simon, > > The sockets module knows how to find the sockets library on Windows and > Solaris. Here's a patch that adds support for Haiku (needs to link > with -lnetwork) and BeOS (needs to link with -lnet). > > OK to apply? Hi. Yes, please do. /Simo