Re: tee logs no output if stdout is closed

2008-10-05 Thread Bruno Haible
After the newest changes to gnulib, here's a revised version of the patch proposed in From a4434d71a1a3ec7a6aee6de4a81da36301b12a28 Mon Sep 17 00:00:00 2001 From: Bruno Haible <[EMAIL PROTECTED]> Date: Mon, 6 Oct 2008 02:58:5

Re: tee logs no output if stdout is closed

2008-10-05 Thread Bruno Haible
Jim Meyering wrote: > Thanks for writing all that. The code looks fine. Glad to see that our disagreements have been reduced to the comments. > Let's not use "signaled" here. Yes, indeed this term is confusing in a paragraph dealing with signals. > How about this in place of the above: > > /

Re: [PATCH] implement full-blown select(2) for winsock

2008-10-05 Thread Bruno Haible
And this implements the modules for most of the functions from . The functions 'ioctl' and 'close' are not handled in this patch; they are a little more complicated. 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * modules/accept: New file. * modules/bind: New file. * modu

Re: [PATCH 2/3] add winsock wrappers

2008-10-05 Thread Bruno Haible
I'm applying these (obvious) tweaks. The 'errno' module is needed because of the reference to EWOULDBLOCK added recently. 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * lib/winsock.c (strerror): Remove unused #undef. (rpl_close): Remove unused local variable. * modules/s

Re: [PATCH] implement full-blown select(2) for winsock

2008-10-05 Thread Bruno Haible
Paolo Bonzini wrote: > What I meant was, having a link warning like for > other gnulib modules would be good *even when you are not under mingw* > (i.e. even where select works). OK, I see. I'm adding this as a link warning conditionalized by GNULIB_POSIXCHECK. I cannot make it unconditional, othe

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > * Jim Meyering wrote on Sun, Oct 05, 2008 at 07:42:45PM CEST: >> Bruno Haible <[EMAIL PROTECTED]> wrote: >> > >> > \> is also not a portable piece of regular expression: not in a basic >> > regex, >> > and not in an extended regex. It is a GNU extensio

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Ralf Wildenhues
* Jim Meyering wrote on Sun, Oct 05, 2008 at 07:42:45PM CEST: > Bruno Haible <[EMAIL PROTECTED]> wrote: > > > > \> is also not a portable piece of regular expression: not in a basic regex, > > and not in an extended regex. It is a GNU extension. > > It works with Solaris 10's grep, > so maybe it w

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Unfortunate, but true. >> Thanks. How about this? >> ... >> +grep '^[ ]*A[CM]_PROG_LIBTOOL\>' configure.ac >/dev/null \ > > \> is also not a portable piece of regular expression: not in a basic regex, > and not in an exte

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Bruno Haible
Jim Meyering wrote: > Unfortunate, but true. > Thanks. How about this? > ... > +grep '^[ ]*A[CM]_PROG_LIBTOOL\>' configure.ac >/dev/null \ \> is also not a portable piece of regular expression: not in a basic regex, and not in an extended regex. It is a GNU extension. Bruno

Re: [PATCH] implement full-blown select(2) for winsock

2008-10-05 Thread Paolo Bonzini
Bruno Haible wrote: > Paolo Bonzini wrote: >>> Here is a proposal that should acknowledge both of your arguments: >>> Provide separate modules 'select' separate from 'sys_select', like we do >>> in the rest of gnulib, but if 'sys_select' is used without 'select', then >>> #define select select_us

Re: tee logs no output if stdout is closed

2008-10-05 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> > You can distinguish close_stream and close_stdout. close_stream is library >> > code, >> > close_stdout is not. What about a 'bool ignore_epipe' that influences the >> > behaviour of close_stdout? Whereas the library code that cal

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: >> -grep '^[ ]*A[CM]_PROG_LIBTOOL\>' configure.ac >/dev/null || >> +grep -E '^[ ]*(LT_INIT|A[CM]_PROG_LIBTOOL)\>' configure.ac >> >/dev/null || > > Solaris 9 'grep' does not support the '-E' option. This is documented in the > autoconf m

Re: on OSF/1

2008-10-05 Thread Bruno Haible
Paolo Bonzini wrote: > > The patch is obviously correct. You can apply it, together with this > > enhancement of the unit test. I'll test it in the next few days. > > Done. I'm updating the doc: 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * doc/posix-headers/sys_select.texi: Mention '

Re: [PATCH] implement full-blown select(2) for winsock

2008-10-05 Thread Bruno Haible
Paolo Bonzini wrote: > > Here is a proposal that should acknowledge both of your arguments: > > Provide separate modules 'select' separate from 'sys_select', like we do > > in the rest of gnulib, but if 'sys_select' is used without 'select', then > > #define select select_used_without_requesting_

Re: new module 'getdtablesize'

2008-10-05 Thread Bruno Haible
This is the simplification done to the posix_spawn* modules: 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * lib/spawn_faction_addclose.c (__sysconf): Use getdtablesize always. * lib/spawn_faction_adddup2.c (__sysconf): Likewise. * lib/spawn_faction_addopen.c (__sysconf):

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Bruno Haible
Hi Jim, > -grep '^[ ]*A[CM]_PROG_LIBTOOL\>' configure.ac >/dev/null || > +grep -E '^[ ]*(LT_INIT|A[CM]_PROG_LIBTOOL)\>' configure.ac > >/dev/null || Solaris 9 'grep' does not support the '-E' option. This is documented in the autoconf manual: Traditional `grep' implementatio

Re: sched: a typo?

2008-10-05 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Correct. I noticed this independently. (I've started to cross-compile to > mingw too...) But you were quicker by an hour. Thanks for fixing it. /Simon

Re: sched: a typo?

2008-10-05 Thread Bruno Haible
Simon Josefsson wrote: > diff --git a/modules/sched b/modules/sched > index e125fba..d08f4f2 100644 > --- a/modules/sched > +++ b/modules/sched > @@ -11,7 +11,7 @@ configure.ac: > gl_SCHED_H > > Makefile.am: > -BUILT_SOURCES += $(SPAWN_H) > +BUILT_SOURCES += $(SCHED_H) > > # We need the foll

new module 'getdtablesize'

2008-10-05 Thread Bruno Haible
This is a low-hanging fruit. But it allows to simplify the posix_spawn_* modules a bit. 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> New module 'getdtablesize'. * lib/unistd.in.h (getdtablesize): New declaration. * lib/getdtablesize.c: New file. * m4/getdtablesize

Re: new modules 'posix_spawn', 'posix_spawnp', 'spawn', 'sched'

2008-10-05 Thread Bruno Haible
Oops, the 'sched' module was not well tested. 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * modules/sched (Makefile.am): Fix typo. --- modules/sched.orig 2008-10-05 16:34:28.0 +0200 +++ modules/sched 2008-10-05 15:16:36.0 +0200 @@ -11,7 +11,7 @@ gl_SCHED_H M

sched: a typo?

2008-10-05 Thread Simon Josefsson
Is this correct? /Simon diff --git a/modules/sched b/modules/sched index e125fba..d08f4f2 100644 --- a/modules/sched +++ b/modules/sched @@ -11,7 +11,7 @@ configure.ac: gl_SCHED_H Makefile.am: -BUILT_SOURCES += $(SPAWN_H) +BUILT_SOURCES += $(SCHED_H) # We need the following in order to cre

Re: [PATCH] implement full-blown select(2) for winsock

2008-10-05 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Is this acceptable to both of you? Yes, I like it. I believe the approach would break in GnuTLS which uses its own select-replacement for Mingw32, or at least trigger a warning about re-#define'ing select, but I'll deal with that by using the select mod

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > * Jim Meyering wrote on Sun, Oct 05, 2008 at 01:01:14PM CEST: >> "Debarshi Ray" <[EMAIL PROTECTED]> wrote: >> >> Subject: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as >> >> AM_PROG_LIBTOOL > >> >> * build-aux/bootstrap: Check for AC_PROG_LIB

Re: posix_spawn on AIX

2008-10-05 Thread Bruno Haible
> 2008-10-04 Bruno Haible <[EMAIL PROTECTED]> > > * lib/spawn.in.h (POSIX_SPAWN_*): Undefine before redefining. > Reported by Rainer Tammer <[EMAIL PROTECTED]>. It may be wiser to reuse the values of these macros when defined by the system. Applied this: 2008-10-05 Bruno Haible

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Ralf Wildenhues
* Jim Meyering wrote on Sun, Oct 05, 2008 at 01:01:14PM CEST: > "Debarshi Ray" <[EMAIL PROTECTED]> wrote: > >> Subject: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as > >> AM_PROG_LIBTOOL > >> * build-aux/bootstrap: Check for AC_PROG_LIBTOOL, as well as the > >> obsolete AM_PROG_LIBTOOL.

Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

2008-10-05 Thread Jim Meyering
"Debarshi Ray" <[EMAIL PROTECTED]> wrote: >> Subject: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as >> AM_PROG_LIBTOOL > > Wow! Thanks a lot. Will this make its way into build-aux/bootstrap of > Gnulib as well? That *was* for gnulib. I'm Cc'ing the right list this time. >> * build-aux/